DEV: Add unique constraint to the name column of the ai_tools table

Author: nvh0412

app/models/ai_tool.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class AiTool < ActiveRecord::Base
-  validates :name, presence: true, length: { maximum: 100 }
+  validates :name, presence: true, length: { maximum: 100 }, uniqueness: true
   validates :tool_name, presence: true, length: { maximum: 100 }
   validates :description, presence: true, length: { maximum: 1000 }
   validates :summary, presence: true, length: { maximum: 255 }

config/locales/client.en.yml

@@ -211,7 +211,7 @@ en:
       tools:
         back: "Back"
         short_title: "Tools"
-        new: "New tool"
+        new: "New Tool"
         name: "Name"
         name_help: "Name will show up in the Discourse UI and is the short identifier you will use to find the tool in various settings, it should be distinct (it is required)"
         tool_name: "Tool Name"

db/migrate/20241023041242_add_unique_constraint_to_ai_tools.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+class AddUniqueConstraintToAiTools < ActiveRecord::Migration[7.1]
+  def up
+    # We need to remove duplicates before adding the unique constraint
+    execute <<~SQL
+      WITH duplicates AS (
+        SELECT name, COUNT(*) as count, MIN(id) as keeper_id
+        FROM ai_tools
+        GROUP BY name
+        HAVING COUNT(*) > 1
+      )
+      UPDATE ai_tools AS p
+      SET name = CONCAT(p.name, p.id)
+      FROM duplicates d
+      WHERE p.name = d.name
+      AND p.id != d.keeper_id;
+    SQL
+
+    add_index :ai_personas, :name, unique: true, if_not_exists: true
+  end
+
+  def down
+    remove_index :ai_personas, :name, if_exists: true
+  end
+end

spec/requests/admin/ai_tools_controller_spec.rb

@@ -138,20 +138,6 @@
     end
   end
 
-  describe "GET #check_name" do
-    it "call ToolNameChecker and returns the result" do
-      allow(DiscourseAi::ToolNameChecker).to receive(:new).and_return(
-        instance_double(DiscourseAi::ToolNameChecker, check: { available: true }),
-      )
-
-      get "/admin/plugins/discourse-ai/ai-tools/check-name.json?tool_name=TestTool"
-
-      expect(DiscourseAi::ToolNameChecker).to have_received(:new).with("TestTool")
-      expect(response).to be_successful
-      expect(response.parsed_body).to eq("available" => true)
-    end
-  end
-
   describe "#test" do
     it "runs an existing tool and returns the result" do
       post "/admin/plugins/discourse-ai/ai-tools/test.json",