FIX: Add a max token limit based on the text to be translated

Author: nattsw

lib/translation/base_translator.rb

@@ -46,12 +46,24 @@ def get_translation(text:, bot:, translation_user:)
             topic: @topic,
             post: @post,
           )
+        max_tokens = get_max_tokens(text)
+        llm_args = { max_tokens: }
 
         result = +""
-        bot.reply(context) { |partial| result << partial }
+        bot.reply(context, llm_args:) { |partial| result << partial }
         result
       end
 
+      def get_max_tokens(text)
+        if text.length < 100
+          500
+        elsif text.length < 500
+          1000
+        else
+          text.length * 2
+        end
+      end
+
       def persona_setting
         raise NotImplementedError
       end

spec/lib/translation/base_translator_spec.rb

@@ -36,6 +36,61 @@
       end
     end
 
+    it "creates BotContext with the correct parameters and calls bot.reply with correct args" do
+      post_translator =
+        DiscourseAi::Translation::PostRawTranslator.new(
+          text:,
+          target_locale:,
+          post:,
+          topic: post.topic,
+        )
+
+      expected_content = { content: text, target_locale: target_locale }.to_json
+
+      expect(DiscourseAi::Personas::BotContext).to receive(:new).with(
+        user: an_instance_of(User),
+        skip_tool_details: true,
+        feature_name: "translation",
+        messages: [{ type: :user, content: expected_content }],
+        topic: post.topic,
+        post: post,
+      ).and_call_original
+
+      mock_bot = instance_double(DiscourseAi::Personas::Bot)
+      expect(DiscourseAi::Personas::Bot).to receive(:as).and_return(mock_bot)
+      expect(mock_bot).to receive(:reply).with(
+        an_instance_of(DiscourseAi::Personas::BotContext),
+        llm_args: {
+          max_tokens: 500,
+        },
+      ).and_yield(llm_response)
+
+      post_translator.translate
+    end
+
+    it "sets max_tokens correctly based on text length" do
+      test_cases = [
+        ["Short text", 500], # Short text (< 100 chars)
+        ["a" * 200, 1000], # Medium text (100-500 chars)
+        ["a" * 600, 1200], # Long text (> 500 chars, 600*2=1200)
+      ]
+
+      test_cases.each do |text, expected_max_tokens|
+        translator = DiscourseAi::Translation::PostRawTranslator.new(text: text, target_locale:)
+
+        mock_bot = instance_double(DiscourseAi::Personas::Bot)
+        expect(DiscourseAi::Personas::Bot).to receive(:as).and_return(mock_bot)
+        expect(mock_bot).to receive(:reply).with(
+          an_instance_of(DiscourseAi::Personas::BotContext),
+          llm_args: {
+            max_tokens: expected_max_tokens,
+          },
+        ).and_yield("translated #{text[0..10]}")
+
+        translator.translate
+      end
+    end
+
     it "returns the translation from the llm's response" do
       DiscourseAi::Completions::Llm.with_prepared_responses([llm_response]) do
         expect(