shorten tokens to 5 so scan is faster

Author: SamSaffron

lib/ai_moderation/spam_scanner.rb

@@ -130,7 +130,7 @@ def self.test_post(post, custom_instructions: nil)
           llm.generate(
             prompt,
             temperature: 0.1,
-            max_tokens: 100,
+            max_tokens: 5,
             user: Discourse.system_user,
             feature_name: "spam_detection_test",
             feature_context: {
@@ -158,9 +158,27 @@ def self.test_post(post, custom_instructions: nil)
         log << "LLM: #{settings.llm_model.name}\n\n"
         log << "System Prompt: #{build_system_prompt(custom_instructions)}\n\n"
         log << "Context: #{context}\n\n"
-        log << "Result: #{result}"
+        log << "Result: #{result}\n\n"
 
         is_spam = check_if_spam(result)
+
+        prompt.push(type: :model, content: result)
+        prompt.push(type: :user, content: "Explain your reasoning")
+
+        reasoning =
+          llm.generate(
+            prompt,
+            temperature: 0.1,
+            max_tokens: 100,
+            user: Discourse.system_user,
+            feature_name: "spam_detection_test",
+            feature_context: {
+              post_id: post.id,
+            },
+          )&.strip
+
+        log << "Reasoning: #{reasoning}"
+
         { is_spam: is_spam, log: log }
       end
 
@@ -191,7 +209,7 @@ def self.perform_scan(post)
             llm.generate(
               prompt,
               temperature: 0.1,
-              max_tokens: 100,
+              max_tokens: 5,
               user: Discourse.system_user,
               feature_name: "spam_detection",
               feature_context: {
@@ -214,8 +232,12 @@ def self.perform_scan(post)
             handle_spam(post, log) if is_spam
           end
         rescue StandardError => e
-          raise e if Rails.env.test?
-          Discourse.warn_exception(e, message: "Error in SpamScanner for post #{post.id}")
+          # we need retries otherwise stuff will not be handled
+          Discourse.warn_exception(
+            e,
+            message: "Discourse AI: Error in SpamScanner for post #{post.id}",
+          )
+          raise e
         end
       end
 

spec/lib/modules/ai_moderation/spam_scanner_spec.rb

@@ -159,6 +159,32 @@
 
     before { Jobs.run_immediately! }
 
+    it "Can correctly run tests" do
+      prompts = nil
+      result =
+        DiscourseAi::Completions::Llm.with_prepared_responses(
+          ["spam", "the reason is just because"],
+        ) do |_, _, _prompts|
+          prompts = _prompts
+          described_class.test_post(post, custom_instructions: "123")
+        end
+
+      expect(prompts.length).to eq(2)
+      expect(result[:is_spam]).to eq(true)
+      expect(result[:log]).to include("123")
+      expect(result[:log]).to include("just because")
+
+      result =
+        DiscourseAi::Completions::Llm.with_prepared_responses(
+          ["not_spam", "the reason is just because"],
+        ) do |_, _, _prompts|
+          prompts = _prompts
+          described_class.test_post(post, custom_instructions: "123")
+        end
+
+      expect(result[:is_spam]).to eq(false)
+    end
+
     it "Correctly handles spam scanning" do
       expect(described_class.flagging_user.id).not_to eq(Discourse.system_user.id)
 

spec/requests/admin/ai_spam_controller_spec.rb

@@ -97,7 +97,7 @@
     before { sign_in(admin) }
 
     it "can scan using post url" do
-      DiscourseAi::Completions::Llm.with_prepared_responses(["spam"]) do
+      DiscourseAi::Completions::Llm.with_prepared_responses(["spam", "just because"]) do
         post "/admin/plugins/discourse-ai/ai-spam/test.json", params: { post_url: spam_post2.url }
       end
 
@@ -108,7 +108,7 @@
     end
 
     it "can scan using post id" do
-      DiscourseAi::Completions::Llm.with_prepared_responses(["spam"]) do
+      DiscourseAi::Completions::Llm.with_prepared_responses(["spam", "because apples"]) do
         post "/admin/plugins/discourse-ai/ai-spam/test.json",
              params: {
                post_url: spam_post.id.to_s,
@@ -133,7 +133,7 @@
 
       AiSpamLog.create!(post: spam_post, llm_model: llm_model, is_spam: true, created_at: 1.day.ago)
 
-      DiscourseAi::Completions::Llm.with_prepared_responses(["spam"]) do
+      DiscourseAi::Completions::Llm.with_prepared_responses(["spam", "because banana"]) do
         post "/admin/plugins/discourse-ai/ai-spam/test.json",
              params: {
                post_url: spam_post.url,
@@ -148,6 +148,7 @@
       expect(parsed["log"]).to include(spam_post.raw)
       expect(parsed["is_spam"]).to eq(true)
       expect(parsed["log"]).to include("Scan History:")
+      expect(parsed["log"]).to include("banana")
     end
   end