FIX: Check post action creator result when flagging spam

Currently in core re-flagging something that is already flagged as spam
is not supported, long term we may want to support this but in the meantime
we should not be silencing/hiding if the PostActionCreator fails
when flagging things as spam.

Author: martin-brennan

lib/ai_moderation/spam_scanner.rb

@@ -394,22 +394,27 @@ def self.handle_spam(post, log)
             queue_for_review: true,
           ).perform
 
-        log.update!(reviewable: result.reviewable)
-
-        reason = I18n.t("discourse_ai.spam_detection.silence_reason", url: url)
-        silencer =
-          UserSilencer.new(
-            post.user,
-            flagging_user,
-            message: :too_many_spam_flags,
-            post_id: post.id,
-            reason: reason,
-            keep_posts: true,
-          )
-        silencer.silence
+        # Currently in core re-flagging something that is already flagged as spam
+        # is not supported, long term we may want to support this but in the meantime
+        # we should not be silencing/hiding if the PostActionCreator fails.
+        if result.success?
+          log.update!(reviewable: result.reviewable)
+
+          reason = I18n.t("discourse_ai.spam_detection.silence_reason", url: url)
+          silencer =
+            UserSilencer.new(
+              post.user,
+              flagging_user,
+              message: :too_many_spam_flags,
+              post_id: post.id,
+              reason: reason,
+              keep_posts: true,
+            )
+          silencer.silence
 
-        # silencer will not hide tl1 posts, so we do this here
-        hide_post(post)
+          # silencer will not hide tl1 posts, so we do this here
+          hide_post(post)
+        end
       end
 
       def self.hide_post(post)

lib/automation/llm_triage.rb

@@ -88,15 +88,18 @@ def self.handle(
                 .sub("%%AUTOMATION_NAME%%", automation&.name.to_s)
 
             if flag_type == :spam || flag_type == :spam_silence
-              PostActionCreator.new(
-                Discourse.system_user,
-                post,
-                PostActionType.types[:spam],
-                message: score_reason,
-                queue_for_review: true,
-              ).perform
+              result =
+                PostActionCreator.new(
+                  Discourse.system_user,
+                  post,
+                  PostActionType.types[:spam],
+                  message: score_reason,
+                  queue_for_review: true,
+                ).perform
 
-              SpamRule::AutoSilence.new(post.user, post).silence_user if flag_type == :spam_silence
+              if flag_type == :spam_silence && result.success?
+                SpamRule::AutoSilence.new(post.user, post).silence_user
+              end
             else
               reviewable =
                 ReviewablePost.needs_review!(target: post, created_by: Discourse.system_user)

spec/lib/modules/ai_moderation/spam_scanner_spec.rb

@@ -214,7 +214,7 @@
 
     before { Jobs.run_immediately! }
 
-    it "Can correctly run tests" do
+    it "can correctly run tests" do
       prompts = nil
       result =
         DiscourseAi::Completions::Llm.with_prepared_responses(
@@ -240,7 +240,7 @@
       expect(result[:is_spam]).to eq(false)
     end
 
-    it "Correctly handles spam scanning" do
+    it "correctly handles spam scanning" do
       expect(described_class.flagging_user.id).not_to eq(Discourse.system_user.id)
 
       # flag post for scanning
@@ -288,6 +288,31 @@
       expect(post.topic.reload.visible).to eq(true)
       expect(post.user.reload.silenced?).to eq(false)
     end
+
+    it "does not silence the user or hide the post when a flag cannot be created" do
+      post = post_with_uploaded_image
+      Fabricate(
+        :post_action,
+        post: post,
+        user: described_class.flagging_user,
+        post_action_type_id: PostActionType.types[:spam],
+      )
+
+      described_class.new_post(post)
+
+      prompt = nil
+      DiscourseAi::Completions::Llm.with_prepared_responses(["spam"]) do |_, _, _prompts|
+        # force a rebake so we actually scan
+        post.rebake!
+        prompt = _prompts.first
+      end
+
+      log = AiSpamLog.find_by(post: post)
+
+      expect(log.reviewable).to be_nil
+      expect(post.user.reload.silenced_till).to be_nil
+      expect(post.topic.reload.visible).to eq(true)
+    end
   end
 
   it "includes location information and email in context" do

spec/lib/modules/automation/llm_triage_spec.rb

@@ -128,6 +128,28 @@ def triage(**args)
     expect(post.user.silenced?).to eq(true)
   end
 
+  it "does not silence the user if the flag fails" do
+    Fabricate(
+      :post_action,
+      post: post,
+      user: Discourse.system_user,
+      post_action_type_id: PostActionType.types[:spam],
+    )
+    DiscourseAi::Completions::Llm.with_prepared_responses(["bad"]) do
+      triage(
+        post: post,
+        model: "custom:#{llm_model.id}",
+        system_prompt: "test %%POST%%",
+        search_for_text: "bad",
+        flag_post: true,
+        flag_type: :spam_silence,
+        automation: nil,
+      )
+    end
+
+    expect(post.user.silenced?).to eq(false)
+  end
+
   it "can handle garbled output from LLM" do
     DiscourseAi::Completions::Llm.with_prepared_responses(["Bad.\n\nYo"]) do
       triage(