DEV: rely on default llm model in spec

keegangeorge · keegangeorge · commit 2377b286dde0 · 2025-07-15T09:56:24.000-07:00
diff --git a/spec/configuration/llm_validator_spec.rb b/spec/configuration/llm_validator_spec.rb
@@ -4,7 +4,7 @@
   describe "#valid_value?" do
     context "when the parent module is enabled and we try to reset the selected model" do
       before do
-        assign_fake_provider_to(:ai_summarization_model)
+        assign_fake_provider_to(:ai_default_llm_model)
         SiteSetting.ai_summarization_enabled = true
       end
 
diff --git a/spec/jobs/regular/fast_track_topic_gist_spec.rb b/spec/jobs/regular/fast_track_topic_gist_spec.rb
@@ -7,7 +7,8 @@
     fab!(:post_2) { Fabricate(:post, topic: topic_1, post_number: 2) }
 
     before do
-      assign_fake_provider_to(:ai_summarization_model)
+      assign_fake_provider_to(:ai_default_llm_model)
+
       SiteSetting.ai_summarization_enabled = true
       SiteSetting.ai_summary_gists_enabled = true
     end
diff --git a/spec/jobs/regular/stream_composer_helper_spec.rb b/spec/jobs/regular/stream_composer_helper_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe Jobs::StreamComposerHelper do
   subject(:job) { described_class.new }
 
-  before { assign_fake_provider_to(:ai_helper_model) }
+  before { assign_fake_provider_to(:ai_default_llm_model) }
 
   describe "#execute" do
     let!(:input) { "I liek to eet pie fur brakefast becuz it is delishus." }
diff --git a/spec/jobs/regular/stream_post_helper_spec.rb b/spec/jobs/regular/stream_post_helper_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe Jobs::StreamPostHelper do
   subject(:job) { described_class.new }
 
-  before { assign_fake_provider_to(:ai_helper_model) }
+  before { assign_fake_provider_to(:ai_default_llm_model) }
 
   describe "#execute" do
     fab!(:topic)
diff --git a/spec/jobs/regular/stream_topic_ai_summary_spec.rb b/spec/jobs/regular/stream_topic_ai_summary_spec.rb
@@ -11,7 +11,7 @@
 
     before do
       Group.find(Group::AUTO_GROUPS[:trust_level_3]).add(user)
-      assign_fake_provider_to(:ai_summarization_model)
+      assign_fake_provider_to(:ai_default_llm_model)
       SiteSetting.ai_summarization_enabled = true
     end
 
diff --git a/spec/jobs/scheduled/summaries_backfill_spec.rb b/spec/jobs/scheduled/summaries_backfill_spec.rb
@@ -8,7 +8,7 @@
   let(:intervals) { 12 } # budget is split into intervals. Job runs every five minutes.
 
   before do
-    assign_fake_provider_to(:ai_summarization_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_summarization_enabled = true
     SiteSetting.ai_summary_backfill_maximum_topics_per_hour = limit
     SiteSetting.ai_summary_gists_enabled = true
diff --git a/spec/lib/guardian_extensions_spec.rb b/spec/lib/guardian_extensions_spec.rb
@@ -7,7 +7,7 @@
 
   before do
     group.add(user)
-    assign_fake_provider_to(:ai_summarization_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_summarization_enabled = true
     SiteSetting.ai_summary_gists_enabled = true
   end
diff --git a/spec/lib/modules/ai_helper/assistant_spec.rb b/spec/lib/modules/ai_helper/assistant_spec.rb
@@ -5,7 +5,7 @@
   fab!(:empty_locale_user) { Fabricate(:user, locale: "") }
 
   before do
-    assign_fake_provider_to(:ai_helper_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     Group.refresh_automatic_groups!
   end
 
diff --git a/spec/lib/modules/ai_helper/chat_thread_titler_spec.rb b/spec/lib/modules/ai_helper/chat_thread_titler_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe DiscourseAi::AiHelper::ChatThreadTitler do
   subject(:titler) { described_class.new(thread) }
 
-  before { assign_fake_provider_to(:ai_helper_model) }
+  before { assign_fake_provider_to(:ai_default_llm_model) }
 
   fab!(:thread) { Fabricate(:chat_thread) }
   fab!(:chat_message) { Fabricate(:chat_message, thread: thread) }
diff --git a/spec/lib/modules/ai_helper/entry_point_spec.rb b/spec/lib/modules/ai_helper/entry_point_spec.rb
@@ -5,7 +5,7 @@
   fab!(:french_user) { Fabricate(:user, locale: "fr") }
 
   it "will correctly localize available prompts" do
-    assign_fake_provider_to(:ai_helper_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.default_locale = "en"
     SiteSetting.allow_user_locale = true
     SiteSetting.ai_helper_enabled = true
@@ -38,8 +38,7 @@
   end
 
   it "will include auto_image_caption field in the user_option if image caption is enabled" do
-    assign_fake_provider_to(:ai_helper_model)
-    assign_fake_provider_to(:ai_helper_image_caption_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_helper_enabled = true
     SiteSetting.ai_helper_enabled_features = "image_caption"
     SiteSetting.ai_auto_image_caption_allowed_groups = "10" # tl0
diff --git a/spec/lib/modules/ai_helper/painter_spec.rb b/spec/lib/modules/ai_helper/painter_spec.rb
@@ -6,7 +6,7 @@
   fab!(:user)
 
   before do
-    assign_fake_provider_to(:ai_helper_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_stability_api_url = "https://api.stability.dev"
     SiteSetting.ai_stability_api_key = "abc"
     SiteSetting.ai_openai_api_key = "abc"
diff --git a/spec/lib/modules/embeddings/semantic_search_spec.rb b/spec/lib/modules/embeddings/semantic_search_spec.rb
@@ -11,7 +11,7 @@
 
   before do
     SiteSetting.ai_embeddings_selected_model = vector_def.id
-    assign_fake_provider_to(:ai_embeddings_semantic_search_hyde_model)
+    assign_fake_provider_to(:ai_default_llm_model)
   end
 
   describe "#search_for_topics" do
diff --git a/spec/lib/modules/summarization/entry_point_spec.rb b/spec/lib/modules/summarization/entry_point_spec.rb
@@ -2,7 +2,7 @@
 
 RSpec.describe DiscourseAi::Summarization::EntryPoint do
   before do
-    assign_fake_provider_to(:ai_summarization_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_summarization_enabled = true
     SiteSetting.ai_summary_gists_enabled = true
   end
diff --git a/spec/lib/modules/summarization/fold_content_spec.rb b/spec/lib/modules/summarization/fold_content_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe DiscourseAi::Summarization::FoldContent do
   subject(:summarizer) { DiscourseAi::Summarization.topic_summary(topic) }
 
-  let!(:llm_model) { assign_fake_provider_to(:ai_summarization_model) }
+  let!(:llm_model) { assign_fake_provider_to(:ai_default_llm_model) }
 
   fab!(:topic) { Fabricate(:topic, highest_post_number: 2) }
   fab!(:post_1) { Fabricate(:post, topic: topic, post_number: 1, raw: "This is a text") }
diff --git a/spec/lib/personas/tools/search_spec.rb b/spec/lib/personas/tools/search_spec.rb
@@ -105,7 +105,8 @@
       after { DiscourseAi::Embeddings::SemanticSearch.clear_cache_for(query) }
 
       it "supports semantic search when enabled" do
-        assign_fake_provider_to(:ai_embeddings_semantic_search_hyde_model)
+        assign_fake_provider_to(:ai_default_llm_model)
+
         vector_def = Fabricate(:embedding_definition)
         SiteSetting.ai_embeddings_selected_model = vector_def.id
         SiteSetting.ai_embeddings_semantic_search_enabled = true
diff --git a/spec/lib/utils/search_spec.rb b/spec/lib/utils/search_spec.rb
@@ -141,7 +141,8 @@
       end
 
       it "includes semantic search results when enabled" do
-        assign_fake_provider_to(:ai_embeddings_semantic_search_hyde_model)
+        assign_fake_provider_to(:ai_default_llm_model)
+
         vector_def = Fabricate(:embedding_definition)
         SiteSetting.ai_embeddings_selected_model = vector_def.id
         SiteSetting.ai_embeddings_semantic_search_enabled = true
@@ -165,7 +166,8 @@
       end
 
       it "can disable semantic search with hyde parameter" do
-        assign_fake_provider_to(:ai_embeddings_semantic_search_hyde_model)
+        assign_fake_provider_to(:ai_default_llm_model)
+
         vector_def = Fabricate(:embedding_definition)
         SiteSetting.ai_embeddings_selected_model = vector_def.id
         SiteSetting.ai_embeddings_semantic_search_enabled = true
diff --git a/spec/models/user_option_spec.rb b/spec/models/user_option_spec.rb
@@ -9,8 +9,7 @@
   end
 
   before do
-    assign_fake_provider_to(:ai_helper_model)
-    assign_fake_provider_to(:ai_helper_image_caption_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_helper_enabled = true
     SiteSetting.ai_helper_enabled_features = "image_caption"
     SiteSetting.ai_auto_image_caption_allowed_groups = "10" # tl0
diff --git a/spec/plugin_spec.rb b/spec/plugin_spec.rb
@@ -7,7 +7,7 @@
     fab!(:user)
 
     before do
-      assign_fake_provider_to(:ai_helper_model)
+      assign_fake_provider_to(:ai_default_llm_model)
       SiteSetting.ai_helper_enabled = true
       SiteSetting.ai_helper_illustrate_post_model = "disabled"
       Group.find_by(id: Group::AUTO_GROUPS[:admins]).add(user)
diff --git a/spec/requests/admin/ai_llms_controller_spec.rb b/spec/requests/admin/ai_llms_controller_spec.rb
@@ -498,7 +498,6 @@
 
     it "logs staff action when deleting an LLM model" do
       # Capture the model details before deletion for comparison
-      model_id = llm_model.id
       model_display_name = llm_model.display_name
 
       # Delete the model
@@ -516,7 +515,7 @@
     end
 
     it "validates the model is not in use" do
-      fake_llm = assign_fake_provider_to(:ai_helper_model)
+      fake_llm = assign_fake_provider_to(:ai_default_llm_model)
 
       delete "/admin/plugins/discourse-ai/ai-llms/#{fake_llm.id}.json"
 
diff --git a/spec/requests/ai_helper/assistant_controller_spec.rb b/spec/requests/ai_helper/assistant_controller_spec.rb
@@ -6,6 +6,7 @@
 
   before do
     assign_fake_provider_to(:ai_default_llm_model)
+    SiteSetting.ai_helper_enabled = true
   end
 
   describe "#stream_suggestion" do
diff --git a/spec/requests/embeddings/embeddings_controller_spec.rb b/spec/requests/embeddings/embeddings_controller_spec.rb
@@ -120,7 +120,7 @@ def create_api_key(user)
     end
 
     it "doesn't skip HyDE if the hyde param is missing" do
-      assign_fake_provider_to(:ai_embeddings_semantic_search_hyde_model)
+      assign_fake_provider_to(:ai_default_llm_model)
       index(topic)
       index(topic_in_subcategory)
 
diff --git a/spec/requests/summarization/chat_summary_controller_spec.rb b/spec/requests/summarization/chat_summary_controller_spec.rb
@@ -7,7 +7,7 @@
   before do
     group.add(current_user)
 
-    assign_fake_provider_to(:ai_summarization_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_summarization_enabled = true
     SiteSetting.ai_custom_summarization_allowed_groups = group.id
 
diff --git a/spec/requests/summarization/summary_controller_spec.rb b/spec/requests/summarization/summary_controller_spec.rb
@@ -7,7 +7,7 @@
     fab!(:post_2) { Fabricate(:post, topic: topic, post_number: 2) }
 
     before do
-      assign_fake_provider_to(:ai_summarization_model)
+      assign_fake_provider_to(:ai_default_llm_model)
       SiteSetting.ai_summarization_enabled = true
     end
 
diff --git a/spec/services/discourse_ai/topic_summarization_spec.rb b/spec/services/discourse_ai/topic_summarization_spec.rb
@@ -7,7 +7,7 @@
   fab!(:post_2) { Fabricate(:post, topic: topic, post_number: 2) }
 
   before do
-    assign_fake_provider_to(:ai_summarization_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_summarization_enabled = true
   end
 
diff --git a/spec/system/admin_ai_features_spec.rb b/spec/system/admin_ai_features_spec.rb
@@ -13,7 +13,7 @@
   before do
     summarization_persona.allowed_group_ids = [group_1.id, group_2.id]
     summarization_persona.save!
-    assign_fake_provider_to(:ai_summarization_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_summarization_enabled = true
     SiteSetting.ai_summarization_persona = summarization_persona.id
     sign_in(admin)
diff --git a/spec/system/ai_helper/ai_composer_helper_spec.rb b/spec/system/ai_helper/ai_composer_helper_spec.rb
@@ -7,7 +7,7 @@
 
   before do
     Group.find_by(id: Group::AUTO_GROUPS[:admins]).add(user)
-    assign_fake_provider_to(:ai_helper_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_helper_enabled = true
     Jobs.run_immediately!
     sign_in(user)
diff --git a/spec/system/ai_helper/ai_image_caption_spec.rb b/spec/system/ai_helper/ai_image_caption_spec.rb
@@ -23,8 +23,7 @@
 
   before do
     Group.find_by(id: Group::AUTO_GROUPS[:admins]).add(user)
-    assign_fake_provider_to(:ai_helper_model)
-    assign_fake_provider_to(:ai_helper_image_caption_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_helper_enabled = true
     SiteSetting.ai_helper_enabled_features = "image_caption"
     sign_in(user)
diff --git a/spec/system/ai_helper/ai_post_helper_spec.rb b/spec/system/ai_helper/ai_post_helper_spec.rb
@@ -28,7 +28,7 @@
 
   before do
     Group.find_by(id: Group::AUTO_GROUPS[:admins]).add(user)
-    assign_fake_provider_to(:ai_helper_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_helper_enabled = true
     Jobs.run_immediately!
     sign_in(user)
diff --git a/spec/system/ai_helper/ai_proofreading_spec.rb b/spec/system/ai_helper/ai_proofreading_spec.rb
@@ -6,7 +6,7 @@
   fab!(:admin) { Fabricate(:admin, refresh_auto_groups: true) }
 
   before do
-    assign_fake_provider_to(:ai_helper_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_helper_enabled = true
 
     # This needs to be done because the streaming suggestions for composer
diff --git a/spec/system/ai_helper/ai_split_topic_suggestion_spec.rb b/spec/system/ai_helper/ai_split_topic_suggestion_spec.rb
@@ -39,7 +39,7 @@
 
   before do
     Group.find_by(id: Group::AUTO_GROUPS[:admins]).add(user)
-    assign_fake_provider_to(:ai_helper_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     SiteSetting.ai_helper_enabled = true
     sign_in(user)
   end
diff --git a/spec/system/ai_user_preferences_spec.rb b/spec/system/ai_user_preferences_spec.rb
@@ -12,8 +12,7 @@
     SiteSetting.discourse_ai_enabled = true
     SiteSetting.ai_bot_discover_persona = discovery_persona.id
     Group.find_by(id: Group::AUTO_GROUPS[:admins]).add(user)
-    assign_fake_provider_to(:ai_helper_model)
-    assign_fake_provider_to(:ai_helper_image_caption_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     sign_in(user)
   end
 
diff --git a/spec/system/summarization/chat_summarization_spec.rb b/spec/system/summarization/chat_summarization_spec.rb
@@ -11,7 +11,7 @@
   before do
     group.add(current_user)
 
-    assign_fake_provider_to(:ai_summarization_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     assign_persona_to(:ai_summarization_persona, [group.id])
     SiteSetting.ai_summarization_enabled = true
 
diff --git a/spec/system/summarization/topic_summarization_spec.rb b/spec/system/summarization/topic_summarization_spec.rb
@@ -23,7 +23,7 @@
   before do
     group.add(current_user)
 
-    assign_fake_provider_to(:ai_summarization_model)
+    assign_fake_provider_to(:ai_default_llm_model)
     assign_persona_to(:ai_summarization_persona, [group.id])
     SiteSetting.ai_summarization_enabled = true
 
