lint and address limit

Author: SamSaffron

db/migrate/20241206051225_add_ai_spam_logs.rb

@@ -7,7 +7,7 @@ def change
       t.bigint :ai_api_audit_log_id
       t.bigint :reviewable_id
       t.boolean :is_spam, null: false
-      t.text :payload, null: false, default: "", limit: 20_000
+      t.string :payload, null: false, default: "", limit: 20_000
       t.timestamps
     end
 

lib/ai_moderation/entry_point.rb

@@ -9,9 +9,7 @@ def inject_into(plugin)
         plugin.on(:post_process_cooked) { |_doc, post| SpamScanner.after_cooked_post(post) }
 
         plugin.on(:site_setting_changed) do |name, _old_value, new_value|
-          if name == :ai_spam_detection_enabled && new_value
-            SpamScanner.ensure_flagging_user!
-          end
+          SpamScanner.ensure_flagging_user! if name == :ai_spam_detection_enabled && new_value
         end
       end
     end

lib/ai_moderation/spam_scanner.rb

@@ -283,15 +283,13 @@ def self.hide_posts_and_topics(user)
               Post.hidden_reasons[:new_user_spam_threshold_reached],
             ],
           )
-        topic_ids = Post
-          .where(user_id: user.id, post_number: 1)
-          .where("created_at > ?", 24.hours.ago)
-          .select(:topic_id)
-
-        Topic
-          .where(id: topic_ids)
-          .update_all(visible: false)
+        topic_ids =
+          Post
+            .where(user_id: user.id, post_number: 1)
+            .where("created_at > ?", 24.hours.ago)
+            .select(:topic_id)
 
+        Topic.where(id: topic_ids).update_all(visible: false)
       end
     end
   end

spec/lib/modules/ai_moderation/spam_scanner_spec.rb

@@ -160,7 +160,6 @@
     before { Jobs.run_immediately! }
 
     it "Correctly handles spam scanning" do
-
       expect(described_class.flagging_user.id).not_to eq(Discourse.system_user.id)
 
       # flag post for scanning