DEV: remove unique index from tool_name column and add migrations to migrate name to tool_name

Author: nvh0412

app/models/ai_tool.rb

@@ -2,7 +2,7 @@
 
 class AiTool < ActiveRecord::Base
   validates :name, presence: true, length: { maximum: 100 }
-  validates :tool_name, presence: true, length: { maximum: 100 }, uniqueness: true
+  validates :tool_name, presence: true, length: { maximum: 100 }
   validates :description, presence: true, length: { maximum: 1000 }
   validates :summary, presence: true, length: { maximum: 255 }
   validates :script, presence: true, length: { maximum: 100_000 }
@@ -222,7 +222,7 @@ def self.presets
       },
       {
         preset_id: "stock_quote",
-        name: "Stock Quote",
+        name: "Stock Quote (AlphaVantage)",
         tool_name: "stock_quote",
         description: "Get real-time stock quote information using AlphaVantage API",
         parameters: [

app/services/discourse_ai/tool_name_checker.rb

@@ -8,20 +8,10 @@ def initialize(tool_name)
 
     def check
       if @tool_name.match? AiTool::ALPHANUMERIC_PATTERN
-        check_name_availability
+        { available: true }
       else
         { available: false, errors: [I18n.t("discourse_ai.tools.name.characters")] }
       end
     end
-
-    private
-
-    def check_name_availability
-      if AiTool.exists?(tool_name: @tool_name)
-        { available: false, errors: [I18n.t("errors.messages.taken")] }
-      else
-        { available: true }
-      end
-    end
   end
 end

config/locales/client.en.yml

@@ -212,9 +212,9 @@ en:
         back: "Back"
         short_title: "Tools"
         name: "Name"
-        name_help: "The unique name of the tool as used by the language model"
+        name_help: "Name will show up in the Discourse UI and is the short identifier you will use to find the tool in various settings, it should be distinct (it is required)"
         tool_name: "Tool Name"
-        tool_name_help: "Tool name, only include numbers, letters, and underscores"
+        tool_name_help: "Tool Name is presented to the large language model. It is not distinct, but it is distinct per persona. (persona validates on save)"
         description: "Description"
         description_help: "A clear description of the tool's purpose for the language model"
         summary: "Summary"

db/migrate/20241020010245_add_tool_name_to_ai_tools.rb

@@ -1,8 +1,17 @@
 # frozen_string_literal: true
 
 class AddToolNameToAiTools < ActiveRecord::Migration[7.1]
-  def change
+  def up
     add_column :ai_tools, :tool_name, :string, null: false, default: "", if_not_exists: true
-    add_index :ai_tools, :tool_name, unique: true, if_not_exists: true
+
+    # Migrate existing name to tool_name
+    execute <<~SQL
+      UPDATE ai_tools
+      SET tool_name = regexp_replace(LOWER(name),'[^a-z0-9_]','', 'g');
+    SQL
+  end
+
+  def down
+    remove_column :ai_tools, :tool_name, if_exists: true
   end
 end

spec/requests/admin/ai_tools_controller_spec.rb

@@ -97,12 +97,12 @@
       put "/admin/plugins/discourse-ai/ai-tools/#{ai_tool.id}.json",
           params: {
             ai_tool: {
-              name: "UpdatedTool",
+              name: "Updated Tool",
             },
           }
 
       expect(response).to be_successful
-      expect(ai_tool.reload.name).to eq("UpdatedTool")
+      expect(ai_tool.reload.name).to eq("Updated Tool")
     end
 
     context "when updating an enum parameters" do
@@ -170,7 +170,7 @@
       post "/admin/plugins/discourse-ai/ai-tools/test.json",
            params: {
              ai_tool: {
-               name: "NewTool",
+               name: "New Tool",
                description: "A new test tool",
                script: "function invoke(params) { return 'New test result: ' + params.input; }",
                parameters: [

spec/services/discourse_ai/tool_name_checker_spec.rb

@@ -19,17 +19,5 @@
         end
       end
     end
-
-    context "when the tool name is already" do
-      let(:tool_name) { "toolname" }
-
-      before { Fabricate(:ai_tool, tool_name: tool_name) }
-
-      it "returns an error" do
-        expect(DiscourseAi::ToolNameChecker.new(tool_name).check).to eq(
-          { available: false, errors: [I18n.t("errors.messages.taken")] },
-        )
-      end
-    end
   end
 end