lint

Author: SamSaffron

app/controllers/discourse_ai/ai_bot/artifacts_controller.rb

@@ -3,7 +3,6 @@
 module DiscourseAi
   module AiBot
     class ArtifactsController < ApplicationController
-
       requires_plugin DiscourseAi::PLUGIN_NAME
 
       skip_before_action :preload_json, :check_xhr, only: %i[show]

db/migrate/20241104053017_add_ai_artifacts.rb

@@ -5,10 +5,10 @@ def change
       t.integer :user_id, null: false
       t.integer :post_id, null: false
       t.string :name, null: false, limit: 255
-      t.string :html, limit: 65535  # ~64KB limit
-      t.string :css, limit: 65535   # ~64KB limit
-      t.string :js, limit: 65535    # ~64KB limit
-      t.jsonb :metadata             # For any additional properties
+      t.string :html, limit: 65_535 # ~64KB limit
+      t.string :css, limit: 65_535 # ~64KB limit
+      t.string :js, limit: 65_535 # ~64KB limit
+      t.jsonb :metadata # For any additional properties
 
       t.timestamps
     end

lib/ai_bot/personas/persona.rb

@@ -202,7 +202,13 @@ def craft_prompt(context, llm: nil)
 
         def find_tool(partial, bot_user:, llm:, context:, existing_tools: [])
           return nil if !partial.is_a?(DiscourseAi::Completions::ToolCall)
-          tool_instance(partial, bot_user: bot_user, llm: llm, context: context, existing_tools: existing_tools)
+          tool_instance(
+            partial,
+            bot_user: bot_user,
+            llm: llm,
+            context: context,
+            existing_tools: existing_tools,
+          )
         end
 
         def allow_partial_tool_calls?
@@ -245,7 +251,8 @@ def tool_instance(tool_call, bot_user:, llm:, context:, existing_tools:)
             arguments[name.to_sym] = value if value
           end
 
-          tool_instance = existing_tools.find { |t| t.name == function_name && t.tool_call_id == function_id }
+          tool_instance =
+            existing_tools.find { |t| t.name == function_name && t.tool_call_id == function_id }
 
           if tool_instance
             tool_instance.parameters = arguments

lib/ai_bot/playground.rb

@@ -464,10 +464,10 @@ def reply_to(post, custom_instructions: nil, &blk)
             end
 
             if post_streamer
-              post_streamer.run_later {
+              post_streamer.run_later do
                 Discourse.redis.expire(redis_stream_key, 60)
                 publish_update(reply_post, { raw: raw })
-              }
+              end
             end
           end
 

lib/ai_bot/tools/create_artifact.rb

@@ -92,7 +92,8 @@ def update_custom_html(artifact = nil)
           css = parameters[:css].to_s
           js = parameters[:js].to_s
 
-          artifact_div = "<div class=\"ai-artifact\" data-ai-artifact-id=#{artifact.id}></div>" if artifact
+          artifact_div =
+            "<div class=\"ai-artifact\" data-ai-artifact-id=#{artifact.id}></div>" if artifact
 
           content = []
 

lib/completions/endpoints/base.rb

@@ -96,8 +96,10 @@ def perform_completion!(
                 raise CompletionFailed, response.body
               end
 
-              xml_tool_processor = XmlToolProcessor.new(partial_tool_calls: partial_tool_calls) if xml_tools_enabled? &&
-                dialect.prompt.has_tools?
+              xml_tool_processor =
+                XmlToolProcessor.new(
+                  partial_tool_calls: partial_tool_calls,
+                ) if xml_tools_enabled? && dialect.prompt.has_tools?
 
               to_strip = xml_tags_to_strip(dialect)
               xml_stripper =

plugin.rb

@@ -50,7 +50,6 @@ module ::DiscourseAi
 require_relative "lib/engine"
 
 after_initialize do
-
   if defined?(Rack::MiniProfiler)
     Rack::MiniProfiler.config.skip_paths << "/discourse-ai/ai-bot/artifacts"
   end

spec/lib/completions/endpoints/anthropic_spec.rb

@@ -186,7 +186,7 @@
 
     expected_body = {
       model: "claude-3-opus-20240229",
-      max_tokens: 3000,
+      max_tokens: 4096,
       messages: [{ role: "user", content: "user1: hello" }],
       system: "You are hello bot",
       stream: true,
@@ -278,7 +278,7 @@
 
     request_body = {
       model: "claude-3-opus-20240229",
-      max_tokens: 3000,
+      max_tokens: 4096,
       messages: [
         {
           role: "user",
@@ -376,7 +376,7 @@
 
     expected_body = {
       model: "claude-3-opus-20240229",
-      max_tokens: 3000,
+      max_tokens: 4096,
       messages: [{ role: "user", content: "user1: hello" }],
       system: "You are hello bot",
     }

spec/lib/completions/endpoints/open_ai_spec.rb

@@ -572,7 +572,6 @@ def request_body(prompt, stream: false, tool_call: false)
         end
 
         it "properly handles multiple params in partial tool calls" do
-
           # this is not working and it is driving me nuts so I will use a sledghammer
           # text = plugin_file_from_fixtures("openai_artifact_call.txt", "bot")
 
@@ -591,7 +590,10 @@ def request_body(prompt, stream: false, tool_call: false)
 
           expect(partials.compact.length).to eq(128)
 
-          params = partials.map { |p| p.parameters if p.is_a?(DiscourseAi::Completions::ToolCall) && p.partial?  }.compact
+          params =
+            partials
+              .map { |p| p.parameters if p.is_a?(DiscourseAi::Completions::ToolCall) && p.partial? }
+              .compact
 
           lengths = {}
           params.each do |p|

spec/lib/modules/ai_bot/playground_spec.rb

@@ -791,11 +791,12 @@
         expect(done_signal.data[:cooked]).to eq(reply.cooked)
 
         expect(messages.first.data[:raw]).to eq("")
-        messages[1..-1].each_with_index do |m, idx|
-          expect(m.data[:raw]).to eq(expected_bot_response[0..idx])
-        end
 
         expect(reply.cooked).to eq(PrettyText.cook(expected_bot_response))
+
+        messages[1..-1].each do |m|
+          expect(expected_bot_response.start_with?(m.data[:raw])).to eq(true)
+        end
       end
     end