FIX: spec 🙌

Author: keegangeorge

app/services/problem_check/ai_llm_status.rb

@@ -19,7 +19,6 @@ def llm_errors
 
   def try_validate(model, &blk)
     begin
-      # raise({ message: "Forced error for testing" }.to_json) if Rails.env.test?
       blk.call
       nil
     rescue => e

spec/services/problem_check/ai_llm_status_spec.rb

@@ -5,25 +5,28 @@
 RSpec.describe ProblemCheck::AiLlmStatus do
   subject(:check) { described_class.new }
 
-  # let(:spec_model) do
-  #   LlmModel.new(
-  #     id: 50,
-  #     display_name: "GPT-4 Turbo",
-  #     name: "gpt-4-turbo",
-  #     provider: "open_ai",
-  #     tokenizer: "DiscourseAi::Tokenizer::OpenAiTokenizer",
-  #     max_prompt_tokens: 131_072,
-  #     api_key: "invalid",
-  #     url: "https://api.openai.com/v1/chat/completions",
-  #   )
-  # end
-
   fab!(:llm_model)
 
+  let(:post_url) { "https://api.openai.com/v1/chat/completions" }
+  let(:success_response) do
+    {
+      model: "gpt-4-turbo",
+      usage: {
+        max_prompt_tokens: 131_072,
+      },
+      choices: [
+        { message: { role: "assistant", content: "test" }, finish_reason: "stop", index: 0 },
+      ],
+    }.to_json
+  end
+
+  let(:error_response) do
+    { message: "API key error! Please check you have supplied the correct API key." }.to_json
+  end
+
   before do
-    pp "Spec model: #{llm_model.inspect}"
+    stub_request(:post, post_url).to_return(status: 200, body: success_response, headers: {})
     SiteSetting.ai_summarization_model = "custom:#{llm_model.id}"
-    # assign_fake_provider_to(:ai_summarization_model)
     SiteSetting.ai_summarization_enabled = true
   end
 
@@ -34,23 +37,10 @@
     end
 
     context "with discourse-ai plugin enabled for the site" do
-      # let(:llm_model) { LlmModel.in_use.first }
-
       before { SiteSetting.discourse_ai_enabled = true }
 
       it "returns a problem with an LLM model" do
-        stub_request(:post, "https://api.openai.com/v1/chat/completions").with(
-          body:
-            "{\"model\":\"gpt-4-turbo\",\"messages\":[{\"role\":\"system\",\"content\":\"You are a helpful bot\"},{\"role\":\"user\",\"content\":\"How much is 1 + 1?\"}]}",
-          headers: {
-            "Accept" => "*/*",
-            "Accept-Encoding" => "gzip;q=1.0,deflate;q=0.6,identity;q=0.3",
-            "Authorization" => "Bearer 123",
-            "Content-Type" => "application/json",
-            "Host" => "api.openai.com",
-            "User-Agent" => "Ruby",
-          },
-        ).to_return(status: 200, body: "", headers: {})
+        stub_request(:post, post_url).to_return(status: 403, body: error_response, headers: {})
         message =
           "#{I18n.t("dashboard.problem.ai_llm_status", { model_name: llm_model.display_name, model_id: llm_model.id })}"
 
@@ -63,11 +53,16 @@
             details: {
               model_id: llm_model.id,
               model_name: llm_model.display_name,
-              error: "Forced error for testing",
+              error: JSON.parse(error_response)["message"],
             },
           ),
         )
       end
+
+      it "does not return a problem if the LLM models are working" do
+        stub_request(:post, post_url).to_return(status: 200, body: success_response, headers: {})
+        expect(check).to be_chill_about_it
+      end
     end
   end
 end