fix specs

Author: jjaffeux

assets/javascripts/discourse/components/ai-post-helper-menu.gjs

@@ -44,8 +44,7 @@ export default class AiPostHelperMenu extends Component {
   @tracked isSavingFootnote = false;
   @tracked supportsAddFootnote = this.args.data.supportsFastEdit;
   @tracked
-  channel =
-    `/discourse-ai/ai-helper/stream_suggestion/${this.args.data.quoteState.postId}`;
+  channel = `/discourse-ai/ai-helper/stream_suggestion/${this.args.data.quoteState.postId}`;
 
   @tracked
   smoothStreamer = new SmoothStreamer(
@@ -79,7 +78,6 @@ export default class AiPostHelperMenu extends Component {
   });
 
   @tracked _activeAiRequest = null;
-  @tracked _lastMessageIds = {};
 
   get footnoteDisabled() {
     return this.streaming || !this.supportsAddFootnote;
@@ -155,12 +153,9 @@ export default class AiPostHelperMenu extends Component {
   subscribe() {
     this.messageBus.subscribe(
       this.channel,
-      (data, id) => {
-        this._lastMessageIds[this.channel] =
-          this.args.data.post.discourse_ai_helper_stream_suggestion_last_message_bus_id;
-        this._updateResult(data, id);
-      },
-      this._lastMessageIds[this.channel]
+      (data, id) => this._updateResult(data, id),
+      this.args.data.post
+        .discourse_ai_helper_stream_suggestion_last_message_bus_id
     );
   }
 
@@ -171,8 +166,6 @@ export default class AiPostHelperMenu extends Component {
 
   @bind
   async _updateResult(result) {
-    this._lastMessageIds[this.channel] =
-      this.args.data.post.discourse_ai_helper_stream_suggestion_last_message_bus_id;
     this.streaming = !result.done;
     await this.smoothStreamer.updateResult(result, "result");
   }

spec/system/ai_helper/ai_post_helper_spec.rb

@@ -107,8 +107,7 @@ def select_post_text(selected_post)
 
         DiscourseAi::Completions::Llm.with_prepared_responses([explain_response]) do
           post_ai_helper.select_helper_model(mode)
-          wait_for { post_ai_helper.has_suggestion_value? }
-          expect(post_ai_helper.suggestion_value).to eq(explain_response)
+          expect(post_ai_helper).to have_suggestion_value(explain_response)
         end
       end
     end

spec/system/page_objects/components/ai_post_helper_menu.rb

@@ -27,8 +27,8 @@ def select_helper_model(mode)
         find("#{OPTIONS_SELECTOR} .btn[data-name=\"#{mode}\"]").click
       end
 
-      def has_suggestion_value?
-        page.has_css?("#{SUGGESTION_SELECTOR}__text")
+      def has_suggestion_value?(value)
+        page.has_css?("#{SUGGESTION_SELECTOR}__text", text: value)
       end
 
       def suggestion_value