Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Commit 451f766

Browse files
authored
FIX: prevents fields in Object to re-render (#1205)
1 parent 75a1ade commit 451f766

File tree

2 files changed

+14
-4
lines changed

2 files changed

+14
-4
lines changed

assets/javascripts/discourse/components/ai-embedding-editor.gjs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,11 @@ export default class AiEmbeddingEditor extends Component {
288288
});
289289
}
290290

291+
@action
292+
providerKeys(providerParams) {
293+
return Object.keys(providerParams);
294+
}
295+
291296
<template>
292297
{{#if this.showPresets}}
293298
<BackButton
@@ -494,7 +499,7 @@ export default class AiEmbeddingEditor extends Component {
494499
{{! provider-specific content }}
495500
{{#if this.currentProvider}}
496501
<form.Object @name="provider_params" as |object providerData|>
497-
{{#each-in providerData as |name|}}
502+
{{#each (this.providerKeys providerData) as |name|}}
498503
{{#let (get this.providerParams name) as |params|}}
499504
{{#if params}}
500505
<object.Field
@@ -523,7 +528,7 @@ export default class AiEmbeddingEditor extends Component {
523528
</object.Field>
524529
{{/if}}
525530
{{/let}}
526-
{{/each-in}}
531+
{{/each}}
527532
</form.Object>
528533
{{/if}}
529534

assets/javascripts/discourse/components/ai-llm-editor-form.gjs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,11 @@ export default class AiLlmEditorForm extends Component {
250250
});
251251
}
252252

253+
@action
254+
providerParamsKeys(providerParams) {
255+
return Object.keys(providerParams);
256+
}
257+
253258
<template>
254259
<Form
255260
@onSubmit={{this.save}}
@@ -335,7 +340,7 @@ export default class AiLlmEditorForm extends Component {
335340
</form.Field>
336341

337342
<form.Object @name="provider_params" as |object providerParamsData|>
338-
{{#each-in providerParamsData as |name|}}
343+
{{#each (this.providerParamsKeys providerParamsData) as |name|}}
339344
{{#let
340345
(get (this.metaProviderParams data.provider) name)
341346
as |params|
@@ -363,7 +368,7 @@ export default class AiLlmEditorForm extends Component {
363368
{{/if}}
364369
</object.Field>
365370
{{/let}}
366-
{{/each-in}}
371+
{{/each}}
367372
</form.Object>
368373

369374
<form.Field

0 commit comments

Comments
 (0)