Naming and delete support

Author: SamSaffron

ai_artifact_key_value_api_spec.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+RSpec.describe "AI Artifact Key-Value API", type: :system, js: true do
+  fab!(:user)
+  fab!(:private_message_topic) { Fabricate(:private_message_topic, user: user) }
+  fab!(:private_message_post) { Fabricate(:post, topic: private_message_topic, user: user) }
+  fab!(:artifact) do
+    Fabricate(
+      :ai_artifact,
+      post: private_message_post,
+      metadata: {
+        public: true,
+      },
+      html: '<div id="log">Artifact Loaded</div>',
+      js: <<~JS,
+        const logElement = document.getElementById('log');
+
+        window.addEventListener('load', async function() {
+          try {
+            logElement.innerHTML = "TESTING KEY-VALUE API...";
+            const log = [];
+            await window.discourseArtifact.set('test_key', 'test_value');
+            log.push('Set operation completed');
+            logElement.innerHTML = log.join('<br>');
+
+            const value = await window.discourseArtifact.get('test_key');
+            log.push('Got value:' + value);
+
+            await window.discourseArtifact.delete('test_key');
+            log.push('Delete operation completed');
+
+            const deletedValue = await window.discourseArtifact.get('test_key');
+            log.push('Deleted value should be null:' + deletedValue);
+
+            logElement.innerHTML = log.join('<br>');
+            logElement.setAttribute('data-test-complete', 'true');
+          } catch (error) {
+            logElement.innerHTML = error.message;
+            logElement.setAttribute('data-test-error', 'true');
+          }
+        });
+      JS
+    )
+  end
+
+  before do
+    SiteSetting.discourse_ai_enabled = true
+    SiteSetting.ai_bot_enabled = true
+    sign_in(user)
+  end
+
+  it "provides working key-value API in artifact JavaScript" do
+    visit "/discourse-ai/ai-bot/artifacts/#{artifact.id}"
+
+    within_frame(find("iframe")) do
+      expect(page).to have_selector("#log", wait: 10)
+      expect(page).to have_selector("#log[data-test-complete='true']", wait: 15)
+      expect(page).not_to have_selector("#log[data-test-error]")
+    end
+
+    expect(artifact.key_values.find_by(key: "test_key", user: user)).to be_nil
+  end
+end

app/controllers/discourse_ai/ai_bot/artifact_key_values_controller.rb

@@ -4,7 +4,7 @@ module DiscourseAi
   module AiBot
     class ArtifactKeyValuesController < ::ApplicationController
       requires_plugin DiscourseAi::PLUGIN_NAME
-      before_action :ensure_logged_in, only: %i[create]
+      before_action :ensure_logged_in, only: %i[set destroy]
       before_action :find_artifact
 
       PER_PAGE_MAX = 100
@@ -40,9 +40,31 @@ def index
                }
       end
 
-      def create
-        key_value = @artifact.key_values.build(key_value_params)
-        key_value.user = current_user
+      def destroy
+        if params[:key].blank?
+          render json: { error: "Key parameter is required" }, status: :bad_request
+          return
+        end
+
+        key_value = @artifact.key_values.find_by(user_id: current_user.id, key: params[:key])
+
+        if key_value.nil?
+          render json: { error: "Key not found" }, status: :not_found
+        elsif key_value.destroy
+          head :ok
+        else
+          render json: { errors: key_value.errors.full_messages }, status: :unprocessable_entity
+        end
+      end
+
+      def set
+        key_value =
+          @artifact.key_values.find_or_initialize_by(
+            user: current_user,
+            key: key_value_params[:key],
+          )
+
+        key_value.assign_attributes(key_value_params.except(:key))
 
         if key_value.save
           render json: AiArtifactKeyValueSerializer.new(key_value).as_json