DEV: Ween off deprecated plugin nav mode option (#1095)

Drenmi · web-flow · commit 45eabedf4754 · 2025-01-28T12:04:32.000+08:00
We have removed this flag in core. All plugins now use the "top mode" for their navigation. A backwards-compatible change has been made in core while we remove the usage from plugins.
diff --git a/.discourse-compatibility b/.discourse-compatibility
@@ -1,3 +1,4 @@
+< 3.4.0.beta4-dev: a53719ab8eb071459f215227421b3ea4987e5f87
 < 3.4.0.beta4-dev: 20612fde52d3f740cad64823ef8aadb0748b567f
 < 3.4.0.beta3-dev: decf1bb49d737ea15308400f22f89d1d1e71d13d
 < 3.4.0.beta1-dev: 9d887ad4ace8e33c3fe7dbb39237e882c08b4f0b
diff --git a/assets/javascripts/initializers/admin-plugin-configuration-nav.js b/assets/javascripts/initializers/admin-plugin-configuration-nav.js
@@ -1,4 +1,3 @@
-import { PLUGIN_NAV_MODE_TOP } from "discourse/lib/admin-plugin-config-nav";
 import { withPluginApi } from "discourse/lib/plugin-api";
 
 export default {
@@ -11,7 +10,7 @@ export default {
     }
 
     withPluginApi("1.1.0", (api) => {
-      api.addAdminPluginConfigurationNav("discourse-ai", PLUGIN_NAV_MODE_TOP, [
+      api.addAdminPluginConfigurationNav("discourse-ai", [
         {
           label: "discourse_ai.usage.short_title",
           route: "adminPlugins.show.discourse-ai-usage",

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+< 3.4.0.beta4-dev: a53719ab8eb071459f215227421b3ea4987e5f87`
`1`	`2`	`< 3.4.0.beta4-dev: 20612fde52d3f740cad64823ef8aadb0748b567f`
`2`	`3`	`< 3.4.0.beta3-dev: decf1bb49d737ea15308400f22f89d1d1e71d13d`
`3`	`4`	`< 3.4.0.beta1-dev: 9d887ad4ace8e33c3fe7dbb39237e882c08b4f0b`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import { PLUGIN_NAV_MODE_TOP } from "discourse/lib/admin-plugin-config-nav";`
`2`	`1`	`import { withPluginApi } from "discourse/lib/plugin-api";`
`3`	`2`
`4`	`3`	`export default {`
`@@ -11,7 +10,7 @@ export default {`
`11`	`10`	`}`
`12`	`11`
`13`	`12`	`withPluginApi("1.1.0", (api) => {`
`14`		`- api.addAdminPluginConfigurationNav("discourse-ai", PLUGIN_NAV_MODE_TOP, [`
	`13`	`+ api.addAdminPluginConfigurationNav("discourse-ai", [`
`15`	`14`	`{`
`16`	`15`	`label: "discourse_ai.usage.short_title",`
`17`	`16`	`route: "adminPlugins.show.discourse-ai-usage",`