Review feedback

Author: markvanlan

assets/javascripts/discourse/components/ai-bot-sidebar-new-conversation.gjs

@@ -12,32 +12,19 @@ export default class AiBotSidebarNewConversation extends Component {
     return this.sidebarState.isCurrentPanel(AI_CONVERSATIONS_PANEL);
   }
 
-  get disabled() {
-    return this.router.currentRouteName === "discourse-ai-bot-conversations";
-  }
-
-  get label() {
-    return this.disabled
-      ? "discourse_ai.ai_bot.conversations.enter_question"
-      : "discourse_ai.ai_bot.conversations.new";
-  }
-
-  get icon() {
-    return this.disabled ? "keyboard" : "plus";
-  }
-
   @action
   routeTo() {
-    this.router.transitionTo("/discourse-ai/ai-bot/conversations");
+    if (this.router.currentRouteName !== "discourse-ai-bot-conversations") {
+      this.router.transitionTo("/discourse-ai/ai-bot/conversations");
+    }
     this.args.outletArgs?.toggleNavigationMenu?.();
   }
 
   <template>
     {{#if this.shouldRender}}
       <DButton
-        @label={{this.label}}
-        @icon={{this.icon}}
-        @disabled={{this.disabled}}
+        @label="discourse_ai.ai_bot.conversations.new"
+        @icon="plus"
         @action={{this.routeTo}}
         class="ai-new-question-button btn-default"
       />

config/locales/client.en.yml

@@ -726,7 +726,6 @@ en:
           disclaimer: "Generative AI can make mistakes. Verify important information."
           placeholder: "Ask a question..."
           new: "New Question"
-          enter_question: "Enter Question"
           min_input_length_message: "Message must be longer than 10 characters"
           messages_sidebar_title: "Conversations"
           today: "Today"

spec/system/ai_bot/homepage_spec.rb

@@ -208,11 +208,11 @@
       )
     end
 
-    it "displays 'enter question' button on conversations homepage" do
+    it "displays 'new question' button on the topic page" do
       ai_pm_homepage.visit
       expect(sidebar).to have_css(
         "button.ai-new-question-button",
-        text: I18n.t("js.discourse_ai.ai_bot.conversations.enter_question"),
+        text: I18n.t("js.discourse_ai.ai_bot.conversations.new"),
       )
     end