Work in progress - import tool / persona

Author: SamSaffron

app/controllers/discourse_ai/admin/ai_tools_controller.rb

@@ -39,6 +39,38 @@ def export
         render_serialized(@ai_tool, AiCustomToolSerializer)
       end
 
+      def import
+        existing_tool = AiTool.find_by(tool_name: ai_tool_params[:tool_name])
+        force_update = params[:force].present? && params[:force] == "true"
+
+        if existing_tool && !force_update
+          return(
+            render_json_error "Tool with tool_name '#{ai_tool_params[:tool_name]}' already exists. Use force=true to overwrite.",
+                              status: :conflict
+          )
+        end
+
+        if existing_tool && force_update
+          initial_attributes = existing_tool.attributes.dup
+          if existing_tool.update(ai_tool_params)
+            log_ai_tool_update(existing_tool, initial_attributes)
+            render_serialized(existing_tool, AiCustomToolSerializer)
+          else
+            render_json_error existing_tool
+          end
+        else
+          ai_tool = AiTool.new(ai_tool_params)
+          ai_tool.created_by_id = current_user.id
+
+          if ai_tool.save
+            log_ai_tool_creation(ai_tool)
+            render_serialized(ai_tool, AiCustomToolSerializer, status: :created)
+          else
+            render_json_error ai_tool
+          end
+        end
+      end
+
       def update
         initial_attributes = @ai_tool.attributes.dup
 

assets/javascripts/discourse/components/ai-tool-editor-form.gjs

@@ -6,6 +6,7 @@ import { service } from "@ember/service";
 import { and, gt } from "truth-helpers";
 import Form from "discourse/components/form";
 import { popupAjaxError } from "discourse/lib/ajax-error";
+import getURL from "discourse/lib/get-url";
 import { i18n } from "discourse-i18n";
 import AiToolTestModal from "./modal/ai-tool-test-modal";
 import RagOptionsFk from "./rag-options-fk";
@@ -151,6 +152,12 @@ export default class AiToolEditorForm extends Component {
       : i18n("discourse_ai.rag.uploads.description");
   }
 
+  @action
+  exportTool() {
+    const exportUrl = `/admin/plugins/discourse-ai/ai-tools/${this.args.model.id}/export.json`;
+    window.location.href = getURL(exportUrl);
+  }
+
   <template>
     <Form
       @onSubmit={{this.save}}
@@ -386,7 +393,11 @@ export default class AiToolEditorForm extends Component {
             @action={{this.openTestModal}}
             class="ai-tool-editor__test-button"
           />
-
+          <form.Button
+            @label="discourse_ai.tools.export"
+            @action={{this.exportTool}}
+            class="ai-tool-editor__export"
+          />
           <form.Button
             @label="discourse_ai.tools.delete"
             @icon="trash-can"

assets/javascripts/discourse/components/ai-tool-list-editor.gjs

@@ -44,6 +44,11 @@ export default class AiToolListEditor extends Component {
         @descriptionLabel={{i18n "discourse_ai.tools.subheader_description"}}
       >
         <:actions>
+          <DButton
+            @translatedLabel={{i18n "discourse_ai.tools.import"}}
+            @icon="upload"
+            class="btn btn-small ai-tool-list-editor__import-button"
+          />
           <DMenu
             @triggerClass="btn-primary btn-small ai-tool-list-editor__new-button"
             @label={{i18n "discourse_ai.tools.new"}}

config/locales/client.en.yml

@@ -445,6 +445,8 @@ en:
       tools:
         back: "Back"
         short_title: "Tools"
+        export: "Export"
+        import: "Import"
         no_tools: "You have not created any tools yet"
         name: "Name"
         name_help: "Name will show up in the Discourse UI and is the short identifier you will use to find the tool in various settings, it should be distinct (it is required)"

config/routes.rb

@@ -85,11 +85,11 @@
     )
 
     post "/ai-tools/:id/test", to: "discourse_ai/admin/ai_tools#test"
-    get "/ai-tools/:id/export", to: "discourse_ai/admin/ai_tools#export"
+    get "/ai-tools/:id/export", to: "discourse_ai/admin/ai_tools#export", format: :json
     post "/ai-tools/import", to: "discourse_ai/admin/ai_tools#import"
 
     post "/ai-personas/:id/create-user", to: "discourse_ai/admin/ai_personas#create_user"
-    get "/ai-personas/:id/export", to: "discourse_ai/admin/ai_personas#export"
+    get "/ai-personas/:id/export", to: "discourse_ai/admin/ai_personas#export", format: :json
     post "/ai-personas/import", to: "discourse_ai/admin/ai_personas#import"
 
     put "/ai-personas/:id/files/remove", to: "discourse_ai/admin/ai_personas#remove_file"

spec/requests/admin/ai_tools_controller_spec.rb

@@ -46,6 +46,107 @@
     end
   end
 
+  describe "GET #export" do
+    it "returns the ai_tool as JSON attachment" do
+      get "/admin/plugins/discourse-ai/ai-tools/#{ai_tool.id}/export.json"
+
+      expect(response).to be_successful
+      expect(response.headers["Content-Disposition"]).to eq(
+        "attachment; filename=\"#{ai_tool.tool_name}.json\"",
+      )
+      expect(response.parsed_body["ai_tool"]["name"]).to eq(ai_tool.name)
+      expect(response.parsed_body["ai_tool"]["tool_name"]).to eq(ai_tool.tool_name)
+      expect(response.parsed_body["ai_tool"]["description"]).to eq(ai_tool.description)
+      expect(response.parsed_body["ai_tool"]["parameters"]).to eq(ai_tool.parameters)
+    end
+
+    it "returns 404 for non-existent ai_tool" do
+      get "/admin/plugins/discourse-ai/ai-tools/99999/export.json"
+
+      expect(response).to have_http_status(:not_found)
+    end
+  end
+
+  describe "POST #import" do
+    let(:import_attributes) do
+      {
+        name: "Imported Tool",
+        tool_name: "imported_tool",
+        description: "An imported test tool",
+        parameters: [{ name: "query", type: "string", description: "perform a search" }],
+        script: "function invoke(params) { return params; }",
+        summary: "Imported tool summary",
+      }
+    end
+
+    it "imports a new AI tool successfully" do
+      expect {
+        post "/admin/plugins/discourse-ai/ai-tools/import.json",
+             params: { ai_tool: import_attributes }.to_json,
+             headers: {
+               "CONTENT_TYPE" => "application/json",
+             }
+      }.to change(AiTool, :count).by(1)
+
+      expect(response).to have_http_status(:created)
+      expect(response.parsed_body["ai_tool"]["name"]).to eq("Imported Tool")
+      expect(response.parsed_body["ai_tool"]["tool_name"]).to eq("imported_tool")
+    end
+
+    it "returns conflict error when tool with same tool_name exists without force" do
+      _existing_tool =
+        AiTool.create!(
+          name: "Existing Tool",
+          tool_name: "imported_tool",
+          description: "Existing tool",
+          script: "function invoke(params) { return 'existing'; }",
+          summary: "Existing summary",
+          created_by_id: admin.id,
+        )
+
+      expect {
+        post "/admin/plugins/discourse-ai/ai-tools/import.json",
+             params: { ai_tool: import_attributes }.to_json,
+             headers: {
+               "CONTENT_TYPE" => "application/json",
+             }
+      }.not_to change(AiTool, :count)
+
+      expect(response).to have_http_status(:conflict)
+      expect(response.parsed_body["errors"]).to include(
+        "Tool with tool_name 'imported_tool' already exists. Use force=true to overwrite.",
+      )
+    end
+
+    it "force updates existing tool when force=true" do
+      existing_tool =
+        AiTool.create!(
+          name: "Existing Tool",
+          tool_name: "imported_tool",
+          description: "Existing tool",
+          script: "function invoke(params) { return 'existing'; }",
+          summary: "Existing summary",
+          created_by_id: admin.id,
+        )
+
+      expect {
+        post "/admin/plugins/discourse-ai/ai-tools/import.json?force=true",
+             params: { ai_tool: import_attributes }.to_json,
+             headers: {
+               "CONTENT_TYPE" => "application/json",
+             }
+      }.not_to change(AiTool, :count)
+
+      expect(response).to have_http_status(:ok)
+      expect(response.parsed_body["ai_tool"]["name"]).to eq("Imported Tool")
+      expect(response.parsed_body["ai_tool"]["description"]).to eq("An imported test tool")
+
+      existing_tool.reload
+      expect(existing_tool.name).to eq("Imported Tool")
+      expect(existing_tool.description).to eq("An imported test tool")
+    end
+  end
+
   describe "POST #create" do
     let(:valid_attributes) do
       {