FIX: do not add bot user to PM when using responders

Author: SamSaffron

lib/ai_bot/playground.rb

@@ -162,7 +162,7 @@ def self.schedule_reply(post)
         end
       end
 
-      def self.reply_to_post(post:, user: nil, persona_id: nil, whisper: nil)
+      def self.reply_to_post(post:, user: nil, persona_id: nil, whisper: nil, add_user_to_pm: false)
         ai_persona = AiPersona.find_by(id: persona_id)
         raise Discourse::InvalidParameters.new(:persona_id) if !ai_persona
         persona_class = ai_persona.class_instance
@@ -173,7 +173,12 @@ def self.reply_to_post(post:, user: nil, persona_id: nil, whisper: nil)
         bot = DiscourseAi::AiBot::Bot.as(bot_user, persona: persona)
         playground = DiscourseAi::AiBot::Playground.new(bot)
 
-        playground.reply_to(post, whisper: whisper, context_style: :topic)
+        playground.reply_to(
+          post,
+          whisper: whisper,
+          context_style: :topic,
+          add_user_to_pm: add_user_to_pm,
+        )
       end
 
       def initialize(bot)
@@ -433,7 +438,14 @@ def get_context(participants:, conversation_context:, user:, skip_tool_details:
         result
       end
 
-      def reply_to(post, custom_instructions: nil, whisper: nil, context_style: nil, &blk)
+      def reply_to(
+        post,
+        custom_instructions: nil,
+        whisper: nil,
+        context_style: nil,
+        add_user_to_pm: true,
+        &blk
+      )
         # this is a multithreading issue
         # post custom prompt is needed and it may not
         # be properly loaded, ensure it is loaded
@@ -470,7 +482,7 @@ def reply_to(post, custom_instructions: nil, whisper: nil, context_style: nil, &
         stream_reply = post.topic.private_message?
 
         # we need to ensure persona user is allowed to reply to the pm
-        if post.topic.private_message?
+        if post.topic.private_message? && add_user_to_pm
           if !post.topic.topic_allowed_users.exists?(user_id: reply_user.id)
             post.topic.topic_allowed_users.create!(user_id: reply_user.id)
           end
@@ -485,6 +497,7 @@ def reply_to(post, custom_instructions: nil, whisper: nil, context_style: nil, &
               skip_validations: true,
               skip_jobs: true,
               post_type: post_type,
+              skip_guardian: true,
             )
 
           publish_update(reply_post, { raw: reply_post.cooked })
@@ -560,6 +573,7 @@ def reply_to(post, custom_instructions: nil, whisper: nil, context_style: nil, &
               raw: reply,
               skip_validations: true,
               post_type: post_type,
+              skip_guardian: true,
             )
         end
 

spec/lib/discourse_automation/llm_persona_triage_spec.rb

@@ -165,7 +165,7 @@ def add_automation_field(name, value, type: "text")
     expect(context).to include("support")
   end
 
-  it "passes private message metadata in context when responding to PM" do
+  it "interacts correctly with PMs" do
     # Create a private message topic
     pm_topic = Fabricate(:private_message_topic, user: user, title: "Important PM")
 
@@ -190,6 +190,8 @@ def add_automation_field(name, value, type: "text")
     # Capture the prompt sent to the LLM
     prompt = nil
 
+    original_user_ids = pm_topic.topic_allowed_users.pluck(:user_id)
+
     DiscourseAi::Completions::Llm.with_prepared_responses(
       ["I've received your private message"],
     ) do |_, _, _prompts|
@@ -204,5 +206,13 @@ def add_automation_field(name, value, type: "text")
     expect(context).to include("Important PM")
     expect(context).to include(pm_post.raw)
     expect(context).to include(pm_post2.raw)
+
+    reply = pm_topic.posts.order(:post_number).last
+    expect(reply.raw).to eq("I've received your private message")
+
+    topic = reply.topic
+
+    # should not inject persona into allowed users
+    expect(topic.topic_allowed_users.pluck(:user_id).sort).to eq(original_user_ids.sort)
   end
 end