DEV: Review fixes

Author: martin-brennan

app/models/ai_spam_log.rb

@@ -19,6 +19,7 @@ class AiSpamLog < ActiveRecord::Base
 #  payload             :string(20000)    default(""), not null
 #  created_at          :datetime         not null
 #  updated_at          :datetime         not null
+#  error               :string(3000)
 #
 # Indexes
 #

db/migrate/20250211021037_add_error_to_ai_spam_log.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+class AddErrorToAiSpamLog < ActiveRecord::Migration[7.2]
+  def change
+    add_column :ai_spam_logs, :error, :string, limit: 3000
+  end
+end

lib/ai_moderation/spam_scanner.rb

@@ -414,6 +414,11 @@ def self.handle_spam(post, log)
 
           # silencer will not hide tl1 posts, so we do this here
           hide_post(post)
+        else
+          log.update!(
+            error:
+              "unable to flag post as spam, post action failed for post #{post.id} with error: '#{result.errors.full_messages.join(", ")}'",
+          )
         end
       end
 

lib/automation/llm_triage.rb

@@ -97,8 +97,14 @@ def self.handle(
                   queue_for_review: true,
                 ).perform
 
-              if flag_type == :spam_silence && result.success?
-                SpamRule::AutoSilence.new(post.user, post).silence_user
+              if flag_type == :spam_silence
+                if result.success?
+                  SpamRule::AutoSilence.new(post.user, post).silence_user
+                else
+                  Rails.logger.warn(
+                    "llm_triage: unable to flag post as spam, post action failed for #{post.id} with error: '#{result.errors.full_messages.join(",")}'",
+                  )
+                end
               end
             else
               reviewable =

spec/lib/modules/ai_moderation/spam_scanner_spec.rb

@@ -308,6 +308,7 @@
       log = AiSpamLog.find_by(post: post)
 
       expect(log.reviewable).to be_nil
+      expect(log.error).to match(/unable to flag post as spam/)
       expect(post.user.reload).not_to be_silenced
       expect(post.topic.reload).to be_visible
     end

spec/lib/modules/automation/llm_triage_spec.rb

@@ -147,7 +147,7 @@ def triage(**args)
       )
     end
 
-    expect(post.user).not_to be_silenced
+    expect(post.user.reload).not_to be_silenced
   end
 
   it "can handle garbled output from LLM" do