tests

Author: xfalcox

app/jobs/regular/generate_inferred_concepts.rb

@@ -59,9 +59,9 @@ def process_item(item, item_type, match_only)
         end
       else
         if item_type == "topics"
-          DiscourseAi::InferredConcepts::Manager.analyze_topic(item)
+          DiscourseAi::InferredConcepts::Manager.generate_concepts_from_topic(item)
         else # posts
-          DiscourseAi::InferredConcepts::Manager.analyze_post(item)
+          DiscourseAi::InferredConcepts::Manager.generate_concepts_from_post(item)
         end
       end
     end

app/models/inferred_concept.rb

@@ -1,8 +1,11 @@
 # frozen_string_literal: true
 
 class InferredConcept < ActiveRecord::Base
-  has_and_belongs_to_many :topics
-  has_and_belongs_to_many :posts
+  has_many :inferred_concept_topics
+  has_many :topics, through: :inferred_concept_topics
+
+  has_many :inferred_concept_posts
+  has_many :posts, through: :inferred_concept_posts
 
   validates :name, presence: true, uniqueness: true
 end
@@ -19,4 +22,4 @@ class InferredConcept < ActiveRecord::Base
 # Indexes
 #
 #  index_inferred_concepts_on_name  (name) UNIQUE
-#
+#

app/models/inferred_concept_post.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+class InferredConceptPost < ActiveRecord::Base
+  self.table_name = "inferred_concepts_posts"
+
+  belongs_to :inferred_concept
+  belongs_to :post
+
+  validates :inferred_concept_id, presence: true
+  validates :post_id, presence: true
+  validates :inferred_concept_id, uniqueness: { scope: :post_id }
+end
+
+# == Schema Information
+#
+# Table name: inferred_concepts_posts
+#
+#  inferred_concept_id :bigint           not null
+#  post_id             :bigint           not null
+#  created_at          :datetime         not null
+#  updated_at          :datetime         not null
+#
+# Indexes
+#
+#  index_inferred_concepts_posts_uniqueness  (post_id,inferred_concept_id) UNIQUE
+#  index_inferred_concepts_posts_on_inferred_concept_id  (inferred_concept_id)
+#

app/models/inferred_concept_topic.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+class InferredConceptTopic < ActiveRecord::Base
+  self.table_name = "inferred_concepts_topics"
+
+  belongs_to :inferred_concept
+  belongs_to :topic
+
+  validates :inferred_concept_id, presence: true
+  validates :topic_id, presence: true
+  validates :inferred_concept_id, uniqueness: { scope: :topic_id }
+end
+
+# == Schema Information
+#
+# Table name: inferred_concepts_topics
+#
+#  inferred_concept_id :bigint           not null
+#  topic_id            :bigint           not null
+#  created_at          :datetime         not null
+#  updated_at          :datetime         not null
+#
+# Indexes
+#
+#  index_inferred_concepts_topics_uniqueness  (topic_id,inferred_concept_id) UNIQUE
+#  index_inferred_concepts_topics_on_inferred_concept_id  (inferred_concept_id)
+#

app/serializers/ai_inferred_concept_post_serializer.rb

@@ -12,23 +12,23 @@ class AiInferredConceptPostSerializer < ApplicationSerializer
              :excerpt,
              :truncated,
              :inferred_concepts
-             
+
   def avatar_template
     User.avatar_template(object.username, object.uploaded_avatar_id)
   end
-  
+
   def excerpt
     Post.excerpt(object.cooked)
   end
-  
+
   def truncated
     object.cooked.length > SiteSetting.post_excerpt_maxlength
   end
-  
+
   def inferred_concepts
     ActiveModel::ArraySerializer.new(
       object.inferred_concepts,
-      each_serializer: InferredConceptSerializer
+      each_serializer: InferredConceptSerializer,
     )
   end
-end
+end

app/serializers/inferred_concept_serializer.rb

@@ -2,4 +2,4 @@
 
 class InferredConceptSerializer < ApplicationSerializer
   attributes :id, :name, :created_at, :updated_at
-end
+end

db/fixtures/personas/603_ai_personas.rb

@@ -72,9 +72,13 @@ def from_setting(setting_name)
 
   persona.tools = tools.map { |name, value| [name, value] }
 
-  persona.response_format = instance.response_format
+  # Only set response_format if it's not defined as a method in the persona class
+  if !instance.class.instance_methods.include?(:response_format)
+    persona.response_format = instance.response_format
+  end
 
-  persona.examples = instance.examples
+  # Only set examples if it's not defined as a method in the persona class
+  persona.examples = instance.examples if !instance.class.instance_methods.include?(:examples)
 
   persona.system_prompt = instance.system_prompt
   persona.top_p = instance.top_p

db/migrate/20250508182047_create_inferred_concepts_table.rb

@@ -5,7 +5,7 @@ def change
       t.string :name, null: false
       t.timestamps
     end
-    
+
     add_index :inferred_concepts, :name, unique: true
   end
 end

lib/inferred_concepts/finder.rb

@@ -15,7 +15,7 @@ def self.identify_concepts(content)
             .find { |p| p.id == SiteSetting.inferred_concepts_generate_persona.to_i }
             .new
 
-        llm = LlmModel.find(persona.class.default_llm_id)
+        llm = LlmModel.find(persona.default_llm_id)
         context =
           DiscourseAi::Personas::BotContext.new(
             messages: [{ type: :user, content: content }],
@@ -79,7 +79,7 @@ def self.find_candidate_topics(
         # Exclude topics that already have concepts
         topics_with_concepts = <<~SQL
           SELECT DISTINCT topic_id
-          FROM topics_inferred_concepts
+          FROM inferred_concepts_topics
         SQL
 
         query = query.where("topics.id NOT IN (#{topics_with_concepts})")
@@ -129,7 +129,7 @@ def self.find_candidate_posts(
         # Exclude posts that already have concepts
         posts_with_concepts = <<~SQL
           SELECT DISTINCT post_id
-          FROM posts_inferred_concepts
+          FROM inferred_concepts_posts
         SQL
 
         query = query.where("posts.id NOT IN (#{posts_with_concepts})")
@@ -154,7 +154,7 @@ def self.deduplicate_concepts(concept_names)
             .find { |p| p.id == SiteSetting.inferred_concepts_deduplicate_persona.to_i }
             .new
 
-        llm = LlmModel.find(persona.class.default_llm_id)
+        llm = LlmModel.find(persona.default_llm_id)
 
         # Create the input for the deduplicator
         input = { type: :user, content: concept_names.join(", ") }

lib/post_extensions.rb

@@ -12,7 +12,8 @@ module PostExtensions
                class_name: "ClassificationResult",
                as: :target
 
-      has_and_belongs_to_many :inferred_concepts
+      has_many :inferred_concept_posts
+      has_many :inferred_concepts, through: :inferred_concept_posts
     end
   end
 end