Refactor to DRY the logic identifying posts from an AI bot

Author: megothss

assets/javascripts/discourse/components/post-menu/ai-debug-button.gjs

@@ -2,24 +2,12 @@ import Component from "@glimmer/component";
 import { action } from "@ember/object";
 import { inject as service } from "@ember/service";
 import DButton from "discourse/components/d-button";
+import { isPostFromAiBot } from "../../lib/ai-bot-helper";
 import DebugAiModal from "../modal/debug-ai-modal";
 
-const MAX_PERSONA_USER_ID = -1200;
-
 export default class AiDebugButton extends Component {
   static shouldRender(args) {
-    if (
-      !args.state.currentUser.ai_enabled_chat_bots.any(
-        (bot) => args.post.username === bot.username
-      )
-    ) {
-      // special handling for personas (persona bot users start at ID -1200 and go down)
-      if (args.post.user_id > MAX_PERSONA_USER_ID) {
-        return false;
-      }
-    }
-
-    return true;
+    return isPostFromAiBot(args.post, args.state.currentUser);
   }
 
   // TODO (glimmer-post-menu): Remove this static function and move the code into the button action after the widget code is removed

assets/javascripts/discourse/components/post-menu/ai-share-button.gjs

@@ -2,26 +2,15 @@ import Component from "@glimmer/component";
 import { action } from "@ember/object";
 import { inject as service } from "@ember/service";
 import DButton from "discourse/components/d-button";
+import { isPostFromAiBot } from "../../lib/ai-bot-helper";
 import copyConversation from "../../lib/copy-conversation";
 import ShareModal from "../modal/share-modal";
 
 const AUTO_COPY_THRESHOLD = 4;
-const MAX_PERSONA_USER_ID = -1200;
 
 export default class AiDebugButton extends Component {
   static shouldRender(args) {
-    if (
-      !args.state.currentUser.ai_enabled_chat_bots.any(
-        (bot) => args.post.username === bot.username
-      )
-    ) {
-      // special handling for personas (persona bot users start at ID -1200 and go down)
-      if (args.post.user_id > MAX_PERSONA_USER_ID) {
-        return false;
-      }
-    }
-
-    return true;
+    return isPostFromAiBot(args.post, args.state.currentUser);
   }
 
   // TODO (glimmer-post-menu): Remove this static function and move the code into the button action after the widget code is removed

assets/javascripts/discourse/lib/ai-bot-helper.js

@@ -4,6 +4,17 @@ import Composer from "discourse/models/composer";
 import I18n from "I18n";
 import ShareFullTopicModal from "../components/modal/share-full-topic-modal";
 
+const MAX_PERSONA_USER_ID = -1200;
+
+export function isPostFromAiBot(post, currentUser) {
+  return (
+    post.user_id <= MAX_PERSONA_USER_ID ||
+    !!currentUser?.ai_enabled_chat_bots?.any(
+      (bot) => post.username === bot.username
+    )
+  );
+}
+
 export function showShareConversationModal(modal, topicId) {
   ajax(`/discourse-ai/ai-bot/shared-ai-conversations/preview/${topicId}.json`)
     .then((payload) => {

assets/javascripts/initializers/ai-bot-replies.js

@@ -12,7 +12,10 @@ import AiBotHeaderIcon from "../discourse/components/ai-bot-header-icon";
 import AiCancelStreamingButton from "../discourse/components/post-menu/ai-cancel-streaming-button";
 import AiDebugButton from "../discourse/components/post-menu/ai-debug-button";
 import AiShareButton from "../discourse/components/post-menu/ai-share-button";
-import { showShareConversationModal } from "../discourse/lib/ai-bot-helper";
+import {
+  isPostFromAiBot,
+  showShareConversationModal,
+} from "../discourse/lib/ai-bot-helper";
 import { streamPostText } from "../discourse/lib/ai-streamer/progress-handlers";
 
 let enabledChatBotIds = [];
@@ -85,20 +88,20 @@ function initializePersonaDecorator(api) {
   );
 }
 
-const MAX_PERSONA_USER_ID = -1200;
+const POST_MENU_BUTTONS_POSITION_BEFORE = [
+  POST_MENU_LIKE_BUTTON_KEY,
+  POST_MENU_COPY_LINK_BUTTON_KEY,
+  POST_MENU_SHARE_BUTTON_KEY,
+  POST_MENU_SHOW_MORE_BUTTON_KEY,
+];
 
 function initializePauseButton(api) {
   const transformerRegistered = api.registerValueTransformer(
     "post-menu-buttons",
     ({ value: dag, context: { post } }) => {
       if (isGPTBot(post.user)) {
         dag.add("ai-cancel-gpt", AiCancelStreamingButton, {
-          before: [
-            POST_MENU_LIKE_BUTTON_KEY,
-            POST_MENU_COPY_LINK_BUTTON_KEY,
-            POST_MENU_SHARE_BUTTON_KEY,
-            POST_MENU_SHOW_MORE_BUTTON_KEY,
-          ],
+          before: POST_MENU_BUTTONS_POSITION_BEFORE,
           after: ["ai-share", "ai-debug"],
         });
       }
@@ -142,12 +145,7 @@ function initializeDebugButton(api) {
     ({ value: dag, context: { post } }) => {
       if (post.topic?.archetype === "private_message") {
         dag.add("ai-debug", AiDebugButton, {
-          before: [
-            POST_MENU_LIKE_BUTTON_KEY,
-            POST_MENU_COPY_LINK_BUTTON_KEY,
-            POST_MENU_SHARE_BUTTON_KEY,
-            POST_MENU_SHOW_MORE_BUTTON_KEY,
-          ],
+          before: POST_MENU_BUTTONS_POSITION_BEFORE,
           after: "ai-share",
         });
       }
@@ -175,15 +173,8 @@ function initializeDebugWidgetButton(api) {
       return;
     }
 
-    if (
-      !currentUser.ai_enabled_chat_bots.any(
-        (bot) => post.username === bot.username
-      )
-    ) {
-      // special handling for personas (persona bot users start at ID -1200 and go down)
-      if (post.user_id > MAX_PERSONA_USER_ID) {
-        return;
-      }
+    if (!isPostFromAiBot(post, currentUser)) {
+      return;
     }
 
     return {
@@ -207,12 +198,7 @@ function initializeShareButton(api) {
     ({ value: dag, context: { post } }) => {
       if (post.topic?.archetype === "private_message") {
         dag.add("ai-share", AiShareButton, {
-          before: [
-            POST_MENU_LIKE_BUTTON_KEY,
-            POST_MENU_COPY_LINK_BUTTON_KEY,
-            POST_MENU_SHARE_BUTTON_KEY,
-            POST_MENU_SHOW_MORE_BUTTON_KEY,
-          ],
+          before: POST_MENU_BUTTONS_POSITION_BEFORE,
         });
       }
 
@@ -240,15 +226,8 @@ function initializeShareWidgetButton(api) {
       return;
     }
 
-    if (
-      !currentUser.ai_enabled_chat_bots.any(
-        (bot) => post.username === bot.username
-      )
-    ) {
-      // special handling for personas (persona bot users start at ID -1200 and go down)
-      if (post.user_id > MAX_PERSONA_USER_ID) {
-        return;
-      }
+    if (!isPostFromAiBot(post, currentUser)) {
+      return;
     }
 
     return {