DEV: Improve error handling and add spec

Author: keegangeorge

app/controllers/discourse_ai/admin/ai_spam_controller.rb

@@ -87,11 +87,28 @@ def test
       end
 
       def fix_errors
-        if params[:error] == "spam_scanner_not_admin"
-          DiscourseAi::AiModeration::SpamScanner.fix_spam_scanner_not_admin
+        case params[:error]
+        when "spam_scanner_not_admin"
+          begin
+            DiscourseAi::AiModeration::SpamScanner.fix_spam_scanner_not_admin
+            render json: success_json
+          rescue ActiveRecord::RecordInvalid
+            render_json_error(
+              I18n.t("discourse_ai.spam_detection.bot_user_update_failed"),
+              status: :unprocessable_entity,
+            )
+          rescue StandardError
+            render_json_error(
+              I18n.t("discourse_ai.spam_detection.unexpected"),
+              status: :internal_server_error,
+            )
+          end
+        else
+          render_json_error(
+            I18n.t("discourse_ai.spam_detection.invalid_error_type"),
+            status: :bad_request,
+          )
         end
-
-        render json: success_json
       end
 
       private

config/locales/server.en.yml

@@ -255,6 +255,10 @@ en:
     spam_detection:
       flag_reason: "Flagged as spam by <a href='%{url}'>Discourse AI</a>"
       silence_reason: "User silenced automatically by <a href='%{url}'>Discourse AI</a>"
+      invalid_error_type: "Invalid error type provided"
+      unexpected: "An unexpected error occured"
+      bot_user_update_failed: "Failed to update the spam scanning bot user"
+
     ai_bot:
       reply_error: "Sorry, it looks like our system encountered an unexpected issue while trying to reply.\n\n[details='Error details']\n%{details}\n[/details]"
       default_pm_prefix: "[Untitled AI bot PM]"

lib/ai_moderation/spam_scanner.rb

@@ -243,7 +243,12 @@ def self.perform_scan(post)
 
       def self.fix_spam_scanner_not_admin
         user = DiscourseAi::AiModeration::SpamScanner.flagging_user
-        user.update!(admin: true) if user.present?
+
+        if user.present?
+          user.update!(admin: true)
+        else
+          raise Discourse::NotFound
+        end
       end
 
       private

spec/requests/admin/ai_spam_controller_spec.rb

@@ -306,4 +306,49 @@
       end
     end
   end
+
+  describe "#fix_errors" do
+    fab!(:setting) do
+      AiModerationSetting.create(
+        {
+          setting_type: :spam,
+          llm_model_id: llm_model.id,
+          data: {
+            custom_instructions: "custom instructions",
+          },
+        },
+      )
+      fab!(:llm_model)
+
+      before do
+        sign_in(admin)
+        DiscourseAi::AiModeration::SpamScanner.flagging_user.update!(admin: false)
+      end
+
+      it "resolves spam scanner not admin error" do
+        post "/admin/plugins/discourse-ai/ai-spam/fix-errors",
+             params: {
+               error: "spam_scanner_not_admin",
+             }
+
+        expect(response.status).to eq(200)
+        expect(DiscourseAi::AiModeration::SpamScanner.flagging_user.reload.admin).to eq(true)
+      end
+
+      it "returns an error when it can't update the user" do
+        DiscourseAi::AiModeration::SpamScanner.flagging_user.destroy
+
+        post "/admin/plugins/discourse-ai/ai-spam/fix-errors",
+             params: {
+               error: "spam_scanner_not_admin",
+             }
+
+        expect(response.status).to eq(422)
+        expect(response.parsed_body["errors"]).to be_present
+        expect(response.parsed_body["errors"].first).to eq(
+          I18n.t("discourse_ai.spam_detection.bot_user_update_failed"),
+        )
+      end
+    end
+  end
 end