Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Commit 60fe924

Browse files
authored
DEV: Remove no longer needed click outside logic (#1223)
The older design approach for sentiment analysis report needed the click outside logic. However, when the design was changed this logic was accidentally left behind. It is potentially causing some negative performance impacts. This PR removes the old unnecessary logic.
1 parent bab6f0b commit 60fe924

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

assets/javascripts/discourse/components/admin-report-sentiment-analysis.gjs

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Component from "@glimmer/component";
22
import { tracked } from "@glimmer/tracking";
3-
import { fn, hash } from "@ember/helper";
3+
import { fn } from "@ember/helper";
44
import { on } from "@ember/modifier";
55
import { action } from "@ember/object";
66
import didInsert from "@ember/render-modifiers/modifiers/did-insert";
@@ -21,7 +21,6 @@ import discourseLater from "discourse/lib/later";
2121
import { clipboardCopy } from "discourse/lib/utilities";
2222
import Category from "discourse/models/category";
2323
import Post from "discourse/models/post";
24-
import closeOnClickOutside from "discourse/modifiers/close-on-click-outside";
2524
import { i18n } from "discourse-i18n";
2625
import DTooltip from "float-kit/components/d-tooltip";
2726
import DoughnutChart from "discourse/plugins/discourse-ai/discourse/components/doughnut-chart";
@@ -343,13 +342,6 @@ export default class AdminReportSentimentAnalysis extends Component {
343342
class="sentiment-analysis-table__row"
344343
role="button"
345344
{{on "click" (fn this.showDetails data)}}
346-
{{closeOnClickOutside
347-
(fn (mut this.selectedChart) null)
348-
(hash
349-
targetSelector=".admin-report-sentiment-analysis-details"
350-
secondaryTargetSelector=".admin-report-sentiment-analysis"
351-
)
352-
}}
353345
>
354346
<td class="sentiment-analysis-table__title">
355347
{{#if data.category}}

0 commit comments

Comments
 (0)