Replace setting with a configurable batch size

Author: romanrizzi

app/jobs/regular/hot_topics_gist_batch.rb

@@ -5,12 +5,12 @@ class HotTopicsGistBatch < ::Jobs::Base
     def execute(args)
       return if !SiteSetting.discourse_ai_enabled
       return if !SiteSetting.ai_summarization_enabled
-      return if !SiteSetting.ai_summarize_hot_topics_list
+      return if SiteSetting.ai_summarize_max_hot_topics_gists_per_batch.zero?
 
       Topic
         .joins("JOIN topic_hot_scores on topics.id = topic_hot_scores.topic_id")
         .order("topic_hot_scores.score DESC")
-        .limit(100)
+        .limit(SiteSetting.ai_summarize_max_hot_topics_gists_per_batch)
         .each do |topic|
           summarizer = DiscourseAi::Summarization.topic_gist(topic)
           gist = summarizer.existing_summary

assets/javascripts/discourse/connectors/topic-list-main-link-bottom/ai-topic-gist.gjs

@@ -1,8 +1,7 @@
 import Component from "@glimmer/component";
-import icon from "discourse-common/helpers/d-icon";
 
 export default class AiTopicGist extends Component {
-  static shouldRender(outletArgs, helper) {
+  static shouldRender(outletArgs) {
     return outletArgs?.topic?.ai_topic_gist && !outletArgs.topic.excerpt;
   }
 

assets/stylesheets/modules/summarization/common/ai-summary.scss

@@ -217,9 +217,9 @@
 }
 
 .ai-topic-gist {
-  margin-top: .5em;
+  margin-top: 0.5em;
 
   &__text {
     font-size: var(--font-down-2);
   }
-}
+}

config/locales/server.en.yml

@@ -84,7 +84,7 @@ en:
     ai_summarization_model: "Model to use for summarization."
     ai_custom_summarization_allowed_groups: "Groups allowed to use create new summaries."
     ai_pm_summarization_allowed_groups: "Groups allowed to create and view summaries in PMs."
-    ai_summarize_hot_topics_list: "Display a brief summary for each topic in the hot topics list (if available)."
+    ai_summarize_max_hot_topics_gists_per_batch: "After updating topics in the hot list, we'll generate brief summaries of the first N ones. (Disabled when 0)"
 
     ai_bot_enabled: "Enable the AI Bot module."
     ai_bot_enable_chat_warning: "Display a warning when PM chat is initiated. Can be overriden by editing the translation string: discourse_ai.ai_bot.pm_warning"

config/settings.yml

@@ -376,9 +376,10 @@ discourse_ai:
     type: group_list
     list_type: compact
     default: "3|13" # 3: @staff, 13: @trust_level_3
-  ai_summarize_hot_topics_list:
-    client: true
-    default: false
+  ai_summarize_max_hot_topics_gists_per_batch:
+    default: 0
+    min: 0
+    max: 1000
   ai_summarization_strategy: # TODO(roman): Deprecated. Remove by Sept 2024
     type: enum
     default: ""

lib/summarization/entry_point.rb

@@ -19,7 +19,7 @@ def inject_into(plugin)
 
         plugin.register_modifier(:topic_query_create_list_topics) do |topics, options|
           if options[:filter] == :hot && SiteSetting.ai_summarization_enabled &&
-               SiteSetting.ai_summarize_hot_topics_list
+               SiteSetting.ai_summarize_max_hot_topics_gists_per_batch > 0
             topics.includes(:ai_summaries).where(
               "ai_summaries.id IS NULL OR ai_summaries.summary_type = ?",
               AiSummary.summary_types[:gist],
@@ -33,7 +33,8 @@ def inject_into(plugin)
           :topic_list_item,
           :ai_topic_gist,
           include_condition: -> do
-            SiteSetting.ai_summarization_enabled && SiteSetting.ai_summarize_hot_topics_list
+            SiteSetting.ai_summarization_enabled &&
+              SiteSetting.ai_summarize_max_hot_topics_gists_per_batch > 0
           end,
         ) { object.ai_summaries.to_a.first&.summarized_text }
 

spec/jobs/regular/hot_topics_gist_batch.rb renamed to spec/jobs/regular/hot_topics_gist_batch_spec.rb

@@ -8,11 +8,11 @@
   before do
     assign_fake_provider_to(:ai_summarization_model)
     SiteSetting.ai_summarization_enabled = true
-    SiteSetting.ai_summarize_hot_topics_list = true
+    SiteSetting.ai_summarize_max_hot_topics_gists_per_batch = 100
   end
 
   describe "#execute" do
-    context "When there is a topic with a hot score" do
+    context "when there is a topic with a hot score" do
       before { TopicHotScore.create!(topic_id: topic_1.id, score: 0.1) }
 
       it "does nothing if the plugin is disabled" do
@@ -34,7 +34,7 @@
       end
 
       it "does nothing if hot topics summarization is disabled" do
-        SiteSetting.ai_summarize_hot_topics_list = false
+        SiteSetting.ai_summarize_max_hot_topics_gists_per_batch = 0
 
         subject.execute({})
 
@@ -48,10 +48,10 @@
         DiscourseAi::Completions::Llm.with_prepared_responses([gist_result]) { subject.execute({}) }
 
         gist = AiSummary.gist.find_by(target: topic_1)
-        expect(gist.summarized_text).to eq("I'm a gist")
+        expect(gist.summarized_text).to eq(gist_result)
       end
 
-      context "and we already generated a gist of it" do
+      context "when we already generated a gist of it" do
         fab!(:ai_gist) do
           Fabricate(
             :topic_ai_gist,

spec/lib/modules/summarization/entry_point_spec.rb

@@ -19,7 +19,7 @@
 
       describe "topic_query_create_list_topics modifier" do
         context "when hot topic summarization is enabled" do
-          before { SiteSetting.ai_summarize_hot_topics_list = true }
+          before { SiteSetting.ai_summarize_max_hot_topics_gists_per_batch = 100 }
 
           it "preloads only gist summaries" do
             gist_topic = topic_query.list_hot.topics.find { |t| t.id == topic_ai_gist.target_id }
@@ -49,7 +49,7 @@
         end
 
         context "when hot topics summarization is enabled" do
-          before { SiteSetting.ai_summarize_hot_topics_list = true }
+          before { SiteSetting.ai_summarize_max_hot_topics_gists_per_batch = 100 }
 
           it "includes the summary" do
             gist_topic = topic_query.list_hot.topics.find { |t| t.id == topic_ai_gist.target_id }