REFACTOR: Move personas into it's own module.

Author: romanrizzi

lib/ai_bot/playground.rb

@@ -283,6 +283,44 @@ def title_playground(post, user)
           title: new_title.sub(/\A"/, "").sub(/"\Z/, ""),
         )
 
+        system_insts = <<~TEXT.strip
+          You are titlebot. Given a conversation, you will suggest a title.
+  
+          - You will never respond with anything but the suggested title.
+          - You will always match the conversation language in your title suggestion.
+          - Title will capture the essence of the conversation.
+          TEXT
+
+        instruction = <<~TEXT.strip
+          Given the following conversation:
+  
+          {{{
+          #{conversation}
+          }}}
+  
+          Reply only with a title that is 7 words or less.
+          TEXT
+
+        title_prompt =
+          DiscourseAi::Completions::Prompt.new(
+            system_insts,
+            messages: [type: :user, content: instruction],
+            topic_id: post.topic_id,
+          )
+
+        title =
+          bot
+            .llm
+            .generate(title_prompt, user: user, feature_name: "bot_title")
+            .strip
+            .split("\n")
+            .last
+
+        PostRevisor.new(post.topic.first_post, post.topic).revise!(
+          bot.bot_user,
+          title: title.sub(/\A"/, "").sub(/"\Z/, ""),
+        )
+
         allowed_users = post.topic.topic_allowed_users.pluck(:user_id)
         MessageBus.publish(
           "/discourse-ai/ai-bot/topic/#{post.topic.id}",

lib/personas/bot.rb

@@ -55,8 +55,8 @@ def reply(context, &update_blk)
         unless context.is_a?(BotContext)
           raise ArgumentError, "context must be an instance of BotContext"
         end
-        llm = DiscourseAi::Completions::Llm.proxy(model)
-        prompt = persona.craft_prompt(context, llm: llm)
+        current_llm = llm
+        prompt = persona.craft_prompt(context, llm: current_llm)
 
         total_completions = 0
         ongoing_chain = true
@@ -82,7 +82,7 @@ def reply(context, &update_blk)
           current_thinking = []
 
           result =
-            llm.generate(
+            current_llm.generate(
               prompt,
               feature_name: "bot",
               partial_tool_calls: allow_partial_tool_calls,
@@ -93,7 +93,7 @@ def reply(context, &update_blk)
                 persona.find_tool(
                   partial,
                   bot_user: user,
-                  llm: llm,
+                  llm: current_llm,
                   context: context,
                   existing_tools: existing_tools,
                 )
@@ -120,7 +120,7 @@ def reply(context, &update_blk)
                 process_tool(
                   tool: tool,
                   raw_context: raw_context,
-                  llm: llm,
+                  current_llm: current_llm,
                   cancel: cancel,
                   update_blk: update_blk,
                   prompt: prompt,
@@ -204,15 +204,15 @@ def embed_thinking(raw_context)
       def process_tool(
         tool:,
         raw_context:,
-        llm:,
+        current_llm:,
         cancel:,
         update_blk:,
         prompt:,
         context:,
         current_thinking:
       )
         tool_call_id = tool.tool_call_id
-        invocation_result_json = invoke_tool(tool, llm, cancel, context, &update_blk).to_json
+        invocation_result_json = invoke_tool(tool, cancel, context, &update_blk).to_json
 
         tool_call_message = {
           type: :tool_call,
@@ -246,8 +246,13 @@ def process_tool(
         raw_context << [invocation_result_json, tool_call_id, "tool", tool.name]
       end
 
+<<<<<<< HEAD
       def invoke_tool(tool, llm, cancel, context, &update_blk)
         show_placeholder = !context.skip_tool_details && !tool.class.allow_partial_tool_calls?
+=======
+      def invoke_tool(tool, cancel, context, &update_blk)
+        show_placeholder = !context[:skip_tool_details] && !tool.class.allow_partial_tool_calls?
+>>>>>>> 5bfe2314 (REFACTOR: Move personas into it's own module.)
 
         update_blk.call("", cancel, build_placeholder(tool.summary, "")) if show_placeholder
 

spec/lib/personas/bot_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe DiscourseAi::Personas::Bot do
-  subject(:bot) { described_class.as(bot_user) }
+  subject(:bot) { described_class.as(bot_user, persona: DiscourseAi::Personas::General.new) }
 
   fab!(:admin)
   fab!(:gpt_4) { Fabricate(:llm_model, name: "gpt-4") }