FEATURE: Use different personas to power AI helper features.

You can now edit each AI helper prompt individually through personas, limit access to specific groups, set different LLMs, etc.

Author: romanrizzi

app/controllers/discourse_ai/ai_helper/assistant_controller.rb

@@ -25,25 +25,24 @@ def suggest
         input = get_text_param!
         force_default_locale = params[:force_default_locale] || false
 
-        prompt = CompletionPrompt.find_by(id: params[:mode])
+        raise Discourse::InvalidParameters.new(:mode) if params[:mode].blank?
 
-        raise Discourse::InvalidParameters.new(:mode) if !prompt || !prompt.enabled?
-
-        if prompt.id == CompletionPrompt::CUSTOM_PROMPT
+        if params[:mode] == DiscourseAi::AiHelper::Assistant::CUSTOM_PROMPT
           raise Discourse::InvalidParameters.new(:custom_prompt) if params[:custom_prompt].blank?
-
-          prompt.custom_instruction = params[:custom_prompt]
         end
 
-        return suggest_thumbnails(input) if prompt.id == CompletionPrompt::ILLUSTRATE_POST
+        if params[:mode] == DiscourseAi::AiHelper::Assistant::ILLUSTRATE_POST
+          return suggest_thumbnails(input)
+        end
 
         hijack do
           render json:
                    DiscourseAi::AiHelper::Assistant.new.generate_and_send_prompt(
-                     prompt,
+                     params[:mode],
                      input,
                      current_user,
                      force_default_locale: force_default_locale,
+                     custom_prompt: params[:custom_prompt],
                    ),
                  status: 200
         end
@@ -60,13 +59,10 @@ def suggest_title
           input = get_text_param!
         end
 
-        prompt = CompletionPrompt.enabled_by_name("generate_titles")
-        raise Discourse::InvalidParameters.new(:mode) if !prompt
-
         hijack do
           render json:
                    DiscourseAi::AiHelper::Assistant.new.generate_and_send_prompt(
-                     prompt,
+                     DiscourseAi::AiHelper::Assistant::GENERATE_TITLES,
                      input,
                      current_user,
                    ),
@@ -115,12 +111,12 @@ def stream_suggestion
         location = params[:location]
         raise Discourse::InvalidParameters.new(:location) if !location
 
-        prompt = CompletionPrompt.find_by(id: params[:mode])
-
-        raise Discourse::InvalidParameters.new(:mode) if !prompt || !prompt.enabled?
-        return suggest_thumbnails(input) if prompt.id == CompletionPrompt::ILLUSTRATE_POST
+        raise Discourse::InvalidParameters.new(:mode) if params[:mode].blank?
+        if params[:mode] == DiscourseAi::AiHelper::Assistant::ILLUSTRATE_POST
+          return suggest_thumbnails(input)
+        end
 
-        if prompt.id == CompletionPrompt::CUSTOM_PROMPT
+        if params[:mode] == DiscourseAi::AiHelper::Assistant::CUSTOM_PROMPT
           raise Discourse::InvalidParameters.new(:custom_prompt) if params[:custom_prompt].blank?
         end
 
@@ -133,7 +129,7 @@ def stream_suggestion
             :stream_composer_helper,
             user_id: current_user.id,
             text: text,
-            prompt: prompt.name,
+            prompt: params[:mode],
             custom_prompt: params[:custom_prompt],
             force_default_locale: params[:force_default_locale] || false,
             client_id: params[:client_id],
@@ -149,7 +145,7 @@ def stream_suggestion
             post_id: post.id,
             user_id: current_user.id,
             text: text,
-            prompt: prompt.name,
+            prompt: params[:mode],
             custom_prompt: params[:custom_prompt],
             client_id: params[:client_id],
           )

app/jobs/regular/stream_composer_helper.rb

@@ -10,19 +10,16 @@ def execute(args)
       return unless args[:text]
       return unless args[:client_id]
 
-      prompt = CompletionPrompt.enabled_by_name(args[:prompt])
-
-      if prompt.id == CompletionPrompt::CUSTOM_PROMPT
-        prompt.custom_instruction = args[:custom_prompt]
-      end
+      helper_mode = args[:prompt]
 
       DiscourseAi::AiHelper::Assistant.new.stream_prompt(
-        prompt,
+        helper_mode,
         args[:text],
         user,
         "/discourse-ai/ai-helper/stream_composer_suggestion",
         force_default_locale: args[:force_default_locale],
         client_id: args[:client_id],
+        custom_prompt: args[:custom_prompt],
       )
     end
   end

app/jobs/regular/stream_post_helper.rb

@@ -14,16 +14,12 @@ def execute(args)
 
       return unless user.guardian.can_see?(post)
 
-      prompt = CompletionPrompt.enabled_by_name(args[:prompt])
+      helper_mode = args[:prompt]
 
-      if prompt.id == CompletionPrompt::CUSTOM_PROMPT
-        prompt.custom_instruction = args[:custom_prompt]
-      end
-
-      if prompt.name == "explain"
-        input = <<~TEXT
-      <term>#{args[:text]}</term>
-      <context>#{post.raw}</context>
+      if helper_mode == DiscourseAi::AiHelper::Assistant::EXPLAIN
+        input = <<~TEXT.strip
+          <term>#{args[:text]}</term>
+          <context>#{post.raw}</context>
           <topic>#{topic.title}</topic>
           #{reply_to ? "<replyTo>#{reply_to.raw}</replyTo>" : nil}
         TEXT
@@ -32,10 +28,11 @@ def execute(args)
       end
 
       DiscourseAi::AiHelper::Assistant.new.stream_prompt(
-        prompt,
+        helper_mode,
         input,
         user,
         "/discourse-ai/ai-helper/stream_suggestion/#{post.id}",
+        custom_prompt: args[:custom_prompt],
       )
     end
   end

assets/javascripts/discourse/components/ai-composer-helper-menu.gjs

@@ -73,7 +73,7 @@ export default class AiComposerHelperMenu extends Component {
     }
 
     prompts.forEach((p) => {
-      this.prompts[p.id] = p;
+      this.prompts[p.name] = p;
     });
 
     this.promptTypes = prompts.reduce((memo, p) => {
@@ -116,7 +116,7 @@ export default class AiComposerHelperMenu extends Component {
     if (option.name === "illustrate_post") {
       return this.modal.show(ThumbnailSuggestion, {
         model: {
-          mode: option.id,
+          mode: option.name,
           selectedText: this.args.data.selectedText,
           thumbnails: this.thumbnailSuggestions,
         },
@@ -128,7 +128,7 @@ export default class AiComposerHelperMenu extends Component {
 
     return this.modal.show(ModalDiffModal, {
       model: {
-        mode: option.id,
+        mode: option.name,
         selectedText: this.args.data.selectedText,
         revert: this.undoAiAction,
         toolbarEvent: this.args.data.toolbarEvent,

assets/javascripts/discourse/components/ai-helper-options-list.gjs

@@ -29,13 +29,12 @@ export default class AiHelperOptionsList extends Component {
             @submit={{@performAction}}
           />
         {{else}}
-          <li data-name={{option.translated_name}} data-value={{option.id}}>
+          <li data-name={{option.translated_name}} data-value={{option.name}}>
             <DButton
               @icon={{option.icon}}
               @translatedLabel={{option.translated_name}}
               @action={{fn @performAction option}}
               data-name={{option.name}}
-              data-value={{option.id}}
               class="ai-helper-options__button"
             >
               {{#if (and (eq option.name "proofread") this.showShortcut)}}

assets/javascripts/discourse/components/ai-post-helper-menu.gjs

@@ -202,7 +202,7 @@ export default class AiPostHelperMenu extends Component {
       this._activeAiRequest = ajax("/discourse-ai/ai-helper/suggest", {
         method: "POST",
         data: {
-          mode: option.id,
+          mode: option.name,
           text: this.args.data.quoteState.buffer,
           custom_prompt: this.customPromptValue,
         },
@@ -238,7 +238,7 @@ export default class AiPostHelperMenu extends Component {
       method: "POST",
       data: {
         location: "post",
-        mode: option.id,
+        mode: option.name,
         text: this.args.data.selectedText,
         post_id: this.args.data.quoteState.postId,
         custom_prompt: this.customPromptValue,

assets/javascripts/discourse/connectors/fast-edit-footer-after/ai-edit-suggestion-button.gjs

@@ -34,7 +34,7 @@ export default class AiEditSuggestionButton extends Component {
     this._activeAIRequest = ajax("/discourse-ai/ai-helper/suggest", {
       method: "POST",
       data: {
-        mode: this.mode.id,
+        mode: this.mode.name,
         text: this.args.outletArgs.initialValue,
         custom_prompt: "",
       },

assets/javascripts/initializers/admin-plugin-configuration-nav.js

@@ -41,12 +41,11 @@ export default {
           route: "adminPlugins.show.discourse-ai-spam",
           description: "discourse_ai.spam.spam_description",
         },
-        // TODO(@keegan / @roman): Uncomment this when structured output is merged
-        // {
-        //   label: "discourse_ai.features.short_title",
-        //   route: "adminPlugins.show.discourse-ai-features",
-        //   description: "discourse_ai.features.description",
-        // },
+        {
+          label: "discourse_ai.features.short_title",
+          route: "adminPlugins.show.discourse-ai-features",
+          description: "discourse_ai.features.description",
+        },
       ]);
     });
   },

assets/javascripts/initializers/ai-helper.js

@@ -44,7 +44,7 @@ function initializeAiHelperTrigger(api) {
 
         const mode = currentUser?.ai_helper_prompts.find(
           (p) => p.name === "proofread"
-        ).id;
+        ).name;
 
         modal.show(ModalDiffModal, {
           model: {

config/locales/server.en.yml

@@ -330,6 +330,7 @@ en:
         short_summarizer:
           name: "Summarizer (short form)"
           description: "Default persona used to power AI short summaries for topic lists' items"
+<<<<<<< Updated upstream
         concept_finder:
           name: "Concept Finder"
           description: "AI Bot specialized in identifying concepts and themes in content"
@@ -339,6 +340,35 @@ en:
         concept_deduplicator:
           name: "Concept Deduplicator"
           description: "AI Bot specialized in deduplicating concepts"
+=======
+        custom_prompt:
+          name: "Custom Prompt"
+          description: "Default persona powering the AI helper's custom prompt feature"
+        smart_dates:
+          name: "Smart Dates"
+          description: "Default persona powering the AI helper's smart dates feature"
+        markdown_table_generator:
+          name: "Markdown Table Generator"
+          description: "Default persona powering the AI helper's generate Markdown table feature"
+        post_illustrator:
+          name: "Post Illustrator"
+          description: "Generates StableDiffusion prompts to power the AI helper's illustrate post feature"
+        proofreader:
+          name: "Proofreader"
+          description: "Default persona powering the AI helper's proofread text feature"
+        titles_generator:
+          name: "Titles Generator"
+          description: "Default persona powering the AI helper's suggest topic titles feature"
+        tutor:
+          name: "Tutor"
+          description: "Default persona powering the AI helper's explain feature"
+        translator:
+          name: "Translator"
+          description: "Default persona powering the AI helper's translator feature"
+        image_captioner:
+          name: "Image Captions"
+          description: "Default persona powering the AI helper's image caption feature"
+>>>>>>> Stashed changes
       topic_not_found: "Summary unavailable, topic not found!"
       summarizing: "Summarizing topic"
       searching: "Searching for: '%{query}'"