DEV: consolidate into class lib and apply to personas

Author: keegangeorge

app/controllers/discourse_ai/admin/ai_llms_controller.rb

@@ -235,10 +235,8 @@ def log_llm_model_creation(llm_model)
           end.join("; ")
         end
 
-        StaffActionLogger.new(current_user).log_custom(
-          "create_ai_llm_model",
-          log_details
-        )
+        logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        logger.log_custom("create_ai_llm_model", log_details)
       end
 
       def log_llm_model_update(llm_model, initial_attributes, initial_quotas)
@@ -282,18 +280,14 @@ def log_llm_model_update(llm_model, initial_attributes, initial_quotas)
             model_name: llm_model.display_name || llm_model.name,
           }.merge(changes)
 
-          StaffActionLogger.new(current_user).log_custom(
-            "update_ai_llm_model",
-            log_details
-          )
+          logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+          logger.log_custom("update_ai_llm_model", log_details)
         end
       end
 
       def log_llm_model_deletion(model_details)
-        StaffActionLogger.new(current_user).log_custom(
-          "delete_ai_llm_model",
-          model_details
-        )
+        logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        logger.log_deletion("llm_model", model_details)
       end
     end
   end

app/controllers/discourse_ai/admin/ai_personas_controller.rb

@@ -58,6 +58,7 @@ def create
         ai_persona = AiPersona.new(ai_persona_params.except(:rag_uploads))
         if ai_persona.save
           RagDocumentFragment.link_target_and_uploads(ai_persona, attached_upload_ids)
+          log_ai_persona_creation(ai_persona)
 
           render json: {
                    ai_persona: LocalizedAiPersonaSerializer.new(ai_persona, root: false),
@@ -74,8 +75,12 @@ def create_user
       end
 
       def update
+        # Capture initial state for logging
+        initial_attributes = @ai_persona.attributes.dup
+
         if @ai_persona.update(ai_persona_params.except(:rag_uploads))
           RagDocumentFragment.update_target_uploads(@ai_persona, attached_upload_ids)
+          log_ai_persona_update(@ai_persona, initial_attributes)
 
           render json: LocalizedAiPersonaSerializer.new(@ai_persona, root: false)
         else
@@ -84,7 +89,15 @@ def update
       end
 
       def destroy
+        # Capture persona details for logging before destruction
+        persona_details = {
+          persona_id: @ai_persona.id,
+          name: @ai_persona.name,
+          description: @ai_persona.description
+        }
+
         if @ai_persona.destroy
+          log_ai_persona_deletion(persona_details)
           head :no_content
         else
           render_json_error @ai_persona
@@ -261,6 +274,48 @@ def permit_examples(examples)
 
         examples.map { |example_arr| example_arr.take(2).map(&:to_s) }
       end
+
+      def log_ai_persona_creation(ai_persona)
+        # Extract standard attributes
+        log_details = {
+          persona_id: ai_persona.id,
+          name: ai_persona.name,
+          description: ai_persona.description,
+          enabled: ai_persona.enabled,
+          priority: ai_persona.priority,
+          system_prompt: ai_persona.system_prompt&.truncate(100),
+          default_llm_id: ai_persona.default_llm_id,
+          temperature: ai_persona.temperature,
+          top_p: ai_persona.top_p,
+          user_id: ai_persona.user_id,
+          vision_enabled: ai_persona.vision_enabled,
+          tools_count: (ai_persona.tools || []).size,
+          allowed_group_ids: ai_persona.allowed_group_ids
+        }
+        
+        logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        logger.log_custom("create_ai_persona", log_details)
+      end
+
+      def log_ai_persona_update(ai_persona, initial_attributes)
+        trackable_fields = %w[
+          name description enabled system_prompt priority temperature top_p default_llm_id
+          user_id max_context_posts vision_enabled vision_max_pixels rag_chunk_tokens
+          rag_chunk_overlap_tokens rag_conversation_chunks rag_llm_model_id
+          question_consolidator_llm_id tool_details forced_tool_count
+          allow_chat_channel_mentions allow_chat_direct_messages allow_topic_mentions allow_personal_messages
+        ]
+
+        json_fields = %w[allowed_group_ids tools response_format examples]
+        
+        logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        logger.log_update("persona", ai_persona, initial_attributes, trackable_fields, json_fields)
+      end
+
+      def log_ai_persona_deletion(persona_details)
+        logger = DiscourseAi::Utils::AiStaffActionLogger.new(current_user)
+        logger.log_deletion("persona", persona_details)
+      end
     end
   end
 end

config/locales/client.en.yml

@@ -30,6 +30,9 @@ en:
             create_ai_llm_model: "Create LLM model"
             update_ai_llm_model: "Update LLM model"
             delete_ai_llm_model: "Delete LLM model"
+            create_ai_persona: "Create AI persona"
+            update_ai_persona: "Update AI persona"
+            delete_ai_persona: "Delete AI persona"
 
   js:
     discourse_automation:

lib/utils/ai_staff_action_logger.rb

@@ -0,0 +1,112 @@
+# frozen_string_literal: true
+
+module DiscourseAi
+  module Utils
+    class AiStaffActionLogger
+      def initialize(current_user)
+        @current_user = current_user
+        @staff_logger = ::StaffActionLogger.new(current_user)
+      end
+
+      # Log creation of an AI entity (LLM model or persona)
+      def log_creation(entity_type, entity, attributes_to_log)
+        log_details = extract_entity_attributes(entity, attributes_to_log)
+        
+        @staff_logger.log_custom("create_ai_#{entity_type}", log_details)
+      end
+
+      # Log update of an AI entity with before/after comparison
+      def log_update(entity_type, entity, initial_attributes, trackable_fields, json_fields = [])
+        current_attributes = entity.attributes
+        changes = {}
+
+        # Track changes to standard fields
+        trackable_fields.each do |field|
+          initial_value = initial_attributes[field]
+          current_value = current_attributes[field]
+          
+          if initial_value != current_value
+            # For large text fields, don't show the entire content
+            if should_simplify_field?(field, initial_value, current_value)
+              changes[field] = "updated"
+            else
+              changes[field] = "#{initial_value} → #{current_value}"
+            end
+          end
+        end
+
+        # Track changes to arrays and JSON fields
+        json_fields.each do |field|
+          if initial_attributes[field].to_s != current_attributes[field].to_s
+            changes[field] = "updated"
+          end
+        end
+
+        # Only log if there are actual changes
+        if changes.any?
+          log_details = entity_identifier(entity, entity_type).merge(changes)
+          @staff_logger.log_custom("update_ai_#{entity_type}", log_details)
+        end
+      end
+
+      # Log deletion of an AI entity
+      def log_deletion(entity_type, entity_details)
+        @staff_logger.log_custom("delete_ai_#{entity_type}", entity_details)
+      end
+      
+      # Direct custom logging for complex cases
+      def log_custom(action_type, log_details)
+        @staff_logger.log_custom(action_type, log_details)
+      end
+
+      private
+
+      def extract_entity_attributes(entity, attributes_to_log)
+        result = {}
+        
+        attributes_to_log.each do |attr|
+          value = entity.public_send(attr)
+          
+          # Handle large text fields
+          if attr == :system_prompt && value.is_a?(String) && value.length > 100
+            result[attr] = value.truncate(100)
+          else
+            result[attr] = value
+          end
+        end
+        
+        result
+      end
+
+      def should_simplify_field?(field, initial_value, current_value)
+        # For large text fields, or sensitive data, don't show the entire content
+        return true if field == "system_prompt" && 
+                       initial_value.present? && 
+                       current_value.present? && 
+                       (initial_value.length > 100 || current_value.length > 100)
+        
+        return true if field.include?("api_key") || field.include?("secret") || field.include?("password")
+        
+        false
+      end
+
+      def entity_identifier(entity, entity_type)
+        case entity_type
+        when "llm_model"
+          {
+            model_id: entity.id,
+            model_name: entity.name,
+            display_name: entity.display_name
+          }
+        when "persona"
+          {
+            persona_id: entity.id,
+            persona_name: entity.name
+          }
+        else
+          { id: entity.id }
+        end
+      end
+    end
+  end
+end