DEV: Fixes to spec + explain spec

Author: keegangeorge

spec/system/ai_helper/ai_post_helper_spec.rb

@@ -30,6 +30,7 @@
     Group.find_by(id: Group::AUTO_GROUPS[:admins]).add(user)
     assign_fake_provider_to(:ai_helper_model)
     SiteSetting.ai_helper_enabled = true
+    Jobs.run_immediately!
     sign_in(user)
   end
 
@@ -87,13 +88,33 @@ def select_post_text(selected_post)
       end
 
       it "pre-fills fast edit with proofread text" do
-        skip("Test is flaky in CI, possibly some timing issue?") if ENV["CI"]
         select_post_text(post_3)
         post_ai_helper.click_ai_button
         DiscourseAi::Completions::Llm.with_prepared_responses([proofread_response]) do
           post_ai_helper.select_helper_model(mode)
-          wait_for { fast_editor.has_content?(proofread_response) }
-          expect(fast_editor).to have_content(proofread_response)
+          expect(page.find("#fast-edit-input")).to have_content(proofread_response)
+        end
+      end
+    end
+
+    context "when using explain mode" do
+      let(:mode) { DiscourseAi::AiHelper::Assistant::EXPLAIN }
+      let(:explain_response) { "This is about pie." }
+
+      it "shows the explanation in the AI helper" do
+        select_post_text(post)
+        post_ai_helper.click_ai_button
+
+        DiscourseAi::Completions::Llm.with_prepared_responses([explain_response]) do
+          post_ai_helper.select_helper_model(mode)
+
+          MessageBus.publish(
+            "/discourse-ai/ai-helper/stream_suggestion/#{post.id}",
+            { result: explain_response, done: true },
+            user_ids: [user.id],
+          )
+
+          expect(post_ai_helper.suggestion_value).to eq(explain_response)
         end
       end
     end
@@ -128,13 +149,11 @@ def select_post_text(selected_post)
     end
 
     it "pre-fills fast edit with proofread text" do
-      skip("Test is flaky in CI, possibly some timing issue?") if ENV["CI"]
       select_post_text(post_3)
       find(".quote-edit-label").click
       DiscourseAi::Completions::Llm.with_prepared_responses([proofread_response]) do
         find(".btn-ai-suggest-edit", visible: :all).click
-        wait_for { fast_editor.has_content?(proofread_response) }
-        expect(fast_editor).to have_content(proofread_response)
+        expect(page.find("#fast-edit-input")).to have_content(proofread_response)
       end
     end
   end

spec/system/page_objects/components/ai_post_helper_menu.rb

@@ -9,7 +9,6 @@ class AiPostHelperMenu < PageObjects::Components::Base
       SHARE_SELECTOR = ".quote-sharing"
 
       AI_HELPER_SELECTOR = ".ai-post-helper"
-      AI_HELPER_MOBILE_SELECTOR = ".ai-post-helper-menu-content"
       TRIGGER_SELECTOR = "#{AI_HELPER_SELECTOR}__trigger"
       OPTIONS_SELECTOR = ".ai-helper-options"
       LOADING_SELECTOR = ".ai-helper-context-menu__loading"
@@ -28,6 +27,10 @@ def select_helper_model(mode)
         find("#{OPTIONS_SELECTOR} .btn[data-name=\"#{mode}\"]").click
       end
 
+      def has_suggestion_value?
+        page.has_css?("#{SUGGESTION_SELECTOR}__text")
+      end
+
       def suggestion_value
         find("#{SUGGESTION_SELECTOR}__text").text
       end
@@ -41,11 +44,11 @@ def has_no_highlighted_text?
       end
 
       def has_mobile_post_ai_helper?
-        page.has_css?(AI_HELPER_MOBILE_SELECTOR)
+        page.has_css?(".fk-d-menu-modal #{AI_HELPER_SELECTOR}")
       end
 
       def has_no_mobile_post_ai_helper?
-        page.has_no_css?(AI_HELPER_MOBILE_SELECTOR)
+        page.has_no_css?(".fk-d-menu-modal #{AI_HELPER_SELECTOR}")
       end
 
       def has_post_ai_helper?
@@ -81,6 +84,10 @@ def has_no_post_selection_primary_buttons?
         page.has_no_css?(QUOTE_SELECTOR) || page.has_no_css?(EDIT_SELECTOR) ||
           page.has_no_css?(SHARE_SELECTOR)
       end
+
+      def has_suggestions?
+        page.has_css?(SUGGESTION_SELECTOR)
+      end
     end
   end
 end