lint

Author: SamSaffron

app/controllers/discourse_ai/ai_bot/artifacts_controller.rb

@@ -50,11 +50,10 @@ def show
 
       def require_site_settings!
         if !SiteSetting.discourse_ai_enabled ||
-            !SiteSetting.ai_artifact_security.in?(%w[lax strict])
+             !SiteSetting.ai_artifact_security.in?(%w[lax strict])
           raise Discourse::NotFound
         end
       end
-
     end
   end
 end

app/models/ai_artifact.rb

@@ -16,9 +16,7 @@ def self.url(id)
 
   def self.share_publicly(id:, post:)
     artifact = AiArtifact.find_by(id: id)
-    if artifact&.post&.topic&.id == post.topic.id
-      artifact.update!(metadata: { public: true })
-    end
+    artifact.update!(metadata: { public: true }) if artifact&.post&.topic&.id == post.topic.id
   end
 
   def self.unshare_publicly(id:)

app/models/shared_ai_conversation.rb

@@ -183,16 +183,18 @@ def self.build_conversation_data(topic, max_posts: DEFAULT_MAX_POSTS, include_us
 
   def self.cook_artifacts(post)
     html = post.cooked
-    return html if !["lax", "strict"].include?(SiteSetting.ai_artifact_security)
+    return html if !%w[lax strict].include?(SiteSetting.ai_artifact_security)
 
     doc = Nokogiri::HTML5.fragment(html)
-    doc.css("div.ai-artifact").each do |node|
-      id = node["data-ai-artifact-id"].to_i
-      if id > 0
-        AiArtifact.share_publicly(id: id, post: post)
-        node.replace(AiArtifact.iframe_for(id))
+    doc
+      .css("div.ai-artifact")
+      .each do |node|
+        id = node["data-ai-artifact-id"].to_i
+        if id > 0
+          AiArtifact.share_publicly(id: id, post: post)
+          node.replace(AiArtifact.iframe_for(id))
+        end
       end
-    end
 
     doc.to_s
   end

spec/requests/ai_bot/shared_ai_conversations_spec.rb

@@ -87,26 +87,26 @@ def share_error(key)
       end
 
       context "when ai artifacts are in lax mode" do
-        before do
-          SiteSetting.ai_artifact_security = "lax"
-        end
+        before { SiteSetting.ai_artifact_security = "lax" }
 
         it "properly shares artifacts" do
           first_post = user_pm_share.posts.first
 
-          artifact_not_allowed = AiArtifact.create!(
-            user: bot_user,
-            post: Fabricate(:private_message_post),
-            name: "test",
-            html: "<div>test</div>",
-          )
-
-          artifact = AiArtifact.create!(
-            user: bot_user,
-            post: first_post,
-            name: "test",
-            html: "<div>test</div>",
-          )
+          artifact_not_allowed =
+            AiArtifact.create!(
+              user: bot_user,
+              post: Fabricate(:private_message_post),
+              name: "test",
+              html: "<div>test</div>",
+            )
+
+          artifact =
+            AiArtifact.create!(
+              user: bot_user,
+              post: first_post,
+              name: "test",
+              html: "<div>test</div>",
+            )
 
           # lets log out and see we can not access the artifacts
           delete "/session/#{user.id}"
@@ -134,7 +134,6 @@ def share_error(key)
           get "#{path}/#{key}"
           expect(response).to have_http_status(:success)
 
-
           expect(response.body).to include(artifact.url)
           expect(response.body).to include(artifact_not_allowed.url)