tests

Author: xfalcox

app/models/inferred_concept_post.rb

@@ -15,13 +15,13 @@ class InferredConceptPost < ActiveRecord::Base
 #
 # Table name: inferred_concepts_posts
 #
-#  inferred_concept_id :bigint           not null
-#  post_id             :bigint           not null
+#  inferred_concept_id :bigint
+#  post_id             :bigint
 #  created_at          :datetime         not null
 #  updated_at          :datetime         not null
 #
 # Indexes
 #
-#  index_inferred_concepts_posts_uniqueness  (post_id,inferred_concept_id) UNIQUE
 #  index_inferred_concepts_posts_on_inferred_concept_id  (inferred_concept_id)
+#  index_inferred_concepts_posts_uniqueness              (post_id,inferred_concept_id) UNIQUE
 #

app/models/inferred_concept_topic.rb

@@ -15,13 +15,13 @@ class InferredConceptTopic < ActiveRecord::Base
 #
 # Table name: inferred_concepts_topics
 #
-#  inferred_concept_id :bigint           not null
-#  topic_id            :bigint           not null
+#  inferred_concept_id :bigint
+#  topic_id            :bigint
 #  created_at          :datetime         not null
 #  updated_at          :datetime         not null
 #
 # Indexes
 #
-#  index_inferred_concepts_topics_uniqueness  (topic_id,inferred_concept_id) UNIQUE
 #  index_inferred_concepts_topics_on_inferred_concept_id  (inferred_concept_id)
+#  index_inferred_concepts_topics_uniqueness              (topic_id,inferred_concept_id) UNIQUE
 #

spec/lib/inferred_concepts/applier_spec.rb

@@ -136,14 +136,13 @@
       # Mock the LLM interaction
       persona_double = instance_spy(AiPersona)
       bot_double = instance_spy(DiscourseAi::Personas::Bot)
-      structured_output_double = instance_spy(Object)
-      llm_class_double = instance_spy(Class)
+      structured_output_double = double("StructuredOutput")
+      llm_class_double = double("PersonaClass", default_llm_id: llm_model.id)
 
       allow(AiPersona).to receive_message_chain(:all_personas, :find, :new).and_return(
         persona_double,
       )
       allow(persona_double).to receive(:class).and_return(llm_class_double)
-      allow(llm_class_double).to receive(:default_llm_id).and_return(llm_model.id)
       allow(LlmModel).to receive(:find).and_return(llm_model)
       allow(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
       allow(bot_double).to receive(:reply).and_yield(
@@ -186,14 +185,13 @@
       # Mock the LLM interaction
       persona_double = instance_spy(AiPersona)
       bot_double = instance_spy(DiscourseAi::Personas::Bot)
-      structured_output_double = instance_spy(Object)
-      llm_class_double = instance_spy(Class)
+      structured_output_double = double("StructuredOutput")
+      llm_class_double = double("PersonaClass", default_llm_id: llm_model.id)
 
       allow(AiPersona).to receive_message_chain(:all_personas, :find, :new).and_return(
         persona_double,
       )
       allow(persona_double).to receive(:class).and_return(llm_class_double)
-      allow(llm_class_double).to receive(:default_llm_id).and_return(llm_model.id)
       allow(LlmModel).to receive(:find).and_return(llm_model)
       allow(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
       allow(bot_double).to receive(:reply).and_yield(
@@ -221,9 +219,9 @@
     it "uses ConceptMatcher persona to match concepts" do
       content = "This is about Ruby programming"
       concept_list = %w[programming testing ruby]
-      structured_output_double = instance_spy(Object)
+      structured_output_double = double("StructuredOutput")
 
-      persona_class_double = instance_spy(Class)
+      persona_class_double = double("PersonaClass", default_llm_id: llm_model.id)
       persona_double = instance_spy(AiPersona)
       bot_double = instance_spy(DiscourseAi::Personas::Bot)
 
@@ -232,7 +230,6 @@
       )
       allow(persona_class_double).to receive(:new).and_return(persona_double)
       allow(persona_double).to receive(:class).and_return(persona_class_double)
-      allow(persona_class_double).to receive(:default_llm_id).and_return(llm_model.id)
       allow(LlmModel).to receive(:find).and_return(llm_model)
       allow(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
       allow(bot_double).to receive(:reply).and_yield(
@@ -257,7 +254,7 @@
       content = "Test content"
       concept_list = ["concept1"]
 
-      persona_class_double = double("ConceptMatcherClass")
+      persona_class_double = double("ConceptMatcherClass", default_llm_id: llm_model.id)
       persona_double = double("ConceptMatcher")
       bot_double = double("Bot")
 
@@ -266,7 +263,6 @@
       )
       expect(persona_class_double).to receive(:new).and_return(persona_double)
       expect(persona_double).to receive(:class).and_return(persona_class_double)
-      expect(persona_class_double).to receive(:default_llm_id).and_return(llm_model.id)
       expect(LlmModel).to receive(:find).and_return(llm_model)
       expect(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
       expect(bot_double).to receive(:reply).and_yield(nil, nil, :text)
@@ -280,7 +276,7 @@
       concept_list = %w[programming testing]
       expected_response = [['{"matching_concepts": []}']]
 
-      persona_class_double = double("ConceptMatcherClass")
+      persona_class_double = double("ConceptMatcherClass", default_llm_id: llm_model.id)
       persona_double = double("ConceptMatcher")
       bot_double = double("Bot")
 
@@ -289,7 +285,6 @@
       )
       expect(persona_class_double).to receive(:new).and_return(persona_double)
       expect(persona_double).to receive(:class).and_return(persona_class_double)
-      expect(persona_class_double).to receive(:default_llm_id).and_return(llm_model.id)
       expect(LlmModel).to receive(:find).and_return(llm_model)
       expect(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
       expect(bot_double).to receive(:reply).and_return(expected_response)
@@ -303,7 +298,7 @@
       concept_list = ["concept1"]
       expected_response = [['{"other_key": ["value"]}']]
 
-      persona_class_double = double("ConceptMatcherClass")
+      persona_class_double = double("ConceptMatcherClass", default_llm_id: llm_model.id)
       persona_double = double("ConceptMatcher")
       bot_double = double("Bot")
 
@@ -312,7 +307,6 @@
       )
       expect(persona_class_double).to receive(:new).and_return(persona_double)
       expect(persona_double).to receive(:class).and_return(persona_class_double)
-      expect(persona_class_double).to receive(:default_llm_id).and_return(llm_model.id)
       expect(LlmModel).to receive(:find).and_return(llm_model)
       expect(DiscourseAi::Personas::Bot).to receive(:as).and_return(bot_double)
       expect(bot_double).to receive(:reply).and_return(expected_response)