Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Commit 8852e2a

Browse files
committed
skip test in playwright and fix implementation
1 parent 43fabb6 commit 8852e2a

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

assets/javascripts/initializers/ai-conversations-sidebar.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ export default {
9393
@tracked loadedSevenDayLabel = false;
9494
@tracked loadedThirtyDayLabel = false;
9595
@tracked loadedMonthLabels = new Set();
96-
@tracked isFetching = false;
96+
@tracked isLoading = true;
97+
isFetching = false;
9798
page = 0;
9899
totalTopicsCount = 0;
99100

@@ -123,7 +124,7 @@ export default {
123124
}
124125

125126
get emptyStateComponent() {
126-
if (!this.isFetching) {
127+
if (!this.isLoading) {
127128
return AiBotSidebarEmptyState;
128129
}
129130
}
@@ -216,6 +217,8 @@ export default {
216217
this.attachScrollListener();
217218
} catch {
218219
this.isFetching = false;
220+
} finally {
221+
this.isLoading = false;
219222
}
220223
}
221224

spec/system/ai_bot/homepage_spec.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,15 +137,17 @@
137137
expect(page).to have_no_css(".ai-bot-upload")
138138
end
139139

140-
xit "allows removing an upload before submission" do
140+
it "allows removing an upload before submission" do
141+
skip "TODO: fix this test for playwright"
142+
141143
ai_pm_homepage.visit
142144
expect(ai_pm_homepage).to have_homepage
143145

144146
file_path = file_from_fixtures("logo.png", "images").path
145147
attach_file([file_path]) { find(".ai-bot-upload-btn", visible: true).click }
146-
147148
expect(page).to have_css(".ai-bot-upload", count: 1)
148149

150+
# TODO: for some reason this line fails in playwright
149151
find(".ai-bot-upload__remove").click
150152

151153
expect(page).to have_no_css(".ai-bot-upload")

0 commit comments

Comments
 (0)