partial tool calls are implemented

Author: SamSaffron

lib/ai_bot/bot.rb

@@ -108,12 +108,37 @@ def reply(context, &update_blk)
 
           tool_halted = false
 
+          allow_partial_tool_calls = persona.allow_partial_tool_calls?
+          existing_tools = Set.new
+
           result =
-            llm.generate(prompt, feature_name: "bot", **llm_kwargs) do |partial, cancel|
-              tool = persona.find_tool(partial, bot_user: user, llm: llm, context: context)
+            llm.generate(
+              prompt,
+              feature_name: "bot",
+              partial_tool_calls: allow_partial_tool_calls,
+              **llm_kwargs,
+            ) do |partial, cancel|
+              tool =
+                persona.find_tool(
+                  partial,
+                  bot_user: user,
+                  llm: llm,
+                  context: context,
+                  existing_tools: existing_tools,
+                )
               tool = nil if tools_ran >= MAX_TOOLS
 
               if tool.present?
+                tool_call = partial
+                if tool_call.partial?
+                  if tool.class.allow_partial_tool_calls?
+                    tool.partial_invoke
+                    update_blk.call("", cancel, tool.custom_raw, :partial_tool)
+                  end
+                  next
+                end
+
+                existing_tools << tool
                 tool_found = true
                 # a bit hacky, but extra newlines do no harm
                 if needs_newlines
@@ -125,9 +150,7 @@ def reply(context, &update_blk)
                 tools_ran += 1
                 ongoing_chain &&= tool.chain_next_response?
 
-                if !tool.chain_next_response?
-                  tool_halted = true
-                end
+                tool_halted = true if !tool.chain_next_response?
               else
                 next if tool_halted
                 needs_newlines = true
@@ -192,7 +215,7 @@ def process_tool(tool, raw_context, llm, cancel, update_blk, prompt, context)
       end
 
       def invoke_tool(tool, llm, cancel, context, &update_blk)
-        show_placeholder = !context[:skip_tool_details]
+        show_placeholder = !context[:skip_tool_details] && !tool.class.allow_partial_tool_calls?
 
         update_blk.call("", cancel, build_placeholder(tool.summary, "")) if show_placeholder
 

lib/ai_bot/personas/persona.rb

@@ -200,14 +200,18 @@ def craft_prompt(context, llm: nil)
           prompt
         end
 
-        def find_tool(partial, bot_user:, llm:, context:)
+        def find_tool(partial, bot_user:, llm:, context:, existing_tools: [])
           return nil if !partial.is_a?(DiscourseAi::Completions::ToolCall)
-          tool_instance(partial, bot_user: bot_user, llm: llm, context: context)
+          tool_instance(partial, bot_user: bot_user, llm: llm, context: context, existing_tools: existing_tools)
+        end
+
+        def allow_partial_tool_calls?
+          available_tools.any? { |tool| tool.allow_partial_tool_calls? }
         end
 
         protected
 
-        def tool_instance(tool_call, bot_user:, llm:, context:)
+        def tool_instance(tool_call, bot_user:, llm:, context:, existing_tools:)
           function_id = tool_call.id
           function_name = tool_call.name
           return nil if function_name.nil?
@@ -241,14 +245,21 @@ def tool_instance(tool_call, bot_user:, llm:, context:)
             arguments[name.to_sym] = value if value
           end
 
-          tool_klass.new(
-            arguments,
-            tool_call_id: function_id || function_name,
-            persona_options: options[tool_klass].to_h,
-            bot_user: bot_user,
-            llm: llm,
-            context: context,
-          )
+          tool_instance = existing_tools.find { |t| t.name == function_name && t.tool_call_id == function_id }
+
+          if tool_instance
+            tool_instance.parameters = arguments
+            tool_instance
+          else
+            tool_klass.new(
+              arguments,
+              tool_call_id: function_id || function_name,
+              persona_options: options[tool_klass].to_h,
+              bot_user: bot_user,
+              llm: llm,
+              context: context,
+            )
+          end
         end
 
         def strip_quotes(value)

lib/ai_bot/playground.rb

@@ -456,7 +456,7 @@ def reply_to(post, custom_instructions: nil, &blk)
             raw = reply.dup
             raw << "\n\n" << placeholder if placeholder.present?
 
-            blk.call(partial) if blk && type != :tool_details
+            blk.call(partial) if blk && type != :tool_details && type != :partial_tool
 
             if stream_reply && !Discourse.redis.get(redis_stream_key)
               cancel&.call

lib/ai_bot/tools/create_artifact.rb

@@ -38,6 +38,19 @@ def self.signature
           }
         end
 
+        def self.allow_partial_tool_calls?
+          true
+        end
+
+        def partial_invoke
+          @selected_tab = :html
+          if @prev_parameters
+            @selected_tab = parameters.keys.find { |k| @prev_parameters[k] != parameters[k] }
+          end
+          update_custom_html
+          @prev_parameters = parameters.dup
+        end
+
         def invoke
           yield parameters[:name] || "Web Artifact"
           # Get the current post from context
@@ -61,34 +74,73 @@ def invoke
             )
 
           if artifact.save
-            tabs = {
-              css: [css, "CSS"],
-              js: [js, "JavaScript"],
-              html: [html, "HTML"],
-              preview: [
-                "<iframe src=\"#{Discourse.base_url}/discourse-ai/ai-bot/artifacts/#{artifact.id}\" width=\"100%\" height=\"500\" frameborder=\"0\"></iframe>",
-                "Preview",
-              ],
-            }
-
-            first = true
-            html_tabs =
-              tabs.map do |tab, (content, name)|
-                selected = " data-selected" if first
-                first = false
-                (<<~HTML).strip
+            update_custom_html(artifact)
+            success_response(artifact)
+          else
+            error_response(artifact.errors.full_messages.join(", "))
+          end
+        end
+
+        def chain_next_response?
+          @chain_next_response
+        end
+
+        private
+
+        def update_custom_html(artifact = nil)
+          html = parameters[:html_body].to_s
+          css = parameters[:css].to_s
+          js = parameters[:js].to_s
+
+          iframe =
+            "<iframe src=\"#{Discourse.base_url}/discourse-ai/ai-bot/artifacts/#{artifact.id}\" width=\"100%\" height=\"500\" frameborder=\"0\"></iframe>" if artifact
+
+          content = []
+
+          content << [:html, "### HTML\n\n```html\n#{html}\n```"] if html.present?
+
+          content << [:css, "### CSS\n\n```css\n#{css}\n```"] if css.present?
+
+          content << [:js, "### JavaScript\n\n```javascript\n#{js}\n```"] if js.present?
+
+          content << [:preview, "### Preview\n\n#{iframe}"] if iframe
+
+          content.sort_by! { |c| c[0] === @selected_tab ? 0 : 1 } if !artifact
+
+          self.custom_raw = content.map { |c| c[1] }.join("\n\n")
+        end
+
+        def update_custom_html_old(artifact = nil)
+          html = parameters[:html_body].to_s
+          css = parameters[:css].to_s
+          js = parameters[:js].to_s
+
+          tabs = { css: [css, "CSS"], js: [js, "JavaScript"], html: [html, "HTML"] }
+
+          if artifact
+            iframe =
+              "<iframe src=\"#{Discourse.base_url}/discourse-ai/ai-bot/artifacts/#{artifact.id}\" width=\"100%\" height=\"500\" frameborder=\"0\"></iframe>"
+            tabs[:preview] = [iframe, "Preview"]
+          end
+
+          first = true
+          html_tabs =
+            tabs.map do |tab, (content, name)|
+              selected = " data-selected" if first
+              first = false
+              (<<~HTML).strip
                 <div class="ai-artifact-tab" data-#{tab}#{selected}>
                   <a>#{name}</a>
                 </div>
               HTML
-              end
-
-            first = true
-            html_panels =
-              tabs.map do |tab, (content, name)|
-                selected = " data-selected" if first
-                first = false
-                inner_content =
+            end
+
+          first = true
+          html_panels =
+            tabs.map do |tab, (content, name)|
+              selected = " data-selected" if (first || (!artifact && tab == @selected_tab))
+              first = false
+              inner_content =
                 if tab == :preview
                   content
                 else
@@ -99,15 +151,15 @@ def invoke
                   ```
                   HTML
                 end
-                (<<~HTML).strip
+              (<<~HTML).strip
                 <div class="ai-artifact-panel" data-#{tab}#{selected}>
 
                   #{inner_content}
                 </div>
               HTML
-              end
+            end
 
-            self.custom_raw = <<~RAW
+          self.custom_raw = <<~RAW
               <div class="ai-artifact">
                 <div class="ai-artifact-tabs">
                   #{html_tabs.join("\n")}
@@ -117,19 +169,8 @@ def invoke
                 </div>
               </div>
             RAW
-
-            success_response(artifact)
-          else
-            error_response(artifact.errors.full_messages.join(", "))
-          end
         end
 
-        def chain_next_response?
-          @chain_next_response
-        end
-
-        private
-
         def success_response(artifact)
           @chain_next_response = false
           iframe_url = "#{Discourse.base_url}/discourse-ai/ai-bot/artifacts/#{artifact.id}"

lib/ai_bot/tools/tool.rb

@@ -38,10 +38,14 @@ def help
           def custom_system_message
             nil
           end
+
+          def allow_partial_tool_calls?
+            false
+          end
         end
 
-        attr_accessor :custom_raw
-        attr_reader :tool_call_id, :persona_options, :bot_user, :llm, :context, :parameters
+        attr_accessor :custom_raw, :parameters
+        attr_reader :tool_call_id, :persona_options, :bot_user, :llm, :context
 
         def initialize(
           parameters,

lib/completions/endpoints/base.rb

@@ -96,7 +96,7 @@ def perform_completion!(
                 raise CompletionFailed, response.body
               end
 
-              xml_tool_processor = XmlToolProcessor.new if xml_tools_enabled? &&
+              xml_tool_processor = XmlToolProcessor.new(partial_tool_calls: partial_tool_calls) if xml_tools_enabled? &&
                 dialect.prompt.has_tools?
 
               to_strip = xml_tags_to_strip(dialect)

lib/completions/endpoints/gemini.rb

@@ -144,6 +144,7 @@ def decode(str)
 
         def decode(chunk)
           json = JSON.parse(chunk, symbolize_names: true)
+
           idx = -1
           json
             .dig(:candidates, 0, :content, :parts)
@@ -168,7 +169,6 @@ def decode(chunk)
 
         def decode_chunk(chunk)
           @tool_index ||= -1
-
           streaming_decoder
             .decode(chunk)
             .map do |parsed|

lib/completions/tool_call.rb

@@ -6,6 +6,10 @@ class ToolCall
       attr_reader :id, :name, :parameters
       attr_accessor :partial
 
+      def partial?
+        !!@partial
+      end
+
       def initialize(id:, name:, parameters: nil)
         @id = id
         @name = name