Address review feedback

Author: markvanlan

app/controllers/discourse_ai/ai_bot/conversations_controller.rb

@@ -26,7 +26,7 @@ def index
                    total: total,
                    page: page,
                    per_page: per_page,
-                   more: total > (page + 1) * per_page,
+                   has_more: total > (page + 1) * per_page,
                  },
                }
       end

assets/javascripts/discourse/controllers/discourse-ai-bot-conversations.js

@@ -31,6 +31,10 @@ export default class DiscourseAiBotConversations extends Controller {
     }
   }
 
+  get displayPersonaSelector() {
+    return this.personaOptions.length > 1;
+  }
+
   get filterable() {
     return this.personaOptions.length > 4;
   }

assets/javascripts/discourse/routes/discourse-ai-bot-conversations.js

@@ -1,6 +1,7 @@
 import { action } from "@ember/object";
 import { next } from "@ember/runloop";
 import Service, { service } from "@ember/service";
+import { popupAjaxError } from "discourse/lib/ajax-error";
 import { i18n } from "discourse-i18n";
 import { composeAiBotMessage } from "../lib/ai-bot-helper";
 
@@ -54,9 +55,8 @@ export default class AiBotConversationsHiddenSubmit extends Service {
         // but avoids deleting too-short message on submit
         this.inputValue = "";
       }
-    } catch (error) {
-      // eslint-disable-next-line no-console
-      console.error("Failed to submit message:", error);
+    } catch (e) {
+      popupAjaxError(e);
     }
   }
 }

assets/javascripts/discourse/services/ai-bot-conversations-hidden-submit.js

@@ -0,0 +1,51 @@
+import { hash } from "@ember/helper";
+import { on } from "@ember/modifier";
+import didInsert from "@ember/render-modifiers/modifiers/did-insert";
+import RouteTemplate from "ember-route-template";
+import DButton from "discourse/components/d-button";
+import { i18n } from "discourse-i18n";
+import DropdownSelectBox from "select-kit/components/dropdown-select-box";
+
+export default RouteTemplate(
+  <template>
+    <div class="ai-bot-conversations">
+      {{#if @controller.displayPersonaSelector}}
+        <div class="ai-bot-conversations__persona-selector">
+          <DropdownSelectBox
+            class="persona-llm-selector__persona-dropdown"
+            @value={{@controller.selectedPersona}}
+            @valueProperty="username"
+            @content={{@controller.personaOptions}}
+            @options={{hash icon="robot" filterable=@controller.filterable}}
+            @onChange={{@controller.selectedPersonaChanged}}
+          />
+        </div>
+      {{/if}}
+
+      <div class="ai-bot-conversations__content-wrapper">
+
+        <h1>{{i18n "discourse_ai.ai_bot.conversations.header"}}</h1>
+        <div class="ai-bot-conversations__input-wrapper">
+          <textarea
+            {{didInsert @controller.setTextArea}}
+            {{on "input" @controller.updateInputValue}}
+            {{on "keydown" @controller.handleKeyDown}}
+            id="ai-bot-conversations-input"
+            placeholder={{i18n "discourse_ai.ai_bot.conversations.placeholder"}}
+            minlength="10"
+            rows="1"
+          />
+          <DButton
+            @action={{@controller.aiBotConversationsHiddenSubmit.submitToBot}}
+            @icon="paper-plane"
+            @title="discourse_ai.ai_bot.conversations.header"
+            class="ai-bot-button btn-primary ai-conversation-submit"
+          />
+        </div>
+        <p class="ai-disclaimer">
+          {{i18n "discourse_ai.ai_bot.conversations.disclaimer"}}
+        </p>
+      </div>
+    </div>
+  </template>
+);

assets/javascripts/discourse/templates/discourse-ai-bot-conversations.gjs

@@ -168,7 +168,7 @@ export default {
                 }
 
                 this.totalTopicsCount = data.meta.total;
-                this.hasMore = data.meta.more;
+                this.hasMore = data.meta.has_more;
                 this.isFetching = false;
                 this.removeScrollListener();
                 this.buildSidebarLinks();

assets/javascripts/discourse/templates/discourse-ai-bot-conversations.hbs

@@ -241,22 +241,6 @@ body.has-ai-conversations-sidebar {
       }
     }
 
-    .ai-question-button {
-      border-radius: var(--border-radius);
-      border: 1px solid var(--primary-low);
-      line-height: var(--line-height-medium);
-
-      .d-button-label {
-        color: var(--primary-high);
-      }
-
-      .discourse-no-touch & {
-        &:hover {
-          background: var(--primary-low);
-        }
-      }
-    }
-
     .ai-disclaimer {
       text-align: center;
       font-size: var(--font-down-1);

assets/javascripts/initializers/ai-conversations-sidebar.js

@@ -719,7 +719,7 @@ en:
         conversations:
           header: "What can I help with?"
           submit: "Submit question"
-          disclaimer: "Generative AI can make mistakes"
+          disclaimer: "Generative AI can make mistakes. Verify important information."
           placeholder: "Ask a question..."
           new: "New Question"
           min_input_length_message: "Message must be longer than 10 characters"

assets/stylesheets/modules/ai-bot-conversations/common.scss

@@ -14,7 +14,10 @@ def submit
       end
 
       def has_too_short_dialog?
-        page.find(".dialog-content", text: "Message must be longer than 10 characters")
+        page.find(
+          ".dialog-content",
+          text: I18n.t("js.discourse_ai.ai_bot.conversations.min_input_length_message"),
+        )
       end
 
       def has_homepage?