Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Commit 9b1e4d4

Browse files
committed
utilize username if name not available
1 parent 3e12710 commit 9b1e4d4

File tree

1 file changed

+14
-15
lines changed

1 file changed

+14
-15
lines changed

lib/summarization/strategies/topic_summary.rb

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -13,29 +13,28 @@ def highest_target_number
1313
end
1414

1515
def targets_data
16-
name_or_username =
17-
if SiteSetting.enable_names && !SiteSetting.prioritize_username_in_ux
18-
:name || :username
19-
else
20-
:username
21-
end
16+
post_attributes = %i[post_number raw username last_version_at]
17+
if SiteSetting.enable_names && !SiteSetting.prioritize_username_in_ux
18+
post_attributes.push(:name)
19+
end
2220

23-
posts_data =
24-
(target.has_summary? ? best_replies : pick_selection).pluck(
25-
:post_number,
26-
:raw,
27-
name_or_username,
28-
:last_version_at,
29-
)
21+
posts_data = (target.has_summary? ? best_replies : pick_selection).pluck(post_attributes)
3022

31-
posts_data.reduce([]) do |memo, (pn, raw, username, last_version_at)|
23+
posts_data.reduce([]) do |memo, (pn, raw, username, last_version_at, name)|
3224
raw_text = raw
3325

3426
if pn == 1 && target.topic_embed&.embed_content_cache.present?
3527
raw_text = target.topic_embed&.embed_content_cache
3628
end
3729

38-
memo << { poster: username, id: pn, text: raw_text, last_version_at: last_version_at }
30+
display_name = name.presence || username
31+
32+
memo << {
33+
poster: display_name,
34+
id: pn,
35+
text: raw_text,
36+
last_version_at: last_version_at,
37+
}
3938
end
4039
end
4140

0 commit comments

Comments
 (0)