FIX: forced tools wasn't set correctly when tool has no options.

Author: romanrizzi

assets/javascripts/discourse/admin/models/ai-persona.js

@@ -77,7 +77,11 @@ export default class AiPersona extends RestModel {
 
   flattenedToolStructure(data) {
     return (data.tools || []).map((tName) => {
-      return [tName, data.toolOptions[tName], data.forcedTools.includes(tName)];
+      return [
+        tName,
+        data.toolOptions[tName] || {},
+        data.forcedTools.includes(tName),
+      ];
     });
   }
 
@@ -138,6 +142,8 @@ export default class AiPersona extends RestModel {
     const dataClone = JSON.parse(JSON.stringify(data));
 
     const persona = AiPersona.create(dataClone);
+
+    debugger;
     persona.tools = this.flattenedToolStructure(dataClone);
 
     return persona;

spec/system/admin_ai_persona_spec.rb

@@ -27,10 +27,12 @@
     tool_selector = PageObjects::Components::SelectKit.new("#control-tools .select-kit")
     tool_selector.expand
     tool_selector.select_row_by_value("Read")
+    tool_selector.select_row_by_value("ListCategories")
     tool_selector.collapse
 
     tool_selector = PageObjects::Components::SelectKit.new("#control-forcedTools .select-kit")
     tool_selector.expand
+    tool_selector.select_row_by_value("ListCategories")
     tool_selector.select_row_by_value("Read")
     tool_selector.collapse
 
@@ -46,8 +48,10 @@
     expect(persona.name).to eq("Test Persona")
     expect(persona.description).to eq("I am a test persona")
     expect(persona.system_prompt).to eq("You are a helpful bot")
-    expect(persona.tools).to eq([["Read", { "read_private" => nil }, true]])
     expect(persona.forced_tool_count).to eq(1)
+
+    expected_tools = [["Read", { "read_private" => nil }, true], ["ListCategories", {}, true]]
+    expect(persona.tools).to contain_exactly(*expected_tools)
   end
 
   it "will not allow deletion or editing of system personas" do