Use new AiPersona's feature method

Author: romanrizzi

app/controllers/discourse_ai/admin/ai_personas_controller.rb

@@ -8,19 +8,11 @@ class AiPersonasController < ::Admin::AdminController
       before_action :find_ai_persona, only: %i[edit update destroy create_user]
 
       def index
-        features_by_persona_id = DiscourseAi::Features.features.group_by { |f| f[:persona]&.id }
-
         ai_personas =
           AiPersona
             .ordered
             .includes(:user, :uploads)
-            .map do |persona|
-              LocalizedAiPersonaSerializer.new(
-                persona,
-                root: false,
-                features_by_persona_id: features_by_persona_id,
-              )
-            end
+            .map { |persona| LocalizedAiPersonaSerializer.new(persona, root: false) }
 
         tools =
           DiscourseAi::Personas::Persona.all_available_tools.map do |tool|

app/serializers/localized_ai_persona_serializer.rb

@@ -3,11 +3,6 @@
 class LocalizedAiPersonaSerializer < ApplicationSerializer
   root "ai_persona"
 
-  def initialize(object, options = {})
-    @features_by_persona_id = options.delete(:features_by_persona_id)
-    super(object, options)
-  end
-
   attributes :id,
              :name,
              :description,
@@ -59,4 +54,8 @@ def description
   def default_llm
     LlmModel.find_by(id: object.default_llm_id)
   end
+
+  def features
+    object.features.map { |feature| { id: feature.module_id, name: feature.module_name } }
+  end
 end

assets/javascripts/discourse/components/ai-persona-list-editor.gjs

@@ -98,7 +98,10 @@ export default class AiPersonaListEditor extends Component {
         value: "all",
         label: i18n("discourse_ai.ai_persona.filters.all_features"),
       },
-      ...features.map((name) => ({ value: name, label: name })),
+      ...features.map((name) => ({
+        value: name,
+        label: i18n(`discourse_ai.features.${name}.name`),
+      })),
     ];
   }
 
@@ -275,7 +278,9 @@ export default class AiPersonaListEditor extends Component {
                     {{#each persona.features as |feature|}}
                       <DButton
                         class="btn-flat btn-small ai-persona-list__row-item-feature"
-                        @translatedLabel={{feature.name}}
+                        @translatedLabel={{i18n
+                          (concat "discourse_ai.features." feature.name ".name")
+                        }}
                         @route="adminPlugins.show.discourse-ai-features.edit"
                         @routeModels={{feature.id}}
                       />