FIX: rest of specs

Author: keegangeorge

lib/configuration/llm_enumerator.rb

@@ -87,12 +87,8 @@ def self.global_usage
             )
             .each do |model_text, name, id|
               next if model_text.blank?
-              model_id = model_text.split("custom:").last.to_i
-              if model_id.present?
-                if model_text =~ /custom:(\d+)/
-                  rval[model_id] << { type: :automation, name: name, id: id }
-                end
-              end
+              model_id = model_text.to_i
+              rval[model_id] << { type: :automation, name: name, id: id } if model_id.present?
             end
         end
 

lib/configuration/llm_validator.rb

@@ -31,11 +31,6 @@ def valid_value?(val)
       end
 
       def run_test(val)
-        if Rails.env.test?
-          # In test mode, we assume the model is reachable.
-          return true
-        end
-
         DiscourseAi::Completions::Llm
           .proxy(val)
           .generate("How much is 1 + 1?", user: nil, feature_name: "llm_validator")

spec/configuration/llm_enumerator_spec.rb

@@ -2,6 +2,7 @@
 
 RSpec.describe DiscourseAi::Configuration::LlmEnumerator do
   fab!(:fake_model)
+  fab!(:ai_persona) { Fabricate(:ai_persona, default_llm_id: fake_model.id) }
   fab!(:llm_model)
   fab!(:seeded_model)
   fab!(:automation) do
@@ -42,24 +43,32 @@
   describe "#global_usage" do
     it "returns a hash of Llm models in use globally" do
       assign_fake_provider_to(:ai_default_llm_model)
+      SiteSetting.ai_helper_proofreader_persona = ai_persona.id
       SiteSetting.ai_helper_enabled = true
-      expect(described_class.global_usage).to eq(fake_model.id => [{ type: :ai_helper }])
+      expect(described_class.global_usage).to eq(
+        fake_model.id => [{ type: :ai_helper }],
+        fake_model.id => [
+          { id: ai_persona.id, name: ai_persona.name, type: :ai_persona },
+          { name: "Proofread text", type: :ai_helper },
+        ],
+      )
     end
 
     it "returns information about automation rules" do
       automation.fields.create!(
         component: "text",
         name: "model",
         metadata: {
-          value: fake_model.id,
+          value: llm_model.id,
         },
         target: "script",
       )
 
       usage = described_class.global_usage
 
       expect(usage).to eq(
-        { fake_model.id => [{ type: :automation, name: "some automation", id: automation.id }] },
+        fake_model.id => [{ id: ai_persona.id, name: ai_persona.name, type: :ai_persona }],
+        llm_model.id => [{ id: automation.id, name: automation.name, type: :automation }],
       )
     end
   end

spec/lib/completions/endpoints/nova_spec.rb

@@ -28,7 +28,7 @@ def encode_message(message)
   end
 
   it "should be able to make a simple request" do
-    proxy = DiscourseAi::Completions::Llm.proxy(model)
+    proxy = DiscourseAi::Completions::Llm.proxy(nova_model)
 
     content = {
       "output" => {
@@ -90,7 +90,7 @@ def encode_message(message)
 
     stub_request(:post, stream_url).to_return(status: 200, body: messages.join)
 
-    proxy = DiscourseAi::Completions::Llm.proxy(model)
+    proxy = DiscourseAi::Completions::Llm.proxy(nova_model)
     responses = []
     proxy.generate("Hello!", user: user) { |partial| responses << partial }
 
@@ -104,7 +104,7 @@ def encode_message(message)
     #model.provider_params["disable_native_tools"] = true
     #model.save!
 
-    proxy = DiscourseAi::Completions::Llm.proxy(model)
+    proxy = DiscourseAi::Completions::Llm.proxy(nova_model)
     prompt =
       DiscourseAi::Completions::Prompt.new(
         "You are a helpful assistant.",

spec/requests/admin/ai_llms_controller_spec.rb

@@ -473,16 +473,16 @@
           error_type: "validation",
         }
 
-        WebMock.stub_request(:post, test_attrs[:url]).to_return(
-          status: 422,
-          body: error_message.to_json,
-        )
+        error =
+          DiscourseAi::Completions::Endpoints::Base::CompletionFailed.new(error_message.to_json)
 
-        get "/admin/plugins/discourse-ai/ai-llms/test.json", params: { ai_llm: test_attrs }
+        DiscourseAi::Completions::Llm.with_prepared_responses([error]) do
+          get "/admin/plugins/discourse-ai/ai-llms/test.json", params: { ai_llm: test_attrs }
 
-        expect(response).to be_successful
-        expect(response.parsed_body["success"]).to eq(false)
-        expect(response.parsed_body["error"]).to eq(error_message.to_json)
+          expect(response).to be_successful
+          expect(response.parsed_body["success"]).to eq(false)
+          expect(response.parsed_body["error"]).to eq(error_message.to_json)
+        end
       end
     end
   end

spec/services/problem_check/ai_llm_status_spec.rb

@@ -6,6 +6,7 @@
   subject(:check) { described_class.new }
 
   fab!(:llm_model)
+  fab!(:ai_persona) { Fabricate(:ai_persona, default_llm_id: llm_model.id) }
 
   let(:post_url) { "https://api.openai.com/v1/chat/completions" }
   let(:success_response) do
@@ -27,6 +28,7 @@
   before do
     stub_request(:post, post_url).to_return(status: 200, body: success_response, headers: {})
     assign_fake_provider_to(:ai_default_llm_model)
+    SiteSetting.ai_summarization_persona = ai_persona.id
     SiteSetting.ai_summarization_enabled = true
   end