Refactor the constructor of the AiPersonaSelector to split the logic into smaller chunks

Author: megothss

assets/javascripts/discourse/components/ai-persona-llm-selector.gjs

@@ -20,38 +20,8 @@ export default class AiPersonaLlmSelector extends Component {
     super(...arguments);
 
     if (this.botOptions?.length) {
-      let personaId = this.keyValueStore.getItem(PERSONA_SELECTOR_KEY);
-
-      this._value = this.botOptions[0].id;
-      if (personaId) {
-        personaId = parseInt(personaId, 10);
-        if (this.botOptions.any((bot) => bot.id === personaId)) {
-          this._value = personaId;
-        }
-      }
-
-      this.args.setPersonaId(this._value);
-      this.setAllowLLMSelector();
-
-      if (this.hasLlmSelector) {
-        let llm = this.keyValueStore.getItem(LLM_SELECTOR_KEY);
-
-        const llmOption =
-          this.llmOptions.find((innerLlmOption) => innerLlmOption.id === llm) ||
-          this.llmOptions[0];
-
-        if (llmOption) {
-          llm = llmOption.id;
-        } else {
-          llm = "";
-        }
-
-        if (llm) {
-          next(() => {
-            this.currentLlm = llm;
-          });
-        }
-      }
+      this.#loadStoredPersona();
+      this.#loadStoredLlm();
 
       next(() => {
         this.resetTargetRecipients();
@@ -160,6 +130,44 @@ export default class AiPersonaLlmSelector extends Component {
     return this.allowLLMSelector && this.llmOptions.length > 1;
   }
 
+  #loadStoredPersona() {
+    let personaId = this.keyValueStore.getItem(PERSONA_SELECTOR_KEY);
+
+    this._value = this.botOptions[0].id;
+    if (personaId) {
+      personaId = parseInt(personaId, 10);
+      if (this.botOptions.any((bot) => bot.id === personaId)) {
+        this._value = personaId;
+      }
+    }
+
+    this.args.setPersonaId(this._value);
+  }
+
+  #loadStoredLlm() {
+    this.setAllowLLMSelector();
+
+    if (this.hasLlmSelector) {
+      let llm = this.keyValueStore.getItem(LLM_SELECTOR_KEY);
+
+      const llmOption =
+        this.llmOptions.find((innerLlmOption) => innerLlmOption.id === llm) ||
+        this.llmOptions[0];
+
+      if (llmOption) {
+        llm = llmOption.id;
+      } else {
+        llm = "";
+      }
+
+      if (llm) {
+        next(() => {
+          this.currentLlm = llm;
+        });
+      }
+    }
+  }
+
   <template>
     <div class="persona-llm-selector">
       <div class="persona-llm-selector__selection-wrapper gpt-persona">