Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Commit cd3fd8a

Browse files
xfalcoxxfalcox
committed
linter
1 parent 016f8be commit cd3fd8a

File tree

1 file changed

+48
-32
lines changed

1 file changed

+48
-32
lines changed

‎spec/jobs/scheduled/generate_concepts_from_popular_items_spec.rb‎

Lines changed: 48 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,12 @@
2020
it "does nothing when inferred_concepts_enabled is false" do
2121
SiteSetting.inferred_concepts_enabled = false
2222

23-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).not_to receive(:find_candidate_topics)
24-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).not_to receive(:find_candidate_posts)
23+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).not_to receive(
24+
:find_candidate_topics,
25+
)
26+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).not_to receive(
27+
:find_candidate_posts,
28+
)
2529
expect(Jobs).not_to receive(:enqueue)
2630

2731
subject.execute({})
@@ -31,7 +35,9 @@
3135
candidate_topics = [topic]
3236

3337
freeze_time do
34-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_topics).with(
38+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
39+
:find_candidate_topics,
40+
).with(
3541
limit: 20,
3642
min_posts: 5,
3743
min_likes: 10,
@@ -46,9 +52,9 @@
4652
batch_size: 10,
4753
)
4854

49-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_posts).and_return(
50-
[],
51-
)
55+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
56+
:find_candidate_posts,
57+
).and_return([])
5258

5359
subject.execute({})
5460
end
@@ -62,7 +68,9 @@
6268
:find_candidate_topics,
6369
).and_return([])
6470

65-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_posts).with(
71+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
72+
:find_candidate_posts,
73+
).with(
6674
limit: 30,
6775
min_likes: 5,
6876
exclude_first_posts: true,
@@ -86,12 +94,12 @@
8694
candidate_topics = [topic]
8795
candidate_posts = [post]
8896

89-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_topics).and_return(
90-
candidate_topics,
91-
)
92-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_posts).and_return(
93-
candidate_posts,
94-
)
97+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
98+
:find_candidate_topics,
99+
).and_return(candidate_topics)
100+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
101+
:find_candidate_posts,
102+
).and_return(candidate_posts)
95103

96104
# Expect generation jobs
97105
expect(Jobs).to receive(:enqueue).with(
@@ -131,12 +139,12 @@
131139
end
132140

133141
it "does not schedule jobs when no candidates found" do
134-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_topics).and_return(
135-
[],
136-
)
137-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_posts).and_return(
138-
[],
139-
)
142+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
143+
:find_candidate_topics,
144+
).and_return([])
145+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
146+
:find_candidate_posts,
147+
).and_return([])
140148

141149
expect(Jobs).not_to receive(:enqueue)
142150
expect(Jobs).not_to receive(:enqueue_in)
@@ -152,17 +160,19 @@
152160
SiteSetting.inferred_concepts_lookback_days = 45
153161

154162
freeze_time do
155-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_topics).with(
163+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
164+
:find_candidate_topics,
165+
).with(
156166
limit: 50,
157167
min_posts: 8,
158168
min_likes: 15,
159169
min_views: 200,
160170
created_after: 45.days.ago,
161171
).and_return([])
162172

163-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_posts).and_return(
164-
[],
165-
)
173+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
174+
:find_candidate_posts,
175+
).and_return([])
166176

167177
subject.execute({})
168178
end
@@ -178,7 +188,9 @@
178188
:find_candidate_topics,
179189
).and_return([])
180190

181-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_posts).with(
191+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
192+
:find_candidate_posts,
193+
).with(
182194
limit: 40,
183195
min_likes: 8,
184196
exclude_first_posts: true,
@@ -199,15 +211,19 @@
199211
# Keep lookback_days at default so .days.ago doesn't fail
200212

201213
freeze_time do
202-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_topics).with(
214+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
215+
:find_candidate_topics,
216+
).with(
203217
limit: 0, # nil becomes 0
204218
min_posts: 0, # nil becomes 0
205219
min_likes: 0, # nil becomes 0
206220
min_views: 0, # nil becomes 0
207221
created_after: 30.days.ago, # default from before block
208222
).and_return([])
209223

210-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_posts).with(
224+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
225+
:find_candidate_posts,
226+
).with(
211227
limit: 0, # nil becomes 0
212228
min_likes: 0, # nil becomes 0
213229
exclude_first_posts: true,
@@ -222,12 +238,12 @@
222238
candidate_topics = [topic]
223239
candidate_posts = [post]
224240

225-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_topics).and_return(
226-
candidate_topics,
227-
)
228-
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(:find_candidate_posts).and_return(
229-
candidate_posts,
230-
)
241+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
242+
:find_candidate_topics,
243+
).and_return(candidate_topics)
244+
expect_any_instance_of(DiscourseAi::InferredConcepts::Manager).to receive(
245+
:find_candidate_posts,
246+
).and_return(candidate_posts)
231247

232248
expect(Jobs).to receive(:enqueue).twice
233249

0 commit comments

Comments
 (0)