FIX: specs

Author: lis2

app/controllers/discourse_ai/admin/ai_llms_controller.rb

@@ -30,7 +30,10 @@ def index
                }
       end
 
-      def show
+      def new
+      end
+
+      def edit
         llm_model = LlmModel.find(params[:id])
         render json: LlmModelSerializer.new(llm_model)
       end

app/controllers/discourse_ai/admin/ai_personas_controller.rb

@@ -5,7 +5,7 @@ module Admin
     class AiPersonasController < ::Admin::AdminController
       requires_plugin ::DiscourseAi::PLUGIN_NAME
 
-      before_action :find_ai_persona, only: %i[show update destroy create_user]
+      before_action :find_ai_persona, only: %i[edit update destroy create_user]
 
       def index
         ai_personas =
@@ -33,7 +33,10 @@ def index
         render json: { ai_personas: ai_personas, meta: { tools: tools, llms: llms } }
       end
 
-      def show
+      def new
+      end
+
+      def edit
         render json: LocalizedAiPersonaSerializer.new(@ai_persona)
       end
 

app/controllers/discourse_ai/admin/ai_tools_controller.rb

@@ -5,14 +5,17 @@ module Admin
     class AiToolsController < ::Admin::AdminController
       requires_plugin ::DiscourseAi::PLUGIN_NAME
 
-      before_action :find_ai_tool, only: %i[test show update destroy]
+      before_action :find_ai_tool, only: %i[test edit update destroy]
 
       def index
         ai_tools = AiTool.all
         render_serialized({ ai_tools: ai_tools }, AiCustomToolListSerializer, root: false)
       end
 
-      def show
+      def new
+      end
+
+      def edit
         render_serialized(@ai_tool, AiCustomToolSerializer)
       end
 

config/routes.rb

@@ -53,15 +53,15 @@
 
   scope "/admin/plugins/discourse-ai", constraints: AdminConstraint.new do
     resources :ai_personas,
-              only: %i[index create show update destroy],
+              only: %i[index new create edit update destroy],
               path: "ai-personas",
               controller: "discourse_ai/admin/ai_personas"
 
     post "/ai-personas/stream-reply" => "discourse_ai/admin/ai_personas#stream_reply"
 
     resources(
       :ai_tools,
-      only: %i[index create show update destroy],
+      only: %i[index new create edit update destroy],
       path: "ai-tools",
       controller: "discourse_ai/admin/ai_tools",
     )
@@ -81,7 +81,7 @@
     get "/ai-usage", to: "discourse_ai/admin/ai_usage#show"
 
     resources :ai_llms,
-              only: %i[index create show update destroy],
+              only: %i[index new create edit update destroy],
               path: "ai-llms",
               controller: "discourse_ai/admin/ai_llms" do
       collection { get :test }

spec/requests/admin/ai_personas_controller_spec.rb

@@ -141,9 +141,9 @@
     end
   end
 
-  describe "GET #show" do
+  describe "GET #edit" do
     it "returns a success response" do
-      get "/admin/plugins/discourse-ai/ai-personas/#{ai_persona.id}.json"
+      get "/admin/plugins/discourse-ai/ai-personas/#{ai_persona.id}/edit.json"
       expect(response).to be_successful
       expect(response.parsed_body["ai_persona"]["name"]).to eq(ai_persona.name)
     end
@@ -152,7 +152,7 @@
       upload = Fabricate(:upload)
       RagDocumentFragment.link_target_and_uploads(ai_persona, [upload.id])
 
-      get "/admin/plugins/discourse-ai/ai-personas/#{ai_persona.id}.json"
+      get "/admin/plugins/discourse-ai/ai-personas/#{ai_persona.id}/edit.json"
       expect(response).to be_successful
 
       serialized_persona = response.parsed_body["ai_persona"]

spec/requests/admin/ai_tools_controller_spec.rb

@@ -35,9 +35,9 @@
     end
   end
 
-  describe "GET #show" do
+  describe "GET #edit" do
     it "returns a success response" do
-      get "/admin/plugins/discourse-ai/ai-tools/#{ai_tool.id}.json"
+      get "/admin/plugins/discourse-ai/ai-tools/#{ai_tool.id}/edit.json"
       expect(response).to be_successful
       expect(response.parsed_body["ai_tool"]["name"]).to eq(ai_tool.name)
     end

spec/system/admin_ai_persona_spec.rb

@@ -42,7 +42,7 @@
 
     expect(page).not_to have_current_path("/admin/plugins/discourse-ai/ai-personas/new")
 
-    persona_id = page.current_path.split("/").last.to_i
+    persona_id = page.current_path.split("/")[-2].to_i
 
     persona = AiPersona.find(persona_id)
     expect(persona.name).to eq("Test Persona")
@@ -53,15 +53,15 @@
   end
 
   it "will not allow deletion or editing of system personas" do
-    visit "/admin/plugins/discourse-ai/ai-personas/#{DiscourseAi::AiBot::Personas::Persona.system_personas.values.first}"
+    visit "/admin/plugins/discourse-ai/ai-personas/#{DiscourseAi::AiBot::Personas::Persona.system_personas.values.first}/edit"
     expect(page).not_to have_selector(".ai-persona-editor__delete")
     expect(find(".ai-persona-editor__system_prompt")).to be_disabled
   end
 
   it "will enable persona right away when you click on enable but does not save side effects" do
     persona = Fabricate(:ai_persona, enabled: false)
 
-    visit "/admin/plugins/discourse-ai/ai-personas/#{persona.id}"
+    visit "/admin/plugins/discourse-ai/ai-personas/#{persona.id}/edit"
 
     find(".ai-persona-editor__name").set("Test Persona 1")
     PageObjects::Components::DToggleSwitch.new(".ai-persona-editor__enabled").toggle

spec/system/ai_bot/tool_spec.rb

@@ -61,7 +61,7 @@ def ensure_can_run_test
     expect(page).to have_content("Tool saved")
 
     last_tool = AiTool.order("id desc").limit(1).first
-    visit "/admin/plugins/discourse-ai/ai-tools/#{last_tool.id}"
+    visit "/admin/plugins/discourse-ai/ai-tools/#{last_tool.id}/edit"
 
     ensure_can_run_test