Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Commit ceac6e5

Browse files
authored
FIX: Embeddings validator test needs to use the new Vector class. (#1041)
1 parent bdb8f1d commit ceac6e5

File tree

2 files changed

+19
-5
lines changed

2 files changed

+19
-5
lines changed

lib/configuration/embeddings_model_validator.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,8 @@ def error_message
3535
end
3636

3737
def can_generate_embeddings?(val)
38-
DiscourseAi::Embeddings::VectorRepresentations::Base
39-
.find_representation(val)
40-
.new(DiscourseAi::Embeddings::Strategies::Truncation.new)
41-
.vector_from("this is a test")
42-
.present?
38+
vdef = DiscourseAi::Embeddings::VectorRepresentations::Base.find_representation(val).new
39+
DiscourseAi::Embeddings::Vector.new(vdef).vector_from("this is a test").present?
4340
end
4441
end
4542
end
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# frozen_string_literal: true
2+
3+
require_relative "../support/embeddings_generation_stubs"
4+
5+
RSpec.describe DiscourseAi::Configuration::EmbeddingsModelValidator do
6+
before { SiteSetting.ai_embeddings_discourse_service_api_endpoint = "http://test.com" }
7+
8+
describe "#can_generate_embeddings?" do
9+
it "works" do
10+
discourse_model = "all-mpnet-base-v2"
11+
12+
EmbeddingsGenerationStubs.discourse_service(discourse_model, "this is a test", [1] * 1024)
13+
14+
expect(subject.can_generate_embeddings?(discourse_model)).to eq(true)
15+
end
16+
end
17+
end

0 commit comments

Comments
 (0)