DEV: Move title suggestion to an array

Author: xfalcox

lib/ai_helper/assistant.rb

@@ -130,12 +130,18 @@ def generate_prompt(
 
         buffer_blk =
           Proc.new do |partial, _, type|
+            json_summary_schema_key = bot.persona.response_format&.first.to_h
+
+            helper_response = [] if json_summary_schema_key["type"] == "array"
+
             if type == :structured_output
-              json_summary_schema_key = bot.persona.response_format&.first.to_h
               helper_chunk = partial.read_buffered_property(json_summary_schema_key["key"]&.to_sym)
-
               if !helper_chunk.nil? && !helper_chunk.empty?
-                helper_response << helper_chunk
+                if json_summary_schema_key["type"] != "array"
+                  helper_response = helper_chunk
+                else
+                  helper_response << helper_chunk
+                end
                 block.call(helper_chunk) if block
               end
             elsif type.blank?
@@ -169,7 +175,7 @@ def generate_and_send_prompt(
 
         result[:suggestions] = (
           if result[:type] == :list
-            parse_list(helper_response).map { |suggestion| sanitize_result(suggestion) }
+            helper_response.flatten.map { |suggestion| sanitize_result(suggestion) }
           else
             sanitized = sanitize_result(helper_response)
             result[:diff] = parse_diff(input, sanitized) if result[:type] == :diff
@@ -436,10 +442,6 @@ def parse_diff(text, suggestion)
 
         DiscourseDiff.new(cooked_text, cooked_suggestion).inline_html
       end
-
-      def parse_list(list)
-        Nokogiri::HTML5.fragment(list).css("item").map(&:text)
-      end
     end
   end
 end

lib/personas/titles_generator.rb

@@ -18,19 +18,42 @@ def system_prompt
           can have a capital letter, and acronyms like LLM can use capital letters. Format some titles
           as questions, some as statements. Make sure to use question marks if the title is a question.
           You will find the text between <input></input> XML tags.
-          Wrap each title between <item></item> XML tags.
+
+          The title suggestions should be returned in a JSON array, under the `output` key, like this:
+
+          {
+            "output": [
+              "suggeested title #1",
+              "suggeested title #2",
+              "suggeested title #3",
+              "suggeested title #4",
+              "suggeested title #5"
+            ]
+          }
+
+          Return only the JSON
         PROMPT
       end
 
       def response_format
-        [{ "key" => "output", "type" => "string" }]
+        [{ "key" => "output", "type" => "array", "array_type" => "string" }]
       end
 
       def examples
         [
           [
             "<input>In the labyrinth of time, a solitary horse, etched in gold by the setting sun, embarked on an infinite journey.</input>",
-            "<item>The solitary horse</item><item>The horse etched in gold</item><item>A horse's infinite journey</item><item>A horse lost in time</item><item>A horse's last ride</item>",
+            <<~OUTPUT,
+            {
+              "output": [
+                "The solitary horse",
+                "The horse etched in gold",
+                "A horse's infinite journey",
+                "A horse lost in time",
+                "A horse's last rid"
+              ]
+            }
+            OUTPUT
           ],
         ]
       end