more WIP

Author: SamSaffron

app/controllers/discourse_ai/admin/ai_spam_controller.rb

@@ -6,9 +6,8 @@ class AiSpamController < ::Admin::AdminController
       requires_plugin "discourse-ai"
 
       def show
-        render json: { work: "in progress" }
+        render json: AiSpamSerializer.new({}, root: false)
       end
-
     end
   end
 end

app/models/llm_model.rb

@@ -51,7 +51,11 @@ def self.provider_params
   end
 
   def to_llm
-    DiscourseAi::Completions::Llm.proxy("custom:#{id}")
+    DiscourseAi::Completions::Llm.proxy(identifier)
+  end
+
+  def identifier
+    "custom:#{id}"
   end
 
   def toggle_companion_user

app/serializers/ai_spam_serializer.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+class AiSpamSerializer < ApplicationSerializer
+  attributes :is_enabled, :selected_llm, :custom_instructions, :available_llms, :stats
+
+  def is_enabled
+    # Read from your hidden setting
+    SiteSetting.ai_spam_detection_enabled
+  end
+
+  def selected_llm
+    SiteSetting.ai_spam_detection_model
+  end
+
+  def custom_instructions
+    SiteSetting.ai_spam_detection_custom_instructions
+  end
+
+  def available_llms
+    DiscourseAi::Configuration::LlmEnumerator.values.map do |hash|
+      { id: hash[:value], name: hash[:name] }
+    end
+  end
+
+  def stats
+    {
+      scanned_count: 1, # Replace with actual stats
+      spam_detected: 2,
+      false_positives: 3,
+      false_negatives: 4,
+    }
+  end
+end

assets/javascripts/discourse/components/ai-spam.gjs

@@ -1,10 +1,9 @@
 import Component from "@glimmer/component";
 import { tracked } from "@glimmer/tracking";
-import { fn, hash } from "@ember/helper";
+import { fn } from "@ember/helper";
 import { on } from "@ember/modifier";
 import { action } from "@ember/object";
 import { service } from "@ember/service";
-import { not } from "truth-helpers";
 import DButton from "discourse/components/d-button";
 import DToggleSwitch from "discourse/components/d-toggle-switch";
 import DTooltip from "discourse/components/d-tooltip";
@@ -26,10 +25,19 @@ export default class AiSpam extends Component {
   @tracked isEnabled = false;
   @tracked selectedLLM = null;
   @tracked customInstructions = "";
-  @tracked isLoadingStats = false;
 
   constructor() {
     super(...arguments);
+    this.initializeFromModel();
+  }
+
+  @action
+  initializeFromModel() {
+    const model = this.args.model;
+    this.isEnabled = model.is_enabled;
+    this.selectedLLM = model.selected_llm;
+    this.customInstructions = model.custom_instructions;
+    this.stats = model.stats;
   }
 
   get availableLLMs() {
@@ -39,22 +47,6 @@ export default class AiSpam extends Component {
     }));
   }
 
-  @action
-  async loadStats() {
-    this.isLoadingStats = true;
-    try {
-      const response = await ajax("/admin/plugins/discourse-ai/ai-spam.json");
-      this.stats = response.stats;
-      this.isEnabled = response.is_enabled;
-      this.selectedLLM = response.selected_llm;
-      this.customInstructions = response.custom_instructions;
-    } catch (error) {
-      popupAjaxError(error);
-    } finally {
-      this.isLoadingStats = false;
-    }
-  }
-
   @action
   async toggleEnabled() {
     try {
@@ -73,15 +65,7 @@ export default class AiSpam extends Component {
 
   @action
   async updateLLM(value) {
-    try {
-      await ajax("/admin/plugins/discourse-ai/ai-spam/llm", {
-        type: "PUT",
-        data: { llm: value },
-      });
-      this.selectedLLM = value;
-    } catch (error) {
-      popupAjaxError(error);
-    }
+    this.selectedLLM = value;
   }
 
   @action
@@ -103,11 +87,17 @@ export default class AiSpam extends Component {
             "discourse_ai.spam.title"
           }}</h3>
 
-        <div class="ai-spam__toggle">
+        <div class="control-group ai-persona-editor__priority">
           <DToggleSwitch
+            class="ai-spam__toggle"
             @state={{this.enabled}}
+            @label="discourse_ai.spam.enable"
             {{on "click" this.toggleEnabled}}
           />
+          <DTooltip
+            @icon="question-circle"
+            @content={{i18n "discourse_ai.spam.spam_tip"}}
+          />
         </div>
 
         <div class="ai-spam__llm">
@@ -118,7 +108,6 @@ export default class AiSpam extends Component {
             @value={{this.selectedLLM}}
             @content={{this.availableLLMs}}
             @onChange={{this.updateLLM}}
-            @options={{hash disabled=(not this.isEnabled)}}
             class="ai-spam__llm-selector"
           />
         </div>
@@ -133,17 +122,17 @@ export default class AiSpam extends Component {
           </label>
           <textarea
             class="ai-spam__instructions-input"
+            placeholder={{i18n
+              "discourse_ai.spam.custom_instructions_placeholder"
+            }}
             {{on
               "input"
               (fn (mut this.customInstructions) value="target.value")
             }}
-            disabled={{not this.isEnabled}}
           >{{this.customInstructions}}</textarea>
           <DButton
             @action={{this.saveInstructions}}
-            @icon="save"
             @label="save"
-            @disabled={{not this.isEnabled}}
             class="ai-spam__instructions-save btn-primary"
           />
         </div>

config/locales/client.en.yml

@@ -140,6 +140,9 @@ en:
         reports: "Reports"
         view_false_positives: "View false positives"
         view_missed_spam: "View missed spam"
+        custom_instructions_placeholder: "Site-specific instructions for the AI to help identify spam more accurately."
+        enable: "Enable"
+        spam_tip: "AI spam detection will scan the first 3 posts by all new users on public topics. It will flag them for review and block users if they are likely spam."
 
       usage:
         short_title: "Usage"

config/settings.yml

@@ -25,7 +25,7 @@ discourse_ai:
   ai_sentiment_backfill_post_max_age_days:
     default: 60
     hidden: true
-  
+
 
   ai_openai_dall_e_3_url: "https://api.openai.com/v1/images/generations"
   ai_openai_embeddings_url: "https://api.openai.com/v1/embeddings"
@@ -321,3 +321,25 @@ discourse_ai:
     type: list
     list_type: compact
     default: ""
+
+  ai_spam_detection_enabled:
+    default: false
+    #validator: "DiscourseAi::Configuration::LlmDependencyValidator"
+    hidden: true
+
+  ai_spam_detection_model:
+    default: ""
+    type: enum
+    allow_any: false
+    enum: "DiscourseAi::Configuration::LlmEnumerator"
+    #validator: "DiscourseAi::Configuration::LlmValidator"
+    hidden: true
+
+  ai_spam_detection_custom_instructions:
+    default: ""
+    hidden: true
+
+  ai_spam_detection_model_allowed_seeded_models:
+    default: ""
+    hidden: true
+    type: list

spec/requests/admin/ai_spam_controller_spec.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.describe DiscourseAi::Admin::AiSpamController do
+  fab!(:admin) { Fabricate(:admin) }
+  fab!(:user) { Fabricate(:user) }
+
+  fab!(:llm_model)
+
+  describe "#show" do
+    context "when logged in as admin" do
+      before do
+        sign_in(admin)
+      end
+
+      it "returns the serialized spam settings" do
+        SiteSetting.ai_spam_detection_enabled = true
+        SiteSetting.ai_spam_detection_custom_instructions = "Be strict with spam"
+        SiteSetting.ai_spam_detection_model = llm_model.identifier
+
+        get "/admin/plugins/discourse-ai/ai-spam.json"
+
+        expect(response.status).to eq(200)
+
+        json = response.parsed_body
+        expect(json["is_enabled"]).to eq(true)
+        expect(json["selected_llm"]).to eq(llm_model.identifier)
+        expect(json["custom_instructions"]).to eq("Be strict with spam")
+        expect(json["available_llms"]).to be_an(Array)
+        expect(json["stats"]).to be_present
+      end
+
+      it "includes the correct stats structure" do
+        get "/admin/plugins/discourse-ai/ai-spam.json"
+
+        json = response.parsed_body
+        expect(json["stats"]).to include(
+          "scanned_count",
+          "spam_detected",
+          "false_positives",
+          "false_negatives"
+        )
+      end
+    end
+
+    context "when not logged in as admin" do
+      it "returns 404 for anonymous users" do
+        get "/admin/plugins/discourse-ai/ai-spam.json"
+        expect(response.status).to eq(404)
+      end
+
+      it "returns 404 for regular users" do
+        sign_in(user)
+        get "/admin/plugins/discourse-ai/ai-spam.json"
+        expect(response.status).to eq(404)
+      end
+    end
+
+    context "when plugin is disabled" do
+      before do
+        sign_in(admin)
+        SiteSetting.discourse_ai_enabled = false
+      end
+
+      it "returns 404" do
+        get "/admin/plugins/discourse-ai/ai-spam.json"
+        expect(response.status).to eq(404)
+      end
+    end
+  end
+end