move stuff around, show in enumerator

Author: SamSaffron

app/controllers/discourse_ai/admin/ai_spam_controller.rb

@@ -44,46 +44,7 @@ def spam_config
           settings: AiModerationSetting.spam,
         }
 
-        spam_status = [Reviewable.statuses[:approved], Reviewable.statuses[:deleted]]
-        ham_status = [Reviewable.statuses[:rejected], Reviewable.statuses[:ignored]]
-
-        # todo maybe move this to a report class
-        sql = <<~SQL
-          WITH spam_stats AS (
-            SELECT
-              asl.reviewable_id,
-              asl.post_id,
-              asl.is_spam,
-              r.status as reviewable_status,
-              r.target_type,
-              r.potential_spam
-            FROM ai_spam_logs asl
-            LEFT JOIN reviewables r ON r.id = asl.reviewable_id
-            WHERE asl.created_at > :date
-          ),
-          post_reviewables AS (
-            SELECT
-              target_id post_id,
-              COUNT(DISTINCT target_id) as false_negative_count
-            FROM reviewables
-            WHERE target_type = 'Post'
-              AND status IN (:spam)
-              AND potential_spam
-              AND target_id IN (SELECT post_id FROM spam_stats)
-            GROUP BY target_id
-          )
-          SELECT
-            COUNT(*) AS scanned_count,
-            SUM(CASE WHEN is_spam THEN 1 ELSE 0 END) AS spam_detected,
-            COUNT(CASE WHEN reviewable_status IN (:ham) THEN 1 END) AS false_positives,
-            COALESCE(SUM(pr.false_negative_count), 0) AS false_negatives
-          FROM spam_stats
-          LEFT JOIN post_reviewables pr USING (post_id)
-        SQL
-
-        stats = DB.query(sql, spam: spam_status, ham: ham_status, date: 1.week.ago).first
-
-        spam_config[:stats] = stats
+        spam_config[:stats] = DiscourseAi::AiModeration::SpamReport.generate(min_date: 1.week.ago)
         spam_config
       end
     end

config/locales/client.en.yml

@@ -307,6 +307,7 @@ en:
           ai_persona: "Persona (%{persona})"
           ai_summarization: "Summarize"
           ai_embeddings_semantic_search: "AI search"
+          ai_spam: "Spam"
         in_use_warning:
           one: "This model is currently used by %{settings}. If misconfigured, the feature won't work as expected."
           other: "This model is currently used by the following: %{settings}. If misconfigured, features won't work as expected. "

lib/ai_moderation/spam_report.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module DiscourseAi
+  module AiModeration
+    class SpamReport
+      def self.generate(min_date: 1.week.ago)
+        spam_status = [Reviewable.statuses[:approved], Reviewable.statuses[:deleted]]
+        ham_status = [Reviewable.statuses[:rejected], Reviewable.statuses[:ignored]]
+
+        sql = <<~SQL
+          WITH spam_stats AS (
+            SELECT
+              asl.reviewable_id,
+              asl.post_id,
+              asl.is_spam,
+              r.status as reviewable_status,
+              r.target_type,
+              r.potential_spam
+            FROM ai_spam_logs asl
+            LEFT JOIN reviewables r ON r.id = asl.reviewable_id
+            WHERE asl.created_at > :min_date
+          ),
+          post_reviewables AS (
+            SELECT
+              target_id post_id,
+              COUNT(DISTINCT target_id) as false_negative_count
+            FROM reviewables
+            WHERE target_type = 'Post'
+              AND status IN (:spam)
+              AND potential_spam
+              AND target_id IN (SELECT post_id FROM spam_stats)
+            GROUP BY target_id
+          )
+          SELECT
+            COUNT(*) AS scanned_count,
+            SUM(CASE WHEN is_spam THEN 1 ELSE 0 END) AS spam_detected,
+            COUNT(CASE WHEN reviewable_status IN (:ham) THEN 1 END) AS false_positives,
+            COALESCE(SUM(pr.false_negative_count), 0) AS false_negatives
+          FROM spam_stats
+          LEFT JOIN post_reviewables pr USING (post_id)
+        SQL
+
+        DB.query(sql, spam: spam_status, ham: ham_status, min_date: min_date).first
+      end
+    end
+  end
+end

lib/ai_moderation/spam_scanner.rb

@@ -52,6 +52,8 @@ def self.flagging_user
       end
 
       def self.after_cooked_post(post)
+        return if !enabled?
+        return if !should_scan_post(post)
         return if !post.custom_fields[SHOULD_SCAN_POST_CUSTOM_FIELD]
         return if post.updated_at < MAX_AGE_TO_SCAN.ago
 

lib/configuration/llm_enumerator.rb

@@ -38,6 +38,11 @@ def self.global_usage
           rval[model_id] << { type: :ai_embeddings_semantic_search }
         end
 
+        if SiteSetting.ai_spam_detection_enabled
+          model_id = AiModerationSetting.spam[:llm_model_id]
+          rval[model_id] << { type: :ai_spam }
+        end
+
         rval
       end