DEV: Fix specs and lint

Author: martin-brennan

assets/javascripts/discourse/components/ai-llms-list-editor.gjs

@@ -4,7 +4,6 @@ import { action } from "@ember/object";
 import { LinkTo } from "@ember/routing";
 import { service } from "@ember/service";
 import DBreadcrumbsItem from "discourse/components/d-breadcrumbs-item";
-import icon from "discourse-common/helpers/d-icon";
 import i18n from "discourse-common/helpers/i18n";
 import I18n from "discourse-i18n";
 import AdminPageSubheader from "admin/components/admin-page-subheader";
@@ -142,9 +141,6 @@ export default class AiLlmsListEditor extends Component {
                     class="ai-llm-list__row d-admin-row__content"
                   >
                     <td class="d-admin-row__overview">
-                      <div class="d-admin-row__mobile-label">
-                        {{i18n "discourse_ai.llms.display_name"}}
-                      </div>
                       <h3>{{llm.display_name}}</h3>
                       <p>
                         {{this.modelDescription llm}}
@@ -168,7 +164,7 @@ export default class AiLlmsListEditor extends Component {
                     <td class="d-admin-row__controls">
                       <LinkTo
                         @route="adminPlugins.show.discourse-ai-llms.show"
-                        class="btn btn-default btn-small"
+                        class="btn btn-default btn-small ai-llm-list__edit-button"
                         @model={{llm.id}}
                       >
                         <div class="d-button-label">

assets/javascripts/discourse/components/ai-persona-list-editor.gjs

@@ -1,6 +1,4 @@
 import Component from "@glimmer/component";
-import AdminConfigAreaEmptyList from "admin/components/admin-config-area-empty-list";
-import { tracked } from "@glimmer/tracking";
 import { fn } from "@ember/helper";
 import { on } from "@ember/modifier";
 import { action } from "@ember/object";
@@ -10,9 +8,8 @@ import DBreadcrumbsItem from "discourse/components/d-breadcrumbs-item";
 import DToggleSwitch from "discourse/components/d-toggle-switch";
 import concatClass from "discourse/helpers/concat-class";
 import { popupAjaxError } from "discourse/lib/ajax-error";
-import { cook } from "discourse/lib/text";
 import i18n from "discourse-common/helpers/i18n";
-import I18n from "discourse-i18n";
+import AdminConfigAreaEmptyList from "admin/components/admin-config-area-empty-list";
 import AdminPageSubheader from "admin/components/admin-page-subheader";
 import AiPersonaEditor from "./ai-persona-editor";
 
@@ -108,7 +105,7 @@ export default class AiPersonaListEditor extends Component {
           <AdminConfigAreaEmptyList
             @ctaLabel="discourse_ai.ai_persona.new"
             @ctaRoute="adminPlugins.show.discourse-ai-personas.new"
-            @ctaClass="ai-persona-list-editor__new-button"
+            @ctaClass="ai-persona-list-editor__empty-new-button"
             @emptyLabel="discourse_ai.ai_persona.no_personas"
           />
         {{/if}}

assets/javascripts/discourse/components/ai-tool-list-editor.gjs

@@ -1,10 +1,10 @@
 import Component from "@glimmer/component";
-import AdminConfigAreaEmptyList from "admin/components/admin-config-area-empty-list";
 import { LinkTo } from "@ember/routing";
 import { service } from "@ember/service";
 import DBreadcrumbsItem from "discourse/components/d-breadcrumbs-item";
 import i18n from "discourse-common/helpers/i18n";
 import I18n from "discourse-i18n";
+import AdminConfigAreaEmptyList from "admin/components/admin-config-area-empty-list";
 import AdminPageSubheader from "admin/components/admin-page-subheader";
 
 export default class AiToolListEditor extends Component {
@@ -45,9 +45,6 @@ export default class AiToolListEditor extends Component {
               >
                 <td class="d-admin-row__overview">
                   <div class="ai-tool-list__name-with-description">
-                    <div class="d-admin-row__mobile-label">
-                      {{i18n "discourse_ai.tools.name"}}
-                    </div>
                     <div class="ai-tool-list__name">
                       <strong>
                         {{tool.name}}
@@ -73,7 +70,7 @@ export default class AiToolListEditor extends Component {
         <AdminConfigAreaEmptyList
           @ctaLabel="discourse_ai.tools.new"
           @ctaRoute="adminPlugins.show.discourse-ai-tools.new"
-          @ctaClass="ai-tool-list-editor__new-button"
+          @ctaClass="ai-tool-list-editor__empty-new-button"
           @emptyLabel="discourse_ai.tools.no_tools"
         />
       {{/if}}

spec/system/admin_ai_persona_spec.rb

@@ -11,7 +11,7 @@
 
   it "allows creation of a persona" do
     visit "/admin/plugins/discourse-ai/ai-personas"
-    find(".ai-persona-list-editor__header .btn-primary").click()
+    find(".ai-persona-list-editor__new-button").click()
     find(".ai-persona-editor__name").set("Test Persona")
     find(".ai-persona-editor__description").fill_in(with: "I am a test persona")
     find(".ai-persona-editor__system_prompt").fill_in(with: "You are a helpful bot")

spec/system/llms/ai_llm_spec.rb

@@ -76,14 +76,14 @@
     it "shows the provider as CDCK in the UI" do
       visit "/admin/plugins/discourse-ai/ai-llms"
       expect(page).to have_css(
-        "[data-llm-id='cdck-hosted'] .column-provider",
+        "[data-llm-id='cdck-hosted']",
         text: I18n.t("js.discourse_ai.llms.providers.CDCK"),
       )
     end
 
     it "shows an info alert to the user about the seeded LLM" do
       visit "/admin/plugins/discourse-ai/ai-llms"
-      find("[data-llm-id='#{llm_model.name}'] .column-edit .btn").click()
+      find("[data-llm-id='#{llm_model.name}'] .ai-llm-list__edit-button").click()
       expect(page).to have_css(
         ".alert.alert-info",
         text: I18n.t("js.discourse_ai.llms.seeded_warning"),
@@ -92,7 +92,7 @@
 
     it "limits and shows disabled inputs for the seeded LLM" do
       visit "/admin/plugins/discourse-ai/ai-llms"
-      find("[data-llm-id='cdck-hosted'] .column-edit .btn").click()
+      find("[data-llm-id='cdck-hosted'] .ai-llm-list__edit-button").click()
       expect(page).to have_css(".ai-llm-editor__display-name[disabled]")
       expect(page).to have_css(".ai-llm-editor__name[disabled]")
       expect(page).to have_css(".ai-llm-editor__provider.is-disabled")