DEV: Update specs

Author: janzenisaac

assets/javascripts/discourse/components/ai-bot-sidebar-new-conversation.gjs

@@ -6,6 +6,7 @@ export default class AiBotSidebarNewConversation extends Component {
   @service router;
 
   get show() {
+    // don't show the new question button on the conversations home page
     return this.router.currentRouteName !== "discourse-ai-bot-conversations";
   }
 

assets/javascripts/discourse/services/ai-bot-conversations-hidden-submit.js

@@ -33,10 +33,13 @@ export default class AiBotConversationsHiddenSubmit extends Service {
       });
     }
 
+    // borrowed from ai-bot-helper.js
+    const draftKey = "new_private_message_ai_" + new Date().getTime();
+
     // this is a total hack, the composer is hidden on the homepage with CSS
     await this.composer.open({
       action: Composer.PRIVATE_MESSAGE,
-      draftKey: "private_message_ai",
+      draftKey,
       recipients: this.currentUser.ai_enabled_personas[0].username,
       topicTitle: i18n("discourse_ai.ai_bot.default_pm_prefix"),
       topicBody: this.inputValue,

assets/javascripts/initializers/ai-bot-sidebar.js

@@ -56,10 +56,7 @@ export default {
                   this.isFetching = false;
                   this.buildSidebarLinks();
                 })
-                .catch((e) => {
-                  debugger;
-                  this.isFetching = false;
-                });
+                .catch(() => (this.isFetching = false));
             }
 
             addNewMessage(newTopic) {

spec/system/ai_bot/personal_message_spec.rb

@@ -7,39 +7,69 @@
   let(:sidebar) { PageObjects::Components::NavigationMenu::Sidebar.new }
   let(:header_dropdown) { PageObjects::Components::NavigationMenu::HeaderDropdown.new }
 
-  fab!(:user)
+
+  fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
   fab!(:group)
 
+  fab!(:claude_2) do
+    Fabricate(
+      :llm_model,
+      provider: "anthropic",
+      url: "https://api.anthropic.com/v1/messages",
+      name: "claude-2",
+    )
+  end
   fab!(:bot_user) do
-    user = Fabricate(:user)
-    AiPersona.last.update!(user_id: user.id)
-    user
+    toggle_enabled_bots(bots: [claude_2])
+    SiteSetting.ai_bot_enabled = true
+    claude_2.reload.user
+  end
+  fab!(:bot) do
+    persona =
+      AiPersona
+        .find(DiscourseAi::Personas::Persona.system_personas[DiscourseAi::Personas::General])
+        .class_instance
+        .new
+    DiscourseAi::Personas::Bot.as(bot_user, persona: persona)
   end
-  fab!(:llm_model) { Fabricate(:llm_model, enabled_chat_bot: true) }
 
-  fab!(:pm) { Fabricate(:private_message_topic, title: "AI Conversation Test", user: user) }
-  fab!(:reply) do
-    Fabricate(:post, topic: pm, user: user, post_number: 1, raw: "test test test user reply")
+  fab!(:pm) do
+    Fabricate(
+      :private_message_topic,
+      title: "This is my special PM",
+      user: user,
+      topic_allowed_users: [
+        Fabricate.build(:topic_allowed_user, user: user),
+        Fabricate.build(:topic_allowed_user, user: bot_user),
+      ],
+    )
+  end
+  fab!(:first_post) do
+    Fabricate(:post, topic: pm, user: user, post_number: 1, raw: "This is a reply by the user")
+  end
+  fab!(:second_post) do
+    Fabricate(:post, topic: pm, user: bot_user, post_number: 2, raw: "This is a bot reply")
   end
-  fab!(:bot_reply) do
-    Fabricate(:post, topic: pm, user: bot_user, post_number: 2, raw: "test test test bot reply")
+  fab!(:third_post) do
+    Fabricate(
+      :post,
+      topic: pm,
+      user: user,
+      post_number: 3,
+      raw: "This is a second reply by the user",
+    )
   end
   fab!(:topic_user) { Fabricate(:topic_user, topic: pm, user: user) }
   fab!(:topic_bot_user) { Fabricate(:topic_user, topic: pm, user: bot_user) }
 
   before do
     SiteSetting.ai_enable_experimental_bot_ux = true
     SiteSetting.ai_bot_enabled = true
-    toggle_enabled_bots(bots: [llm_model])
     SiteSetting.ai_bot_allowed_groups = group.id.to_s
-    sign_in(user)
 
     group.add(user)
     group.save
 
-    allowed_persona = AiPersona.last
-    allowed_persona.update!(allowed_group_ids: [group.id], enabled: true)
-
     sign_in(user)
   end
 
@@ -88,7 +118,32 @@
 
       expect(ai_pm_homepage).to have_homepage
       expect(sidebar).to have_section("custom-messages")
-      expect(sidebar).to have_section_link(pm.title, href: pm.relative_url)
+      expect(sidebar).to have_section_link(pm.title)
+      expect(sidebar).to have_no_css("button.ai-new-question-button")
+    end
+
+    it "navigates to the bot conversation when clicked" do
+      visit "/"
+      find(".ai-bot-button").click
+
+      expect(ai_pm_homepage).to have_homepage
+      sidebar.find(
+        ".sidebar-section[data-section-name='custom-messages'] a.sidebar-section-link",
+      ).click
+      expect(topic_page).to have_topic_title(pm.title)
+    end
+
+    it "displays sidebar and 'new question' on the topic page" do
+      topic_page.visit_topic(pm)
+      expect(sidebar).to be_visible
+      expect(sidebar).to have_css("button.ai-new-question-button")
+    end
+
+    it "redirect to the homepage when 'new question' is clicked" do
+      topic_page.visit_topic(pm)
+      expect(sidebar).to be_visible
+      sidebar.find("button.ai-new-question-button").click
+      expect(ai_pm_homepage).to have_homepage
     end
   end
 end