DEV: Apply feedback from review

Author: keegangeorge

db/migrate/20250710180401_copy_ai_summarization_model_to_persona_default.rb

@@ -8,11 +8,21 @@ def up
       # Extract the model ID from the setting value (e.g., "custom:-5" -> "-5")
       model_id = ai_summarization_model.split(":").last
 
-      # Update the summarization personas (IDs -11 and -12) with the extracted model ID
+      persona_settings = %w[ai_summarization_persona ai_summary_gists_persona]
+      default_persona_ids = [-11, -12]
+
+      persona_ids_query =
+        persona_settings
+          .map { |setting| "SELECT value FROM site_settings WHERE name = '#{setting}'" }
+          .join(" UNION ")
+      persona_ids = DB.query_single(persona_ids_query).compact
+      all_persona_ids = (default_persona_ids + persona_ids).map(&:to_i).uniq.join(",")
+
+      # Update the summarization personas with the extracted model ID
       execute(<<~SQL)
         UPDATE ai_personas
         SET default_llm_id = #{model_id}
-        WHERE id IN (-11, -12) AND default_llm_id IS NULL
+        WHERE id IN (#{all_persona_ids}) AND default_llm_id IS NULL
       SQL
     end
   end

db/migrate/20250710181656_copy_ai_helper_model_to_persona_default.rb

@@ -8,12 +8,32 @@ def up
       # Extract the model ID from the setting value (e.g., "custom:1" -> "1")
       model_id = ai_helper_model.split(":").last
 
+      # Get persona IDs from site settings
+      persona_settings = %w[
+        ai_helper_proofreader_persona
+        ai_helper_title_suggestions_persona
+        ai_helper_explain_persona
+        ai_helper_smart_dates_persona
+        ai_helper_translator_persona
+        ai_helper_markdown_tables_persona
+        ai_helper_custom_prompt_persona
+      ]
+
+      default_persona_ids = [-18, -19, -20, -22, -23, -24, -25]
+      persona_ids_query =
+        persona_settings
+          .map { |setting| "SELECT value FROM site_settings WHERE name = '#{setting}'" }
+          .join(" UNION ")
+      persona_ids = DB.query_single(persona_ids_query).compact
+
+      all_persona_ids = (default_persona_ids + persona_ids).map(&:to_i).uniq.join(",")
+
       # Update the helper personas with the extracted model ID
       execute(<<~SQL)
-        UPDATE ai_personas
-        SET default_llm_id = #{model_id}
-        WHERE id IN (-18, -19, -20, -21, -22, -23, -24, -25) AND default_llm_id IS NULL
-      SQL
+            UPDATE ai_personas
+            SET default_llm_id = #{model_id}
+            WHERE id IN (#{all_persona_ids}) AND default_llm_id IS NULL
+          SQL
     end
   end
 

db/migrate/20250710215720_copy_hyde_model_to_persona.rb

@@ -2,17 +2,29 @@
 class CopyHydeModelToPersona < ActiveRecord::Migration[7.2]
   def up
     hyde_model =
-      DB.query_single("SELECT value FROM site_settings WHERE name = 'ai_embeddings_semantic_search_hyde_model'").first
+      DB.query_single(
+        "SELECT value FROM site_settings WHERE name = 'ai_embeddings_semantic_search_hyde_model'",
+      ).first
 
     if hyde_model.present? && hyde_model.start_with?("custom:")
       # Extract the model ID from the setting value (e.g., "custom:1" -> "1")
       model_id = hyde_model.split(":").last
 
+      persona_settings = %w[ai_embeddings_semantic_search_hyde_persona]
+      default_persona_ids = [-32]
+      persona_ids_query =
+        persona_settings
+          .map { |setting| "SELECT value FROM site_settings WHERE name = '#{setting}'" }
+          .join(" UNION ")
+      persona_ids = DB.query_single(persona_ids_query).compact
+
+      all_persona_ids = (default_persona_ids + persona_ids).map(&:to_i).uniq.join(",")
+
       # Update the hyde persona with the extracted model ID
       execute(<<~SQL)
         UPDATE ai_personas
         SET default_llm_id = #{model_id}
-        WHERE id IN (-32) AND default_llm_id IS NULL
+        WHERE id IN (#{all_persona_ids}) AND default_llm_id IS NULL
       SQL
     end
   end

db/migrate/20250716005451_copy_translation_model_to_persona.rb

@@ -8,11 +8,27 @@ def up
       # Extract the model ID from the setting value (e.g., "custom:-5" -> "-5")
       model_id = ai_translation_model.split(":").last
 
+      persona_settings = %w[
+        ai_translation_locale_detector_persona
+        ai_translation_post_raw_translator_persona
+        ai_translation_topic_title_translator_persona
+        ai_translation_short_text_translator_persona
+      ]
+      default_persona_ids = [-27, -28, -29, -30]
+
+      persona_ids_query =
+        persona_settings
+          .map { |setting| "SELECT value FROM site_settings WHERE name = '#{setting}'" }
+          .join(" UNION ")
+      persona_ids = DB.query_single(persona_ids_query).compact
+
+      all_persona_ids = (default_persona_ids + persona_ids).map(&:to_i).uniq.join(",")
+
       # Update the translation personas (IDs -27, -28, -29, -30) with the extracted model ID
       execute(<<~SQL)
         UPDATE ai_personas
         SET default_llm_id = #{model_id}
-        WHERE id IN (-27, -28, -29, -30) AND default_llm_id IS NULL
+        WHERE id IN (#{all_persona_ids}) AND default_llm_id IS NULL
       SQL
     end
   end

db/migrate/20250716005855_copy_ai_image_caption_model_to_persona_default.rb

@@ -11,11 +11,22 @@ def up
       # Extract the model ID from the setting value (e.g., "custom:1" -> "1")
       model_id = ai_helper_image_caption_model.split(":").last
 
+      persona_settings = %w[ai_helper_post_illustrator_persona ai_helper_image_caption_persona,]
+      default_persona_ids = [-21, -26]
+
+      persona_ids_query =
+        persona_settings
+          .map { |setting| "SELECT value FROM site_settings WHERE name = '#{setting}'" }
+          .join(" UNION ")
+      persona_ids = DB.query_single(persona_ids_query).compact
+
+      all_persona_ids = (default_persona_ids + persona_ids).map(&:to_i).uniq.join(",")
+
       # Update the helper personas with the extracted model ID
       execute(<<~SQL)
         UPDATE ai_personas
         SET default_llm_id = #{model_id}
-        WHERE id IN (-26) AND default_llm_id IS NULL
+        WHERE id IN (#{all_persona_ids}) AND default_llm_id IS NULL
       SQL
     end
   end

lib/ai_helper/chat_thread_titler.rb

@@ -12,10 +12,14 @@ def suggested_title
         return nil if content.blank?
 
         suggested_title = call_llm(content)
+        return nil if suggested_title.blank?
+        
         cleanup(suggested_title)
       end
 
       def call_llm(thread_content)
+        return nil if SiteSetting.ai_default_llm_model.blank?
+        
         chat = "<input>\n#{thread_content}\n</input>"
 
         prompt =

lib/ai_helper/painter.rb

@@ -57,6 +57,12 @@ def base64_to_image(artifacts, user_id)
       end
 
       def diffusion_prompt(text, user)
+        llm_model =
+          AiPersona.find_by(id: SiteSetting.ai_helper_post_illustrator_persona)&.default_llm_id ||
+            SiteSetting.ai_default_llm_model
+
+        return nil if llm_model.blank?
+
         prompt =
           DiscourseAi::Completions::Prompt.new(
             <<~TEXT.strip,
@@ -66,7 +72,7 @@ def diffusion_prompt(text, user)
             messages: [{ type: :user, content: text, id: user.username }],
           )
 
-        DiscourseAi::Completions::Llm.proxy(SiteSetting.ai_default_llm_model).generate(
+        DiscourseAi::Completions::Llm.proxy(llm_model).generate(
           prompt,
           user: user,
           feature_name: "illustrate_post",

lib/translation.rb

@@ -3,11 +3,28 @@
 module DiscourseAi
   module Translation
     def self.enabled?
-      SiteSetting.discourse_ai_enabled && SiteSetting.ai_translation_enabled &&
-        SiteSetting.ai_default_llm_model.present? &&
+      SiteSetting.discourse_ai_enabled && SiteSetting.ai_translation_enabled && has_llm_model? &&
         SiteSetting.content_localization_supported_locales.present?
     end
 
+    def self.has_llm_model?
+      persona_ids = [
+        SiteSetting.ai_translation_locale_detector_persona,
+        SiteSetting.ai_translation_post_raw_translator_persona,
+        SiteSetting.ai_translation_topic_title_translator_persona,
+        SiteSetting.ai_translation_short_text_translator_persona,
+      ]
+
+      persona_default_llms = AiPersona.where(id: persona_ids).pluck(:default_llm_id)
+      default_llm_model = SiteSetting.ai_default_llm_model
+
+      if persona_default_llms.any?(&:blank?) && default_llm_model.blank?
+        false
+      else
+        true
+      end
+    end
+
     def self.backfill_enabled?
       enabled? && SiteSetting.ai_translation_backfill_hourly_rate > 0 &&
         SiteSetting.ai_translation_backfill_max_age_days > 0