fix tests, rename setting 6

xfalcox · xfalcox · commit fb9394b7c1eb · 2024-11-26T12:31:12.000-03:00
diff --git a/app/jobs/regular/fast_track_topic_gist.rb b/app/jobs/regular/fast_track_topic_gist.rb
@@ -7,7 +7,7 @@ class FastTrackTopicGist < ::Jobs::Base
     def execute(args)
       return if !SiteSetting.discourse_ai_enabled
       return if !SiteSetting.ai_summarization_enabled
-      return if SiteSetting.ai_summarize_max_topic_gists_per_batch.zero?
+      return if SiteSetting.ai_summary_gists_enabled
 
       topic = Topic.find_by(id: args[:topic_id])
       return if topic.blank?
diff --git a/config/locales/server.de.yml b/config/locales/server.de.yml
@@ -85,7 +85,7 @@ de:
     ai_summarization_model: "Modell, das für die Zusammenfassung verwendet werden soll."
     ai_custom_summarization_allowed_groups: "Gruppen, die neue Zusammenfassungen erstellen dürfen."
     ai_pm_summarization_allowed_groups: "Gruppen können Zusammenfassungen in PMs erstellen und ansehen."
-    ai_summarize_max_topic_gists_per_batch: "Nach der Aktualisierung der Themen in der angesagten Liste erstellen wir kurze Zusammenfassungen der ersten N Themen. (Deaktiviert, wenn 0)"
+    ai_summary_gists_enabled: "Nach der Aktualisierung der Themen in der angesagten Liste erstellen wir kurze Zusammenfassungen der ersten N Themen. (Deaktiviert, wenn 0)"
     ai_hot_topic_gists_allowed_groups: "Gruppen, die die wichtigsten Themen in der Liste der aktuellen Themen sehen dürfen."
     ai_summary_backfill_maximum_topics_per_hour: "Anzahl der Themenzusammenfassungen, die pro Stunde aufgefüllt werden müssen."
     ai_bot_enabled: "Aktiviere das KI-Bot-Modul."
diff --git a/config/locales/server.en.yml b/config/locales/server.en.yml
@@ -86,7 +86,7 @@ en:
     ai_summarization_model: "Model to use for summarization."
     ai_custom_summarization_allowed_groups: "Groups allowed to use create new summaries."
     ai_pm_summarization_allowed_groups: "Groups allowed to create and view summaries in PMs."
-    ai_summarize_max_topic_gists_per_batch: "After updating topics in the hot list, we'll generate brief summaries of the first N ones. (Disabled when 0)"
+    ai_summary_gists_enabled: "After updating topics in the hot list, we'll generate brief summaries of the first N ones. (Disabled when 0)"
     ai_hot_topic_gists_allowed_groups: "Groups allowed to see gists in the hot topics list."
     ai_summary_backfill_maximum_topics_per_hour: "Number of topic summaries to backfill per hour."
 
diff --git a/config/locales/server.he.yml b/config/locales/server.he.yml
@@ -84,7 +84,7 @@ he:
     ai_summarization_model: "מודל לשימוש לסיכום."
     ai_custom_summarization_allowed_groups: "קבוצות שמורשות להשתמש ליצירת סיכומים חדשים."
     ai_pm_summarization_allowed_groups: "קבוצות שמורשות ליצור ולצפות בתקצירים בהודעות פרטיות."
-    ai_summarize_max_topic_gists_per_batch: "לאחר עדכון הנושאים ברשימה החמה, נייצר תקצירים של N הראשונים. (0 להשבתה)"
+    ai_summary_gists_enabled: "לאחר עדכון הנושאים ברשימה החמה, נייצר תקצירים של N הראשונים. (0 להשבתה)"
     ai_hot_topic_gists_allowed_groups: "קבוצות שמורשות לראות gists ברשימת הנושאים החמים."
     ai_summary_backfill_maximum_topics_per_hour: "מספר תקצירי הנושאים למילוי חוזר בשעה."
     ai_bot_enabled: "הפעלת מודול בוט הבינה המלאכותית."
diff --git a/config/locales/server.uk.yml b/config/locales/server.uk.yml
@@ -84,7 +84,7 @@ uk:
     ai_summarization_model: "Модель для узагальнення."
     ai_custom_summarization_allowed_groups: "Групи, яким дозволено створювати нові зведення."
     ai_pm_summarization_allowed_groups: "Групи дозволили створювати та переглядати підсумки в особистих повідомленнях."
-    ai_summarize_max_topic_gists_per_batch: "Після оновлення тем у гарячому списку ми згенеруємо короткі підсумки перших N. (Вимкнено, коли 0)"
+    ai_summary_gists_enabled: "Після оновлення тем у гарячому списку ми згенеруємо короткі підсумки перших N. (Вимкнено, коли 0)"
     ai_hot_topic_gists_allowed_groups: "Групи, яким дозволено бачити суть у списку гарячих тем."
     ai_summary_backfill_maximum_topics_per_hour: "Кількість підсумків тем для заповнення на годину."
     ai_bot_enabled: "Увімкніть модуль AI Bot."
diff --git a/config/settings.yml b/config/settings.yml
@@ -364,12 +364,10 @@ discourse_ai:
     type: group_list
     list_type: compact
     default: "3|13" # 3: @staff, 13: @trust_level_3
-  ai_summarize_max_topic_gists_per_batch:
-    default: 0
-    min: 0
-    max: 1000
+  ai_summary_gists_enabled:
+    default: false
     hidden: true
-  ai_hot_topic_gists_allowed_groups:
+  ai_summary_gists_allowed_groups:
     type: group_list
     list_type: compact
     default: ""
diff --git a/db/migrate/20241126033812_rename_ai_gist_batch_setting.rb b/db/migrate/20241126033812_rename_ai_gist_batch_setting.rb
@@ -2,10 +2,10 @@
 
 class RenameAiGistBatchSetting < ActiveRecord::Migration[7.0]
   def up
-    execute "UPDATE site_settings SET name = 'ai_summarize_max_topic_gists_per_batch'  WHERE name = 'ai_summarize_max_hot_topics_gists_per_batch'"
+    execute "UPDATE site_settings SET name = 'ai_summary_gists_allowed_groups'  WHERE name = 'ai_hot_topic_gists_allowed_groups'"
   end
 
   def down
-    execute "UPDATE site_settings SET name = 'ai_summarize_max_hot_topics_gists_per_batch' WHERE name = 'ai_summarize_max_topic_gists_per_batch'"
+    execute "UPDATE site_settings SET name = 'ai_hot_topic_gists_allowed_groups' WHERE name = 'ai_summary_gists_allowed_groups'"
   end
 end
diff --git a/lib/guardian_extensions.rb b/lib/guardian_extensions.rb
@@ -23,7 +23,7 @@ def can_see_summary?(target)
 
     def can_see_gists?
       return false if !SiteSetting.ai_summarization_enabled
-      return false if SiteSetting.ai_summarize_max_topic_gists_per_batch.zero?
+      return false if SiteSetting.ai_summary_gists_enabled
       if SiteSetting.ai_hot_topic_gists_allowed_groups.to_s == Group::AUTO_GROUPS[:everyone].to_s
         return true
       end
diff --git a/lib/summarization/entry_point.rb b/lib/summarization/entry_point.rb
@@ -19,7 +19,7 @@ def inject_into(plugin)
 
         plugin.register_modifier(:topic_query_create_list_topics) do |topics, options|
           if Discourse.filters.include?(options[:filter]) && SiteSetting.ai_summarization_enabled &&
-               SiteSetting.ai_summarize_max_topic_gists_per_batch > 0
+               SiteSetting.ai_summary_gists_enabled
             topics.includes(:ai_gist_summary)
           else
             topics
@@ -39,7 +39,7 @@ def inject_into(plugin)
         # jobs if the feature is disabled.
         plugin.on(:post_created) do |post|
           if SiteSetting.discourse_ai_enabled && SiteSetting.ai_summarization_enabled &&
-               SiteSetting.ai_summarize_max_topic_gists_per_batch > 0 && post.topic
+               SiteSetting.ai_summary_gists_enabled > 0 && post.topic
             Jobs.enqueue(:fast_track_topic_gist, topic_id: post&.topic_id)
           end
         end
diff --git a/spec/jobs/regular/fast_track_topic_gist_spec.rb b/spec/jobs/regular/fast_track_topic_gist_spec.rb
@@ -9,7 +9,7 @@
     before do
       assign_fake_provider_to(:ai_summarization_model)
       SiteSetting.ai_summarization_enabled = true
-      SiteSetting.ai_summarize_max_topic_gists_per_batch = 100
+      SiteSetting.ai_summary_gists_enabled = true
     end
 
     context "when the topic has a gist" do
diff --git a/spec/jobs/regular/hot_topics_gist_batch_spec.rb b/spec/jobs/regular/hot_topics_gist_batch_spec.rb
@@ -0,0 +1,126 @@
+# frozen_string_literal: true
+
+RSpec.describe Jobs::HotTopicsGistBatch do
+  fab!(:topic_1) { Fabricate(:topic) }
+  fab!(:post_1) { Fabricate(:post, topic: topic_1, post_number: 1) }
+  fab!(:post_2) { Fabricate(:post, topic: topic_1, post_number: 2) }
+
+  before do
+    assign_fake_provider_to(:ai_summarization_model)
+    SiteSetting.ai_summarization_enabled = true
+    SiteSetting.ai_summary_gists_enabled = true
+  end
+
+  describe "#execute" do
+    context "when there is a topic with a hot score" do
+      before { TopicHotScore.create!(topic_id: topic_1.id, score: 0.1) }
+
+      it "does nothing if the plugin is disabled" do
+        SiteSetting.discourse_ai_enabled = false
+
+        subject.execute({})
+
+        gist = AiSummary.gist.find_by(target: topic_1)
+        expect(gist).to be_nil
+      end
+
+      it "does nothing if the summarization module is disabled" do
+        SiteSetting.ai_summarization_enabled = false
+
+        subject.execute({})
+
+        gist = AiSummary.gist.find_by(target: topic_1)
+        expect(gist).to be_nil
+      end
+
+      it "does nothing if hot topics summarization is disabled" do
+        SiteSetting.ai_summary_gists_enabled = false
+
+        subject.execute({})
+
+        gist = AiSummary.gist.find_by(target: topic_1)
+        expect(gist).to be_nil
+      end
+
+      it "creates a gist" do
+        gist_result = "I'm a gist"
+
+        DiscourseAi::Completions::Llm.with_prepared_responses([gist_result]) { subject.execute({}) }
+
+        gist = AiSummary.gist.find_by(target: topic_1)
+        expect(gist.summarized_text).to eq(gist_result)
+      end
+
+      context "when we already generated a gist of it" do
+        fab!(:ai_gist) do
+          Fabricate(
+            :topic_ai_gist,
+            target: topic_1,
+            original_content_sha: AiSummary.build_sha("12"),
+          )
+        end
+
+        it "does nothing if the gist is up to date" do
+          updated_gist = "They updated me :("
+
+          DiscourseAi::Completions::Llm.with_prepared_responses([updated_gist]) do
+            subject.execute({})
+          end
+
+          gist = AiSummary.gist.find_by(target: topic_1)
+          expect(AiSummary.gist.where(target: topic_1).count).to eq(1)
+          expect(gist.summarized_text).not_to eq(updated_gist)
+          expect(gist.original_content_sha).to eq(ai_gist.original_content_sha)
+        end
+
+        it "regenerates it if it's outdated" do
+          Fabricate(:post, topic: topic_1, post_number: 3)
+          gist_result = "They updated me"
+
+          DiscourseAi::Completions::Llm.with_prepared_responses([gist_result]) do
+            subject.execute({})
+          end
+
+          gist = AiSummary.gist.find_by(target: topic_1)
+          expect(gist.summarized_text).to eq(gist_result)
+          expect(gist.original_content_sha).to eq(AiSummary.build_sha("123"))
+        end
+      end
+    end
+
+    context "when there is a topic but it doesn't have a hot score" do
+      it "does nothing" do
+        subject.execute({})
+
+        gist = AiSummary.gist.find_by(target: topic_1)
+        expect(gist).to be_nil
+      end
+    end
+
+    context "when there are multiple hot topics" do
+      fab!(:topic_2) { Fabricate(:topic) }
+      fab!(:post_2_1) { Fabricate(:post, topic: topic_2, post_number: 1) }
+      fab!(:post_2_2) { Fabricate(:post, topic: topic_2, post_number: 2) }
+
+      before do
+        TopicHotScore.create!(topic_id: topic_1.id, score: 0.2)
+        TopicHotScore.create!(topic_id: topic_2.id, score: 0.4)
+      end
+
+      it "processes them by score order" do
+        topic_1_gist = "I'm gist of topic 1"
+        topic_2_gist = "I'm gist of topic 2"
+
+        DiscourseAi::Completions::Llm.with_prepared_responses([topic_2_gist, topic_1_gist]) do
+          subject.execute({})
+        end
+
+        gist = AiSummary.gist.find_by(target: topic_1)
+        expect(gist.summarized_text).to eq(topic_1_gist)
+
+        gist_2 = AiSummary.gist.find_by(target: topic_2)
+        expect(gist_2.summarized_text).to eq(topic_2_gist)
+      end
+    end
+  end
+end
diff --git a/spec/lib/guardian_extensions_spec.rb b/spec/lib/guardian_extensions_spec.rb
@@ -9,7 +9,7 @@
     group.add(user)
     assign_fake_provider_to(:ai_summarization_model)
     SiteSetting.ai_summarization_enabled = true
-    SiteSetting.ai_summarize_max_topic_gists_per_batch = 1
+    SiteSetting.ai_summary_gists_enabled = true
   end
 
   let(:anon_guardian) { Guardian.new }
diff --git a/spec/lib/modules/summarization/entry_point_spec.rb b/spec/lib/modules/summarization/entry_point_spec.rb
@@ -4,7 +4,7 @@
   before do
     assign_fake_provider_to(:ai_summarization_model)
     SiteSetting.ai_summarization_enabled = true
-    SiteSetting.ai_summarize_max_topic_gists_per_batch = 100
+    SiteSetting.ai_summary_gists_enabled = true
   end
 
   fab!(:user)
@@ -63,7 +63,7 @@
           before do
             group.add(user)
             SiteSetting.ai_hot_topic_gists_allowed_groups = group.id
-            SiteSetting.ai_summarize_max_topic_gists_per_batch = 100
+            SiteSetting.ai_summary_gists_enabled = true
           end
 
           it "includes the summary" do
