more code removal

Author: SamSaffron

lib/completions/endpoints/anthropic.rb

@@ -63,6 +63,10 @@ def model_uri
           URI(llm_model.url)
         end
 
+        def xml_tools_enabled?
+          !@native_tool_support
+        end
+
         def prepare_payload(prompt, model_params, dialect)
           @native_tool_support = dialect.native_tool_support?
 
@@ -97,15 +101,15 @@ def decode_chunk(partial_data)
           end.compact
         end
 
+        def decode(response_data)
+          processor.process_message(response_data)
+        end
+
         def processor
           @processor ||=
             DiscourseAi::Completions::AnthropicMessageProcessor.new(streaming_mode: @streaming_mode)
         end
 
-        def extract_completion_from(response_raw)
-          processor.process_message(response_raw)
-        end
-
         def has_tool?(_response_data)
           processor.tool_calls.present?
         end
@@ -118,10 +122,6 @@ def final_log_update(log)
           log.request_tokens = processor.input_tokens if processor.input_tokens
           log.response_tokens = processor.output_tokens if processor.output_tokens
         end
-
-        def partials_from(decoded_chunk)
-          decoded_chunk.split("\n").map { |line| line.split("data: ", 2)[1] }.compact
-        end
       end
     end
   end

lib/completions/endpoints/aws_bedrock.rb

@@ -176,24 +176,13 @@ def processor
             DiscourseAi::Completions::AnthropicMessageProcessor.new(streaming_mode: @streaming_mode)
         end
 
-        def add_to_function_buffer(function_buffer, partial: nil, payload: nil)
-          processor.to_xml_tool_calls(function_buffer) if !partial
-        end
-
-
         def has_tool?(_response_data)
           processor.tool_calls.present?
         end
 
         def xml_tools_enabled?
           !@native_tool_support
         end
-
-        def chunk_to_string(chunk)
-          joined = +chunk.join("\n")
-          joined << "\n" if joined.length > 0
-          joined
-        end
       end
     end
   end

lib/completions/endpoints/base.rb

@@ -123,8 +123,8 @@ def perform_completion!(
 
               if !@streaming_mode
                 response_raw = response.read_body
+                partials_raw = response_raw
                 response_data = decode(response_raw)
-                partials_raw = response_data.to_s
 
                 if xml_tool_processor
                   processed = (xml_tool_processor << response_data)
@@ -143,9 +143,10 @@ def perform_completion!(
                     end
                   }
                   response_data << xml_stripper.finish
-                  response_data.compact!
                 end
 
+                response_data.reject!(&:blank?)
+
                 # this is to keep stuff backwards compatible
                 response_data = response_data.first if response_data.length == 1
 
@@ -264,13 +265,6 @@ def xml_tools_enabled?
           raise NotImplementedError
         end
 
-        def build_buffer
-          Nokogiri::HTML5.fragment(<<~TEXT)
-          <function_calls>
-          #{noop_function_call_text}
-          </function_calls>
-          TEXT
-        end
 
         def self.noop_function_call_text
           (<<~TEXT).strip