pms

Author: nattsw

app/jobs/regular/detect_translate_post.rb

@@ -14,7 +14,10 @@ def execute(args)
 
       if SiteSetting.ai_translation_backfill_limit_to_public_content
         topic = post.topic
-        return if topic.blank? || topic.category&.read_restricted?
+        if topic.blank? || topic.category&.read_restricted? ||
+             topic.archetype == Archetype.private_message
+          return
+        end
       end
 
       begin

app/jobs/regular/localize_posts.rb

@@ -31,12 +31,10 @@ def execute(args)
 
         if SiteSetting.ai_translation_backfill_limit_to_public_content
           posts =
-            posts.joins(:topic).where(
-              topics: {
-                category_id: Category.where(read_restricted: false).select(:id),
-                archetype: "regular",
-              },
-            )
+            posts
+              .joins(:topic)
+              .where(topics: { category_id: Category.where(read_restricted: false).select(:id) })
+              .where.not(topics: { archetype: Archetype.private_message })
         end
 
         if SiteSetting.ai_translation_backfill_max_age_days > 0

spec/jobs/regular/detect_translate_post_spec.rb

@@ -81,5 +81,8 @@
     DiscourseAi::Translation::PostLocalizer.expects(:localize).never
 
     job.execute({ post_id: post.id })
+
+    pm_post = Fabricate(:post, topic: Fabricate(:private_message_topic))
+    job.execute({ post_id: pm_post.id })
   end
 end

spec/jobs/regular/localize_posts_spec.rb

@@ -126,33 +126,35 @@
     fab!(:private_category) { Fabricate(:private_category, group: Group[:staff]) }
     fab!(:private_topic) { Fabricate(:topic, category: private_category) }
     fab!(:private_post) { Fabricate(:post, topic: private_topic, locale: "es") }
+
+    fab!(:pm_post) { Fabricate(:post, topic: Fabricate(:private_message_topic), locale: "es") }
+
     fab!(:public_post) { Fabricate(:post, locale: "es") }
 
-    before { SiteSetting.ai_translation_backfill_limit_to_public_content = true }
+    before do
+      SiteSetting.ai_translation_backfill_limit_to_public_content = true
+      SiteSetting.experimental_content_localization_supported_locales = "ja"
+    end
 
     it "only processes posts from public categories" do
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(public_post, "en").once
       DiscourseAi::Translation::PostLocalizer.expects(:localize).with(public_post, "ja").once
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(public_post, "de").once
 
       DiscourseAi::Translation::PostLocalizer
         .expects(:localize)
         .with(private_post, any_parameters)
         .never
 
+      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(pm_post, any_parameters).never
+
       job.execute({})
     end
 
     it "processes all posts when setting is disabled" do
       SiteSetting.ai_translation_backfill_limit_to_public_content = false
 
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(public_post, "en").once
       DiscourseAi::Translation::PostLocalizer.expects(:localize).with(public_post, "ja").once
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(public_post, "de").once
-
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(private_post, "en").once
+      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(pm_post, "ja").once
       DiscourseAi::Translation::PostLocalizer.expects(:localize).with(private_post, "ja").once
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(private_post, "de").once
 
       job.execute({})
     end
@@ -162,12 +164,13 @@
     fab!(:old_post) { Fabricate(:post, locale: "es", created_at: 10.days.ago) }
     fab!(:new_post) { Fabricate(:post, locale: "es", created_at: 2.days.ago) }
 
-    before { SiteSetting.ai_translation_backfill_max_age_days = 5 }
+    before do
+      SiteSetting.ai_translation_backfill_max_age_days = 5
+      SiteSetting.experimental_content_localization_supported_locales = "ja"
+    end
 
     it "only processes posts within the age limit" do
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(new_post, "en").once
       DiscourseAi::Translation::PostLocalizer.expects(:localize).with(new_post, "ja").once
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(new_post, "de").once
 
       DiscourseAi::Translation::PostLocalizer
         .expects(:localize)
@@ -180,13 +183,9 @@
     it "processes all posts when setting is disabled" do
       SiteSetting.ai_translation_backfill_max_age_days = 0
 
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(new_post, "en").once
       DiscourseAi::Translation::PostLocalizer.expects(:localize).with(new_post, "ja").once
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(new_post, "de").once
 
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(old_post, "en").once
       DiscourseAi::Translation::PostLocalizer.expects(:localize).with(old_post, "ja").once
-      DiscourseAi::Translation::PostLocalizer.expects(:localize).with(old_post, "de").once
 
       job.execute({})
     end