This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: smart date support for AI helper #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature allows conversion of human typed in dates and times to smart "Discourse" timezone friendly dates.
Member
keegangeorge
left a comment
keegangeorge
left a comment
There was a problem hiding this comment.
Overall looks great! I'm excited for this, it's a nifty little feature.
Can we add system specs for this?
| cp.messages = { | ||
| insts: <<~TEXT, | ||
| You are a date and time formatter for Discourse posts. Convert natural language time references into date placeholders. | ||
| Do not modify any markdown, code blocks, or existing date formats. |
Member
There was a problem hiding this comment.
Can we also add specs that checks to ensure it doesn't modify any of these?
Member
Author
There was a problem hiding this comment.
this is going to be pretty impossible, the llm is in charge of this.
Member
There was a problem hiding this comment.
Oh I meant, passing markdown containing code blocks for example, and checking if after the LLM call, the code blocks are still in-tact. But yes, I guess we can only mock calls in specs, so feel free to ignore then.
Member
Author
|
system spec feels expensive for this especially since helper is already covered... added a bit more internal coverage though |
keegangeorge
approved these changes
Dec 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows conversion of human typed in dates and times
to smart "Discourse" timezone friendly dates.