Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/discourse_ai/admin/ai_spam_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def update
llm_model_id = updated_params[:llm_model_id] = allowed_params[:llm_model_id]
if llm_model_id.to_i < 0 &&
!SiteSetting.ai_spam_detection_model_allowed_seeded_models_map.include?(
"custom:#{llm_model_id}",
llm_model_id.to_s,
)
return(
render_json_error(
Expand Down
22 changes: 21 additions & 1 deletion spec/requests/admin/ai_spam_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

expect(response.status).to eq(422)

SiteSetting.ai_spam_detection_model_allowed_seeded_models = seeded_llm.identifier
SiteSetting.ai_spam_detection_model_allowed_seeded_models = seeded_llm.id.to_s

put "/admin/plugins/discourse-ai/ai-spam.json",
params: {
Expand All @@ -49,6 +49,26 @@
expect(response.status).to eq(200)
end

it "ensures that seeded llm ID is properly passed and allowed" do
seeded_llm = Fabricate(:seeded_model)

SiteSetting.ai_spam_detection_model_allowed_seeded_models = [
llm_model.id,
seeded_llm.id,
].join("|")

put "/admin/plugins/discourse-ai/ai-spam.json",
params: {
is_enabled: true,
llm_model_id: seeded_llm.id,
custom_instructions: "custom instructions",
}
expect(SiteSetting.ai_spam_detection_model_allowed_seeded_models).to eq(
"#{llm_model.id}|#{seeded_llm.id}",
)
expect(response.status).to eq(200)
end

it "can not enable spam detection without a model selected" do
put "/admin/plugins/discourse-ai/ai-spam.json",
params: {
Expand Down
Loading